Summary

Add a user creation API

Review Request #8185 — Created May 24, 2016 and submitted June 9, 2016, 10:37 a.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

f90e8bd...

Reviewers

Groups

reviewboard

People

Description

Users can now be created through the /api/users/ endpoint. This is
only available on the global api (i.e, not on any local sites) and to
superusers.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Perhaps we should check the auth.add_user permission instead?	david	June 7, 2016, 4:48 p.m.
Is create_user not atomic on its own??	david	June 7, 2016, 4:47 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py

Change Summary:

Add new unit tests and improve existing ones; add e-mail validation

Diff:

Revision 2 (+190 -5)

Show changes

	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/test_user.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py

reviewboard/webapi/resources/user.py (Diff revision 2)

Show all issues

Perhaps we should check the auth.add_user permission instead?

reviewboard/webapi/resources/user.py (Diff revision 2)

Show all issues

Is create_user not atomic on its own??

brennie June 7, 2016, 1:53 p.m.

It is, but this is to ensure that unit tests dont explode. I'll add a comment.

Change Summary:

Address issues

Diff:

Revision 3 (+230 -6)

Show changes

	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/test_user.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (ff518f5)