Add a user creation API

Review Request #8185 — Created May 24, 2016 and submitted

Information

Review Board
release-2.5.x
f90e8bd...

Reviewers

Users can now be created through the /api/users/ endpoint. This is
only available on the global api (i.e, not on any local sites) and to
superusers.

Ran unit tests.

Description From Last Updated

Perhaps we should check the auth.add_user permission instead?

daviddavid

Is create_user not atomic on its own??

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/webapi/resources/user.py (Diff revision 2)
     
     
     
     

    Perhaps we should check the auth.add_user permission instead?

  3. reviewboard/webapi/resources/user.py (Diff revision 2)
     
     
     
     
     

    Is create_user not atomic on its own??

    1. It is, but this is to ensure that unit tests dont explode. I'll add a comment.

  4. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (ff518f5)
Loading...