• 
      

    Fix some issues with infoboxes.

    Review Request #8175 — Created May 20, 2016 and submitted

    Information

    Review Board
    release-3.0.x
    d084d02...

    Reviewers

    This fixes several issues with the new infobox implementation. To start with,
    we now had one DOM element per possible infobox, which was a lot of elements
    when looking at a dashboard. During the conversion, I also lost the timeout
    before the infobox was shown. These two things combined so that if you quickly
    scrolled your mouse across a bunch of users, it would pop up a ton of
    infoboxes.

    All the views for any given type now share a single element, and coordinate a
    bit so that if you switch which user you're looking at (or which bug), the
    infobox will update immedatiely rather than waiting for a new timeout.

    This also fixes a small styling issue that presented when users had their
    profile set to private.

    Looked at a dashboard and tested several of the weird cases that arose when
    mousing over the "submitter" column. Set my profile to private and looked at
    the infobox that resulted.

    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/ui/views/infoboxView.es6.js
          reviewboard/static/rb/css/common.less
          reviewboard/static/rb/js/common.es6.js
      
      
      
      Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/ui/views/infoboxView.es6.js
          reviewboard/static/rb/css/common.less
          reviewboard/static/rb/js/common.es6.js
      
      
    2. 
        
    brennie
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (752f8d2)