• 
      

    Tweak the visuals for DnD overlays a bit.

    Review Request #8174 — Created May 20, 2016 and submitted

    Information

    Review Board
    ucosp/dkus/dnd-inline-images
    3e76c8f...

    Reviewers

    The original implementation had the overlays just change the border color when
    hovering over them to drop. This wasn't a particularly noticible transition,
    especially given the other colors we use on the page. This change switches that
    over to just lightening the background color instead.

    While I was doing this, I also fixed the code to cope with padding, which was
    an issue on the file attachments overlay when there were existing file
    attachment thumbnails present.

    Did some drops.


    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/css/defs.less
          reviewboard/static/rb/css/ui/dnd-uploader.less
          reviewboard/static/rb/js/views/dndUploaderView.es6.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/css/defs.less
          reviewboard/static/rb/css/ui/dnd-uploader.less
          reviewboard/static/rb/js/views/dndUploaderView.es6.js
      
      
    2. 
        
    brennie
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:

    Pushed to ucosp/dkus/dnd-inline-images (991b766)