Allow integration forms to use admin widgets and the current HttpRequest.

Review Request #8167 — Created May 16, 2016 and submitted

Information

Djblets
release-0.10.x

Reviewers

The integration configuration forms now allow the use of admin widgets,
like the side-by-side multi-select field. The necessary JavaScript files
are loaded onto the page to support those widgets.

The configuration forms also now take a request parameter, which allows
subclasses to provide options based on the request (such as restricting
objects for the configuration for the owning user or organization).

Made use of the request and admin widgets in an integration.

reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        djblets/integrations/forms.py
        djblets/integrations/views.py
    
    Ignored Files:
        djblets/integrations/templates/integrations/configure_integration.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        djblets/integrations/forms.py
        djblets/integrations/views.py
    
    Ignored Files:
        djblets/integrations/templates/integrations/configure_integration.html
    
    
  2. 
      
david
  1. Can you clarify in your description that these are form widgets and not the widgets on the admin dashboard?

    1. It's in Djblets, so there's no concept of widgets here.

    2. As in, no concept of admin widgets.

    3. Dashboard widgets I mean. I am tired.

    4. Probably true, but I still think it would be clearer if the commit message had "form widgets"

    5. For when we're tired.

    6. Doesn't the "integration forms" at the end help define that context?

      I'll try to reword it to say "forms" earlier.

  2. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (0667d7d)
Loading...