Summary

Allow integration forms to use admin widgets and the current HttpRequest.

Review Request #8167 — Created May 16, 2016 and submitted June 14, 2016, 5:11 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The integration configuration forms now allow the use of admin widgets,
like the side-by-side multi-select field. The necessary JavaScript files
are loaded onto the page to support those widgets.

The configuration forms also now take a request parameter, which allows
subclasses to provide options based on the request (such as restricting
objects for the configuration for the owning user or organization).

Testing Done

Made use of the request and admin widgets in an integration.

Tool: PEP8 Style Checker
Processed Files:
    djblets/integrations/forms.py
    djblets/integrations/views.py

Ignored Files:
    djblets/integrations/templates/integrations/configure_integration.html



Tool: Pyflakes
Processed Files:
    djblets/integrations/forms.py
    djblets/integrations/views.py

Ignored Files:
    djblets/integrations/templates/integrations/configure_integration.html

Can you clarify in your description that these are form widgets and not the widgets on the admin dashboard?

chipx86 May 17, 2016, 5:28 p.m.

It's in Djblets, so there's no concept of widgets here.

chipx86 May 17, 2016, 5:28 p.m.
```
As in, no concept of admin widgets.
```
chipx86 May 17, 2016, 5:28 p.m.
```
Dashboard widgets I mean. I am tired.
```

david May 17, 2016, 5:34 p.m.

Probably true, but I still think it would be clearer if the commit message had "form widgets"

david May 17, 2016, 5:34 p.m.
```
For when we're tired.
```

chipx86 May 17, 2016, 5:34 p.m.

Doesn't the "integration forms" at the end help define that context?

I'll try to reword it to say "forms" earlier.

Summary:: Allow the use of admin widgets and request access in integration forms.
Allow integration forms to use admin widgets and the current HttpRequest.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.10.x (0667d7d)