Summary

Prevent repos being created with Hg over SSH

Review Request #8158 — Created May 12, 2016 and submitted May 13, 2016, 3:20 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

3cbabd1...

Reviewers

Groups

reviewboard

People

Description

Mercurial doesn't allow SSH urls, so we explicitly prevent them in the

SCMTool class for Mercurial. The code has been updated to be more

robust and use urlparse to extract the scheme from the URL.

Testing Done


Attempted to create a SSH repository; it failed as expected.
Ran unit tests.

Issues

Description	From	Last Updated
Shouldn't we also check to make sure there's no raw file URL specified? I think it's fine to have an …	david	May 12, 2016, 9:27 p.m.
This loses support for https.	david	May 13, 2016, 1:27 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/hg.py

reviewboard/scmtools/hg.py (Diff revision 1)

The issue has been dropped. Show all issues

Shouldn't we also check to make sure there's no raw file URL specified? I think it's fine to have an ssh path as long as there's also a raw file URL.

brennie May 12, 2016, 9:29 p.m.

Hg doesn't have support for a raw file URL.

brennie May 12, 2016, 9:30 p.m.

And if they're running some HTTP server to serve their HG stuff, its most likely hgweb which we support over http

david May 13, 2016, 1:25 p.m.
```
OK.
```

reviewboard/scmtools/hg.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This loses support for https.
```

Change Summary:

Addressed David's issue

Diff:

Revision 2 (+15 -4)

Show changes

	reviewboard/scmtools/hg.py
	reviewboard/scmtools/tests.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/hg.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (1e27a68)