Change the API used to test credentials for Codebase HQ.

Review Request #8156 — Created May 12, 2016 and submitted

Information

Review Board
release-2.0.x

Reviewers

To test authentication credentials for Codebase HQ, we were performing
an HTTP GET to the roles API. However, it turns out that not all users
can access this resource, so it makes for a bad test. Instead, we're now
accessing the API for the user's public keys, which is allowed for any
given user, fixing the authentication test.

Unit tests pass.

Had a customer test this API for their restricted user.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/codebasehq.py
        reviewboard/hostingsvcs/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/codebasehq.py
        reviewboard/hostingsvcs/tests.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (e4c251f)
Loading...