Moved comment dialog buttons for easier form submission.

Review Request #8153 — Created May 11, 2016 and discarded

davidwalsh
Review Board
reviewboard

The default value of the checkboxes in the comment dialog are likely not changed often and thus setting the [tab] button priority from the comment box to the "OK" button improves user experience: fewer keypresses to complete the comment.

  • Clicking into the comment textarea, then tabbing to buttons.
Loading file attachments...

Description From Last Updated

I feel like the buttons should be on the right. You can accomplish this with the tabindex attribute

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
david
  1. Can you attach before/after screenshots?

  2. 
      
DA
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/commentDialogView.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
DA
brennie
  1. 
      
  2. I feel like the buttons should be on the right. You can accomplish this with the tabindex attribute

  3. 
      
chipx86
  1. Thanks for the contribution. I think we're going to leave these as-is for now, for a few reasons:

    1) The buttons are now positioned pretty awkwardly. Plus this seems to be showing all the button states now?
    2) This is going to just wreck a bunch of the extensions out there that add checkboxes or buttons to the comment dialog.
    3) While I understand the tab situation, there are other keyboard shortcuts (Control-Enter for Save, Escape for Cancel) that you can use instead of tabbing to the desired button. Delete is the exception, but that's also not going to be super common (and I'd rather add a shortcut for that than to change the design of this dialog just for this).

    1. Per your points:

      1. I'm showing all buttons to prove the checkboxes and all buttons, if ever present, will fit.
      2. Valid point.
      3. I see that CONTROL+ENTER does work (nice!) but COMMAND+ENTER (for Macs, for example) does not. Would you be interested in a COMMAND+ENTER patch?
    2. I know we've been discussing this already on the other review request, but since I may not have given a firm answer yet, yes, I'd love a patch for Command-Enter :)

      Given that, I'd like to discard this change, as I think the keyboard shortcuts solve the real problem this change is trying to address (making it easier to press the buttons).

    3. No problem, will close.

  2. 
      
DA
Review request changed

Status: Discarded

Loading...