Summary

Moved comment dialog buttons for easier form submission.

Review Request #8153 — Created May 11, 2016 and discarded May 16, 2016, 6:36 a.m.

Information

Owner

davidwalsh

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The default value of the checkboxes in the comment dialog are likely not changed often and thus setting the [tab] button priority from the comment box to the "OK" button improves user experience: fewer keypresses to complete the comment.

Testing Done


Clicking into the comment textarea, then tabbing to buttons.

Files

Issues

Description	From	Last Updated
I feel like the buttons should be on the right. You can accomplish this with the tabindex attribute	brennie	May 11, 2016, 1:45 p.m.

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/css/pages/reviews.less



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/css/pages/reviews.less

Can you attach before/after screenshots?

Change Summary:

(Found a JS warning so I've updated my patch)

Diff:

Revision 2 (+13 -12)

Show changes

	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/static/rb/js/views/commentDialogView.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/css/pages/reviews.less



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/css/pages/reviews.less

Change Summary:: Screenshots as requested.
Added Files:

Fix it!

After (Revision 1)

An issue was opened. Show all issues

I feel like the buttons should be on the right. You can accomplish this with the tabindex attribute

Thanks for the contribution. I think we're going to leave these as-is for now, for a few reasons:

1) The buttons are now positioned pretty awkwardly. Plus this seems to be showing all the button states now?
2) This is going to just wreck a bunch of the extensions out there that add checkboxes or buttons to the comment dialog.
3) While I understand the tab situation, there are other keyboard shortcuts (Control-Enter for Save, Escape for Cancel) that you can use instead of tabbing to the desired button. Delete is the exception, but that's also not going to be super common (and I'd rather add a shortcut for that than to change the design of this dialog just for this).

davidwalsh May 12, 2016, 11:19 a.m.

Per your points:

I'm showing all buttons to prove the checkboxes and all buttons, if ever present, will fit.
Valid point.
I see that CONTROL+ENTER does work (nice!) but COMMAND+ENTER (for Macs, for example) does not. Would you be interested in a COMMAND+ENTER patch?

chipx86 May 15, 2016, 3:18 a.m.

I know we've been discussing this already on the other review request, but since I may not have given a firm answer yet, yes, I'd love a patch for Command-Enter :)

Given that, I'd like to discard this change, as I think the keyboard shortcuts solve the real problem this change is trying to address (making it easier to press the buttons).

DA

davidwalsh May 16, 2016, 6:36 a.m.
```
No problem, will close.
```

Status:: Discarded