post-review: Fix handling of spaces in file paths when using Perforce
Review Request #815 — Created April 14, 2009 and submitted
|Review Board SVN (deprecated)|
Fixes a problem where changes files with spaces in their paths would end up appearing as deleted content in Review Board diffs. Changed the Perforce output format to use the -ztag switch, and then modified the parsing code to pull out the full path including the space(s). This was a change that I originally attached to the following issue http://code.google.com/p/reviewboard/issues/detail?id=840
Tested on Mac OS X with a changed file that has a space in it's full path.
I finally got around to implementing the change suggested by Eric Huss to use the _run_p4 method. It seems to work in my light testing.
Revision 2 (+4 -12)
Looks good, thanks. Committed as r1990.