Summary

Fix up JS tests introduced by the submitters change

Review Request #8142 — Created May 2, 2016 and submitted May 2, 2016, 6:35 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

f341245...

Reviewers

Groups

reviewboard

People

Description

The JS tests introduced by the changing submitters patch have been
updated to use the new Jasmine methods (and.foo vs andFoo), as well
as fixing up a unit test that didn't trigger the correct behaviour. In
addition, we now render the current submitter to the
ReviewRequestEditorView through the review_detail view.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Trailing whitespace.	david	May 2, 2016, 5:01 p.m.
Single quotes?	david	May 2, 2016, 5:02 p.m.

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Trailing whitespace.
```
reviewboard/templates/reviews/reviewable_page_data.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Single quotes?
```

Change Summary:

Address David's issues

Diff:

Revision 2 (+16 -6)

Show changes

	reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js
	reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
	reviewboard/templates/reviews/reviewable_page_data.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
    reviewboard/templates/reviews/reviewable_page_data.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (6cd115b)