Fix up JS tests introduced by the submitters change
Review Request #8142 — Created May 2, 2016 and submitted
The JS tests introduced by the changing submitters patch have been
updated to use the new Jasmine methods (and.foo
vsandFoo
), as well
as fixing up a unit test that didn't trigger the correct behaviour. In
addition, we now render the current submitter to the
ReviewRequestEditorView
through thereview_detail
view.
Ran unit tests.
- Change Summary:
-
Address David's issues
- Diff:
-
Revision 2 (+16 -6)
-
Tool: Pyflakes Ignored Files: reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js reviewboard/templates/reviews/reviewable_page_data.js reviewboard/static/rb/js/views/reviewRequestEditorView.js Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js reviewboard/templates/reviews/reviewable_page_data.js reviewboard/static/rb/js/views/reviewRequestEditorView.js