Improve the styling for text fields and Markdown code blocks.

Review Request #8136 — Created April 29, 2016 and submitted

Information

Review Board
release-3.0.x
05e4819...

Reviewers

This includes a few tweaks to all Markdown-capable text fields, with a
couple specific improvements for the review dialog and replies.

To help give breathing room to the lines of text (particularly with the
addition of borders around the inline code in rendered Markdown), the
lines have been given 2px more height. This applies to the rendered
text, textareas, and CodeMirror widgets.

The editors for the review dialog and review replies have some specific
styling improvements to align the editted and rendered text, much like
with the review request fields. Now when going into or out of edit mode,
the text won't shift.

This also removes the left and right borders from the code block in the
review request fields, making them flush with the sides of the field's
border.

Tested all the places where we render Markdown, in all the modes.


reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/common.less
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/common.less
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
mike_conley
  1. 
      
  2. This is beautiful. Good stuff!

  3. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (16876ff)
Loading...