Allow 'null' client roots

Review Request #8126 — Created April 20, 2016 and submitted

Information

RBTools

Reviewers

Windows perforce clients are allowed to specify the client root as 'null'. If this is the case don't attempt to determine that the current directory is below the client root because the check will fail. With a 'null' client root all paths are below the client root.


 
Description From Last Updated

Please start your sentences with a capital letter and end them in a period.

daviddavid

Since this is on windows, should we also check the platform type?

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/perforce.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/perforce.py
    
    
  2. 
      
david
  1. 
      
  2. rbtools/clients/perforce.py (Diff revision 1)
     
     
     
    Show all issues

    Please start your sentences with a capital letter and end them in a period.

  3. rbtools/clients/perforce.py (Diff revision 1)
     
     
    Show all issues

    Since this is on windows, should we also check the platform type?

  4. 
      
MD
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/clients/perforce.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/clients/perforce.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
MD
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.7.x (3cebcec)