Summary

Allow 'null' client roots

Review Request #8126 — Created April 20, 2016 and submitted April 26, 2016, 4:04 p.m.

Information

Owner

mdonlon

Repository

RBTools

Branch

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Windows perforce clients are allowed to specify the client root as 'null'. If this is the case don't attempt to determine that the current directory is below the client root because the check will fail. With a 'null' client root all paths are below the client root.

Testing Done

Issues

Description	From	Last Updated
Please start your sentences with a capital letter and end them in a period.	david	April 20, 2016, 4:21 p.m.
Since this is on windows, should we also check the platform type?	david	April 20, 2016, 4:21 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/perforce.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/perforce.py

rbtools/clients/perforce.py (Diff revision 1)

The issue has been resolved. Show all issues

Please start your sentences with a capital letter and end them in a period.

rbtools/clients/perforce.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Since this is on windows, should we also check the platform type?
```

Diff:

Revision 2 (+14 -9)

Show changes

rbtools/clients/perforce.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/perforce.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/perforce.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (3cebcec)