Summary

RBGateway -Preliminary architecture for supporting webhooks

Review Request #8112 — Created April 10, 2016 and discarded Jan. 29, 2019, 1:43 p.m.

Information

Owner

Repository

rb-gateway

Branch

master

Bugs

Depends On

Reviewers

Groups

rb-gateway, students

People

Description

Preliminary architecture for supporting webhooks

New webhook.go - defines the structure and interface for a webhook. Almost a carbon copy of webhook spec from here but with some getters and setters.

New events.go - a combinations of reviewboard's reviewboard.reviews.signals and django's django.dispatch.signal, it defines a global of all the events that rb-gateway supports.

routes.go - added 2 new api routes. 1 for registering a new webhook and 1 for accessing/editing webhooks.

config.json - supports new config keys for defining webhooks

util.go - added new functions for creating webhooks and editing them

Testing Done

None yet but what is planned:

webhook_test.go
Test notify in webhook
Test get json in webhook
Test getters/setters

util_test.go
Test webhook/event/repo portion of TestLoadConfig in util_test.go
Test register webhook in util
Test delete webhook in util
Test save webhook in util
Test refresh config in util

events_test.go
Test get receivers
Test send
Test subscribe/unsubscribe

Issues

Description	From	Last Updated
This won't compile with an extraneous import.	brennie	April 25, 2016, 10:11 p.m.
"check" Comments should be proper sentences.	brennie	April 25, 2016, 10:11 p.m.
These comments should be below, on the items.	brennie	April 25, 2016, 10:13 p.m.

Tool: Pyflakes
Ignored Files:
    git_events.go
    webhook_events.go
    webhook.go



Tool: PEP8 Style Checker
Ignored Files:
    git_events.go
    webhook_events.go
    webhook.go

AQ

Groups:

+	students

AQ

Diff:

Revision 2 (+125 -6)

	rb-gateway_events.go
	routes.go
	webhook.go
	webhook_events.go

Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    webhook_events.go
    webhook.go
    routes.go



Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    webhook_events.go
    webhook.go
    routes.go

AQ

Description:

		Preliminary architecture for supporting webhooks
	+
	+	webhook.go - defines the basic structure and functionality for a webhook. Almost a carbon copy of webhook spec from here.
	+
	+	webhook_events.go - similar to django's django.dispatch.signal, it defines a signal that can generate events in rb-gateway. The info for these events is sent to interested parties
	+
	+	rb-gateway_events.go - similar to reviewboard's reviewboard.reviews.signals, it defines a global of all the events that rb-gateway supports.
	+
	+	routes.go - added 4 new api routes. 2 for registering/deregistering webhooks and 2 for enabling/disabling webhooks.
	+
	+	config.json - supports new config keys for configuring new webhooks and enabling webhooks
	+
	+	util.go - add new functions for parsing the config file

rb-gateway_events.go (Diff revision 2)

Show all issues

This won't compile with an extraneous import.

routes.go (Diff revision 2)

Show all issues

"check"

Comments should be proper sentences.

webhook.go (Diff revision 2)

Show all issues

These comments should be below, on the items.

AQ

Diff:

Revision 3 (+123 -6)

	rb-gateway_events.go
	routes.go
	webhook.go
	webhook_events.go

Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    webhook_events.go
    webhook.go
    routes.go



Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    webhook_events.go
    webhook.go
    routes.go

AQ

Diff:

Revision 4 (+126 -6)

	rb-gateway_events.go
	routes.go
	webhook.go
	webhook_events.go

Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    webhook_events.go
    webhook.go
    routes.go



Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    webhook_events.go
    webhook.go
    routes.go

AQ

Diff:

Revision 5 (+368 -6)

	rb-gateway_events.go
	routes.go
	util.go
	webhook.go

Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    webhook.go
    util.go
    routes.go



Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    webhook.go
    util.go
    routes.go

AQ

Diff:

Revision 6 (+370 -6)

	rb-gateway_events.go
	routes.go
	util.go
	webhook.go

Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    webhook.go
    util.go
    routes.go



Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    webhook.go
    util.go
    routes.go

AQ

Description:

		Preliminary architecture for supporting webhooks

~		webhook.go - defines the basic structure and functionality for a webhook. Almost a carbon copy of webhook spec from here.
	~	webhook.go - defines the structure and interface for a webhook. Almost a carbon copy of webhook spec from here but with some getters and setters.

~		webhook_events.go - similar to django's django.dispatch.signal, it defines a signal that can generate events in rb-gateway. The info for these events is sent to interested parties
	~	rb-gateway_events.go - a combinations of reviewboard's reviewboard.reviews.signals and django's django.dispatch.signal, it defines a global of all the events that rb-gateway supports and the signals that trigger them.

~		rb-gateway_events.go - similar to reviewboard's reviewboard.reviews.signals, it defines a global of all the events that rb-gateway supports.
	~	routes.go - added 2 new api routes. 1 for registering a new webhook and 1 for accessing/editing webhooks.

~		routes.go - added 4 new api routes. 2 for registering/deregistering webhooks and 2 for enabling/disabling webhooks.
	~	config.json - supports new config keys for defining webhooks

~		config.json - supports new config keys for configuring new webhooks and enabling webhooks
	~	util.go - added new functions for creating webhooks and editing them
-
-		util.go - add new functions for parsing the config file

Diff:

Revision 7 (+385 -6)

	rb-gateway_events.go
	routes.go
	util.go
	webhook.go

Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    webhook.go
    util.go
    routes.go



Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    webhook.go
    util.go
    routes.go

AQ

Diff:

Revision 8 (+398 -6)

	rb-gateway_events.go
	routes.go
	util.go
	webhook.go

Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    webhook.go
    util.go
    routes.go



Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    webhook.go
    util.go
    routes.go

AQ

Description:

		Preliminary architecture for supporting webhooks

~		webhook.go - defines the structure and interface for a webhook. Almost a carbon copy of webhook spec from here but with some getters and setters.
	~	New webhook.go - defines the structure and interface for a webhook. Almost a carbon copy of webhook spec from here but with some getters and setters.

~		rb-gateway_events.go - a combinations of reviewboard's reviewboard.reviews.signals and django's django.dispatch.signal, it defines a global of all the events that rb-gateway supports and the signals that trigger them.
	~	New rb-gateway_events.go - a combinations of reviewboard's reviewboard.reviews.signals and django's django.dispatch.signal, it defines a global of all the events that rb-gateway supports and the signals that trigger them.

		routes.go - added 2 new api routes. 1 for registering a new webhook and 1 for accessing/editing webhooks.

		config.json - supports new config keys for defining webhooks

		util.go - added new functions for creating webhooks and editing them

AQ

Diff:

Revision 9 (+469 -6)

	rb-gateway_events.go
	routes.go
	util.go
	webhook.go

Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    webhook.go
    util.go
    routes.go



Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    webhook.go
    util.go
    routes.go

AQ

Diff:

Revision 10 (+477 -6)

	main.go
	rb-gateway_events.go
	routes.go
	util.go
	webhook.go

Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    main.go
    util.go
    webhook.go
    routes.go



Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    main.go
    util.go
    webhook.go
    routes.go

AQ

Diff:

Revision 11 (+555 -19)

	main.go
	rb-gateway_events.go
	routes.go
	util.go
	webhook.go

Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    main.go
    util.go
    webhook.go
    routes.go



Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    main.go
    util.go
    webhook.go
    routes.go

AQ

Diff:

Revision 12 (+556 -19)

	main.go
	rb-gateway_events.go
	routes.go
	util.go
	webhook.go

Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    main.go
    util.go
    webhook.go
    routes.go



Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    main.go
    util.go
    webhook.go
    routes.go

AQ

Diff:

Revision 13 (+569 -19)

	main.go
	rb-gateway_events.go
	routes.go
	util.go
	webhook.go

Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    main.go
    util.go
    webhook.go
    routes.go



Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    main.go
    util.go
    webhook.go
    routes.go

AQ

Diff:

Revision 14 (+562 -19)

	main.go
	rb-gateway_events.go
	routes.go
	util.go
	webhook.go

Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    main.go
    util.go
    webhook.go
    routes.go



Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    main.go
    util.go
    webhook.go
    routes.go

AQ

Description:

		Preliminary architecture for supporting webhooks

		New webhook.go - defines the structure and interface for a webhook. Almost a carbon copy of webhook spec from here but with some getters and setters.

~		New rb-gateway_events.go - a combinations of reviewboard's reviewboard.reviews.signals and django's django.dispatch.signal, it defines a global of all the events that rb-gateway supports and the signals that trigger them.
	~	New rb-gateway_events.go - a combinations of reviewboard's reviewboard.reviews.signals and django's django.dispatch.signal, it defines a global of all the events that rb-gateway supports.

		routes.go - added 2 new api routes. 1 for registering a new webhook and 1 for accessing/editing webhooks.

		config.json - supports new config keys for defining webhooks

		util.go - added new functions for creating webhooks and editing them

Diff:

Revision 15 (+506 -19)

	main.go
	rb-gateway_events.go
	routes.go
	util.go
	webhook.go

Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    main.go
    util.go
    webhook.go
    routes.go



Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    main.go
    util.go
    webhook.go
    routes.go

AQ

Diff:

Revision 16 (+566 -19)

	main.go
	rb-gateway_events.go
	routes.go
	util.go
	webhook.go

Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    main.go
    util.go
    webhook.go
    routes.go



Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    main.go
    util.go
    webhook.go
    routes.go

AQ

Change Summary:

Removed WIP tag

Summary:

-	[WIP] Preliminary architecture for supporting webhooks
+	Preliminary architecture for supporting webhooks

AQ

Summary:

-	Preliminary architecture for supporting webhooks
+	RBGateway -Preliminary architecture for supporting webhooks

AQ

Diff:

Revision 17 (+547 -19)

	rb-gateway_events.go
	routes.go
	util.go
	webhook.go

Tool: Pyflakes
Ignored Files:
    rb-gateway_events.go
    webhook.go
    util.go
    routes.go



Tool: PEP8 Style Checker
Ignored Files:
    rb-gateway_events.go
    webhook.go
    util.go
    routes.go

AQ

Description:

		Preliminary architecture for supporting webhooks

		New webhook.go - defines the structure and interface for a webhook. Almost a carbon copy of webhook spec from here but with some getters and setters.

~		New rb-gateway_events.go - a combinations of reviewboard's reviewboard.reviews.signals and django's django.dispatch.signal, it defines a global of all the events that rb-gateway supports.
	~	New events.go - a combinations of reviewboard's reviewboard.reviews.signals and django's django.dispatch.signal, it defines a global of all the events that rb-gateway supports.

		routes.go - added 2 new api routes. 1 for registering a new webhook and 1 for accessing/editing webhooks.

		config.json - supports new config keys for defining webhooks

		util.go - added new functions for creating webhooks and editing them

Testing Done:

	+	None yet but what is planned:
	+
	+	webhook_test.go
	+	Test notify in webhook
	+	Test get json in webhook
	+	Test getters/setters
	+
	+	util_test.go
	+	Test webhook/event/repo portion of TestLoadConfig in util_test.go
	+	Test register webhook in util
	+	Test delete webhook in util
	+	Test save webhook in util
	+	Test refresh config in util
	+
	+	event_test.go
	+	Test get receivers
	+	Test send
	+	Test subscribe/unsubscribe

Diff:

Revision 18 (+639 -19)

	events.go
	routes.go
	util.go
	webhook.go

Tool: PEP8 Style Checker
Ignored Files:
    events.go
    webhook.go
    util.go
    routes.go



Tool: Pyflakes
Ignored Files:
    events.go
    webhook.go
    util.go
    routes.go

AQ

Testing Done:

		None yet but what is planned:

		webhook_test.go
		Test notify in webhook
		Test get json in webhook
		Test getters/setters

		util_test.go
		Test webhook/event/repo portion of TestLoadConfig in util_test.go
		Test register webhook in util
		Test delete webhook in util
		Test save webhook in util
		Test refresh config in util

~		event_test.go
	~	events_test.go
		Test get receivers
		Test send
		Test subscribe/unsubscribe

Diff:

Revision 19 (+831 -53)

	events.go
	events_test.go
	git_repository_test.go
	routes.go
	routes_test.go
	sample_config.json
	util.go
	util_test.go
	2 more

Tool: PEP8 Style Checker
Ignored Files:
    webhook_test.go
    webhook.go
    sample_config.json
    events.go
    util_test.go
    events_test.go
    routes.go
    routes_test.go
    util.go
    git_repository_test.go



Tool: Pyflakes
Ignored Files:
    webhook_test.go
    webhook.go
    sample_config.json
    events.go
    util_test.go
    events_test.go
    routes.go
    routes_test.go
    util.go
    git_repository_test.go

AQ

Diff:

Revision 20 (+1043 -68)

	events.go
	events_test.go
	git_repository.go
	git_repository_test.go
	repository.go
	routes.go
	routes_test.go
	sample_config.json
	4 more

Tool: PEP8 Style Checker
Ignored Files:
    webhook_test.go
    webhook.go
    git_repository.go
    sample_config.json
    events.go
    repository.go
    util_test.go
    events_test.go
    routes.go
    routes_test.go
    util.go
    git_repository_test.go



Tool: Pyflakes
Ignored Files:
    webhook_test.go
    webhook.go
    git_repository.go
    sample_config.json
    events.go
    repository.go
    util_test.go
    events_test.go
    routes.go
    routes_test.go
    util.go
    git_repository_test.go

Status: Discarded

Loading...