Tweak the CSS to improve readability a bit

Review Request #8110 — Created April 8, 2016 and discarded

Information

Review Board
master

Reviewers

Tweak the CSS to improve readability. Yellow is a color typically used to highlight information and draw extra attenttion to it. This change reduces the amount of yellow used in the interface so that your eyes can be drawn to the most important information on the page instead of the surrounding elements.

Review summary: http://imgur.com/a/B2RC7
Review diff: http://imgur.com/a/iQBz1

reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/css/pages/diffviewer.less
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/css/defs.less
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/css/pages/diffviewer.less
    
    
  2. 
      
david
  1. Can you explain what changes you've made and why, and include before/after screenshots?

    1. Thanks for taking a look David. I've updated the description to be a bit more detailed and include screenshots

    2. Can you attach the screenshots to the review request, instead of providing links, so that we can review them?

      The description also needs to be more clear about which yellow this is changing, and more about why. I'm not really getting the gist of why the yellow we have is bad, and the screenshots are showing an awful lot of unusal blue I wouldn't expect to see. And changing the review request background to white, and some other color changes that seem very strange to me.

    3. Oh, I think I understand. You're looking to remove the yellowish colors and put white and blue in their place? Assuming that's the case, it's not an interface change we're willing to make for the product, but I appreciate the contribution :)

  2. 
      
benmccann
benmccann
Review request changed
Status:
Discarded