Summary

Tweak the CSS to improve readability a bit

Review Request #8110 — Created April 8, 2016 and discarded May 10, 2016, 10:15 a.m.

Information

Owner

benmccann

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Tweak the CSS to improve readability. Yellow is a color typically used to highlight information and draw extra attenttion to it. This change reduces the amount of yellow used in the interface so that your eyes can be drawn to the most important information on the page instead of the surrounding elements.

Testing Done

Review summary: http://imgur.com/a/B2RC7
Review diff: http://imgur.com/a/iQBz1

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/static/rb/css/pages/diffviewer.less



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/static/rb/css/pages/diffviewer.less

Can you explain what changes you've made and why, and include before/after screenshots?

benmccann April 11, 2016, 10:35 a.m.

Thanks for taking a look David. I've updated the description to be a bit more detailed and include screenshots

chipx86 April 12, 2016, 1:41 a.m.

Can you attach the screenshots to the review request, instead of providing links, so that we can review them?

The description also needs to be more clear about which yellow this is changing, and more about why. I'm not really getting the gist of why the yellow we have is bad, and the screenshots are showing an awful lot of unusal blue I wouldn't expect to see. And changing the review request background to white, and some other color changes that seem very strange to me.

chipx86 April 12, 2016, 1:56 a.m.

Oh, I think I understand. You're looking to remove the yellowish colors and put white and blue in their place? Assuming that's the case, it's not an interface change we're willing to make for the product, but I appreciate the contribution :)

Description:: ~
Tweak the CSS to improve readability a bit
~
Tweak the CSS to improve readability. Yellow is a color typically used to highlight information and draw extra attenttion to it. This change reduces the amount of yellow used in the interface so that your eyes can be drawn to the most important information on the page instead of the surrounding elements.
Testing Done:: +
Review summary: http://imgur.com/a/B2RC7
+ Review diff: http://imgur.com/a/iQBz1

Status:: Discarded

	+	Review summary: http://imgur.com/a/B2RC7
	+	Review diff: http://imgur.com/a/iQBz1