Summary

Add schema evolution compatibility for Django 1.7, 1.8, and 1.9.

Review Request #8109 — Created April 8, 2016 and submitted May 27, 2016, 5:09 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

Commit

03a257b...

Reviewers

Groups

django-evolution

People

Description

This updates the compatibility modules in Django Evolution to support
Django 1.7 through 1.9. These make use of the new Schema Editor
functionality introduced with Django 1.7's migration feature to generate
SQL equivalent to what these versions of Django would generate, helping
us to stay compatible in the future.

Not all of the Schema Editor support is public, and not all of the logic
we need is even accessible, so we are forced to access private functions
and re-implement logic here and there, but generally, it's pretty
reasonable.

Each of the newly-supported versions of Django generate SQL differently
from older versions, and differently from each other. In some cases,
these are enough where we have to actually compare against sample SQL
datasets specific to certain versions of Django.

This change is not sufficient to actually enable evolution for a
project. It just brings API compatibility. The work to make evolutions
and migrations work together will be a whole separate project.

Testing Done

Unit tests pass against Django 1.6, 1.7, 1.8, and 1.9 for SQLite,
MySQL, and Postgres.

Issues

Description	From	Last Updated
'get_model' imported but unused	reviewbot	April 8, 2016, 11:35 p.m.
'get_models' imported but unused	reviewbot	April 8, 2016, 11:35 p.m.
redefinition of unused 'OrderedDict' from line 20	reviewbot	April 8, 2016, 11:35 p.m.
redefinition of unused 'all_models' from line 21	reviewbot	April 8, 2016, 11:35 p.m.
'logging' imported but unused	reviewbot	April 8, 2016, 11:35 p.m.
local variable 'e' is assigned to but never used	reviewbot	April 8, 2016, 11:35 p.m.
local variable 'out_sql' is assigned to but never used	reviewbot	April 8, 2016, 11:35 p.m.
'django' imported but unused	reviewbot	April 8, 2016, 11:35 p.m.
'digest' imported but unused	reviewbot	April 8, 2016, 11:35 p.m.
'supports_index_together' imported but unused	reviewbot	April 8, 2016, 11:35 p.m.
local variable 'style' is assigned to but never used	reviewbot	April 8, 2016, 11:35 p.m.
local variable 'creation' is assigned to but never used	reviewbot	April 8, 2016, 11:35 p.m.
local variable 'creation' is assigned to but never used	reviewbot	April 8, 2016, 11:35 p.m.
local variable 'style' is assigned to but never used	reviewbot	April 8, 2016, 11:36 p.m.
local variable 'creation' is assigned to but never used	reviewbot	April 8, 2016, 11:36 p.m.
local variable 'style' is assigned to but never used	reviewbot	April 8, 2016, 11:36 p.m.
'get_model' imported but unused	reviewbot	April 8, 2016, 11:36 p.m.
'Evolution' imported but unused	reviewbot	April 8, 2016, 11:36 p.m.
'transaction' imported but unused	reviewbot	April 8, 2016, 11:36 p.m.
'curry' imported but unused	reviewbot	April 8, 2016, 11:36 p.m.
'clear_app_cache' imported but unused	reviewbot	April 8, 2016, 11:36 p.m.
'apps' imported but unused	reviewbot	April 8, 2016, 11:36 p.m.
'create_constraint_name' imported but unused	reviewbot	April 8, 2016, 11:36 p.m.
'create_index_together_name' imported but unused	reviewbot	April 8, 2016, 11:36 p.m.
There should be two blank lines between these.	brennie	May 27, 2016, 5:04 p.m.
This blank line shouldn't be here.	david	May 27, 2016, 4:55 p.m.
How about from django.utils.six.moves.cPickle import loads, dumps ?	david	May 27, 2016, 4:55 p.m.
undefined name 'ImproperlyConfigured'	reviewbot	May 27, 2016, 4:57 p.m.
undefined name 'ImproperlyConfigured'	reviewbot	May 27, 2016, 4:57 p.m.
local variable 'e' is assigned to but never used	reviewbot	May 27, 2016, 4:57 p.m.

Tool: Pyflakes
Processed Files:
    django_evolution/mutations.py
    django_evolution/tests/test_delete_field.py
    django_evolution/db/common.py
    django_evolution/compat/apps.py
    django_evolution/tests/test_index_together.py
    django_evolution/compat/db.py
    django_evolution/tests/test_database_sig.py
    django_evolution/tests/db/sqlite3.py
    django_evolution/tests/utils.py
    django_evolution/tests/test_add_field.py
    django_evolution/tests/db/postgresql.py
    django_evolution/db/mysql.py
    tests/runtests.py
    django_evolution/tests/test_preprocessing.py
    django_evolution/db/postgresql.py
    django_evolution/tests/db/mysql.py
    django_evolution/management/__init__.py
    django_evolution/compat/models.py



Tool: PEP8 Style Checker
Processed Files:
    django_evolution/mutations.py
    django_evolution/tests/test_delete_field.py
    django_evolution/db/common.py
    django_evolution/compat/apps.py
    django_evolution/tests/test_index_together.py
    django_evolution/compat/db.py
    django_evolution/tests/test_database_sig.py
    django_evolution/tests/db/sqlite3.py
    django_evolution/tests/utils.py
    django_evolution/tests/test_add_field.py
    django_evolution/tests/db/postgresql.py
    django_evolution/db/mysql.py
    tests/runtests.py
    django_evolution/tests/test_preprocessing.py
    django_evolution/db/postgresql.py
    django_evolution/tests/db/mysql.py
    django_evolution/management/__init__.py
    django_evolution/compat/models.py

django_evolution/compat/apps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'get_model' imported but unused
```
django_evolution/compat/apps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'get_models' imported but unused
```
django_evolution/compat/apps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 redefinition of unused 'OrderedDict' from line 20
```
django_evolution/compat/apps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 redefinition of unused 'all_models' from line 21
```
django_evolution/compat/db.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'logging' imported but unused
```
django_evolution/compat/db.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'e' is assigned to but never used
```
django_evolution/compat/db.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'out_sql' is assigned to but never used
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'django' imported but unused
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'digest' imported but unused
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'supports_index_together' imported but unused
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'style' is assigned to but never used
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'creation' is assigned to but never used
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'creation' is assigned to but never used
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'style' is assigned to but never used
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'creation' is assigned to but never used
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'style' is assigned to but never used
```
django_evolution/db/mysql.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'get_model' imported but unused
```
django_evolution/tests/test_database_sig.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'Evolution' imported but unused
```
django_evolution/tests/utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'transaction' imported but unused
```
django_evolution/tests/utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'curry' imported but unused
```
django_evolution/tests/utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'clear_app_cache' imported but unused
```
django_evolution/tests/utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'apps' imported but unused
```
django_evolution/tests/utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'create_constraint_name' imported but unused
```
django_evolution/tests/utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'create_index_together_name' imported but unused
```

Change Summary:

Fixed unused imports and variable declarations.

Commit:

-	5f2119812a73a85ba24b39dea7b256fa61daed8b
+	03a257ba6b5bd416530f63d903d8919c58f81134

Diff:

Revision 2 (+1583 -307)

Show changes

	django_evolution/mutations.py
	django_evolution/compat/apps.py
	django_evolution/compat/db.py
	django_evolution/compat/models.py
	django_evolution/db/common.py
	django_evolution/db/mysql.py
	django_evolution/db/postgresql.py
	django_evolution/management/__init__.py
	10 more

Tool: Pyflakes
Processed Files:
    django_evolution/mutations.py
    django_evolution/tests/test_delete_field.py
    django_evolution/db/common.py
    django_evolution/compat/apps.py
    django_evolution/tests/test_index_together.py
    django_evolution/compat/db.py
    django_evolution/tests/test_database_sig.py
    django_evolution/tests/db/sqlite3.py
    django_evolution/tests/utils.py
    django_evolution/tests/test_add_field.py
    django_evolution/tests/db/postgresql.py
    django_evolution/db/mysql.py
    tests/runtests.py
    django_evolution/tests/test_preprocessing.py
    django_evolution/db/postgresql.py
    django_evolution/tests/db/mysql.py
    django_evolution/management/__init__.py
    django_evolution/compat/models.py

Tool: PEP8 Style Checker
Processed Files:
    django_evolution/mutations.py
    django_evolution/tests/test_delete_field.py
    django_evolution/db/common.py
    django_evolution/compat/apps.py
    django_evolution/tests/test_index_together.py
    django_evolution/compat/db.py
    django_evolution/tests/test_database_sig.py
    django_evolution/tests/db/sqlite3.py
    django_evolution/tests/utils.py
    django_evolution/tests/test_add_field.py
    django_evolution/tests/db/postgresql.py
    django_evolution/db/mysql.py
    tests/runtests.py
    django_evolution/tests/test_preprocessing.py
    django_evolution/db/postgresql.py
    django_evolution/tests/db/mysql.py
    django_evolution/management/__init__.py
    django_evolution/compat/models.py

Ship it!

I don't know much about the new migration stuff so I'm going to rely heavily on your testing. I didn't see any obvious problems with the structure.

django_evolution/management/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This blank line shouldn't be here.
```

django_evolution/management/__init__.py (Diff revision 2)

The issue has been dropped. Show all issues

How about from django.utils.six.moves.cPickle import loads, dumps ?

chipx86 May 26, 2016, 2:32 a.m.

We haven't dropped support yet for versions of Django without six.

Change Summary:


Fixed get_app and get_apps with apps that don't have models modules.
Fixed get_models with non-existent modules.
Removed a blank line in imports.

Diff:

Revision 3 (+1601 -307)

Show changes

	django_evolution/mutations.py
	django_evolution/compat/apps.py
	django_evolution/compat/db.py
	django_evolution/compat/models.py
	django_evolution/db/common.py
	django_evolution/db/mysql.py
	django_evolution/db/postgresql.py
	django_evolution/management/__init__.py
	10 more

Tool: Pyflakes
Processed Files:
    django_evolution/mutations.py
    django_evolution/tests/test_delete_field.py
    django_evolution/db/common.py
    django_evolution/compat/apps.py
    django_evolution/tests/test_index_together.py
    django_evolution/compat/db.py
    django_evolution/tests/test_database_sig.py
    django_evolution/tests/db/sqlite3.py
    django_evolution/tests/utils.py
    django_evolution/tests/test_add_field.py
    django_evolution/tests/db/postgresql.py
    django_evolution/db/mysql.py
    tests/runtests.py
    django_evolution/tests/test_preprocessing.py
    django_evolution/db/postgresql.py
    django_evolution/tests/db/mysql.py
    django_evolution/management/__init__.py
    django_evolution/compat/models.py



Tool: PEP8 Style Checker
Processed Files:
    django_evolution/mutations.py
    django_evolution/tests/test_delete_field.py
    django_evolution/db/common.py
    django_evolution/compat/apps.py
    django_evolution/tests/test_index_together.py
    django_evolution/compat/db.py
    django_evolution/tests/test_database_sig.py
    django_evolution/tests/db/sqlite3.py
    django_evolution/tests/utils.py
    django_evolution/tests/test_add_field.py
    django_evolution/tests/db/postgresql.py
    django_evolution/db/mysql.py
    tests/runtests.py
    django_evolution/tests/test_preprocessing.py
    django_evolution/db/postgresql.py
    django_evolution/tests/db/mysql.py
    django_evolution/management/__init__.py
    django_evolution/compat/models.py

django_evolution/compat/apps.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 undefined name 'ImproperlyConfigured'
```
django_evolution/compat/apps.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 undefined name 'ImproperlyConfigured'
```
django_evolution/compat/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 local variable 'e' is assigned to but never used
```

Change Summary:


Fixed an unused variable in an exception handler.
Added missing imports.

Diff:

Revision 4 (+1602 -307)

Show changes

	django_evolution/mutations.py
	django_evolution/compat/apps.py
	django_evolution/compat/db.py
	django_evolution/compat/models.py
	django_evolution/db/common.py
	django_evolution/db/mysql.py
	django_evolution/db/postgresql.py
	django_evolution/management/__init__.py
	10 more

Tool: Pyflakes
Processed Files:
    django_evolution/mutations.py
    django_evolution/tests/test_delete_field.py
    django_evolution/db/common.py
    django_evolution/compat/apps.py
    django_evolution/tests/test_index_together.py
    django_evolution/compat/db.py
    django_evolution/tests/test_database_sig.py
    django_evolution/tests/db/sqlite3.py
    django_evolution/tests/utils.py
    django_evolution/tests/test_add_field.py
    django_evolution/tests/db/postgresql.py
    django_evolution/db/mysql.py
    tests/runtests.py
    django_evolution/tests/test_preprocessing.py
    django_evolution/db/postgresql.py
    django_evolution/tests/db/mysql.py
    django_evolution/management/__init__.py
    django_evolution/compat/models.py



Tool: PEP8 Style Checker
Processed Files:
    django_evolution/mutations.py
    django_evolution/tests/test_delete_field.py
    django_evolution/db/common.py
    django_evolution/compat/apps.py
    django_evolution/tests/test_index_together.py
    django_evolution/compat/db.py
    django_evolution/tests/test_database_sig.py
    django_evolution/tests/db/sqlite3.py
    django_evolution/tests/utils.py
    django_evolution/tests/test_add_field.py
    django_evolution/tests/db/postgresql.py
    django_evolution/db/mysql.py
    tests/runtests.py
    django_evolution/tests/test_preprocessing.py
    django_evolution/db/postgresql.py
    django_evolution/tests/db/mysql.py
    django_evolution/management/__init__.py
    django_evolution/compat/models.py

Ship it!

django_evolution/management/__init__.py (Diff revisions 2 - 4)
The issue has been dropped. Show all issues
```
There should be two blank lines between these.
```
1. brennie May 27, 2016, 5:04 p.m.
  Nevermind, I can read.

Status: Closed (submitted)

Change Summary:

Pushed to master (d9c48e4)