Summary

Ensure review request e-mails are from the correct user

Review Request #8100 — Created April 4, 2016 and submitted April 25, 2016, 11:16 a.m.

Information

Owner

brennie

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We now ensure that the user who updated the review request is the one
who e-mails will be from. This is important when the owner of a review
request is changed. Previously, the e-mail would be from the new owner.
This issue has been corrected.

We also determine the correct user to supply when publishing if one is
not supplied by looking at the change description history.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
This should just go at the top of the file.	david	April 5, 2016, 5:09 p.m.
Can we rename the parameter from_user?	david	April 5, 2016, 5:13 p.m.
undefined name 'user'	reviewbot	April 5, 2016, 5:21 p.m.
local variable 'user' is assigned to but never used	reviewbot	April 5, 2016, 5:21 p.m.
There's an extra blank line here.	david	April 25, 2016, 11:15 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py
    reviewboard/extensions/tests.py
    reviewboard/reviews/models/review_request_draft.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py
    reviewboard/extensions/tests.py
    reviewboard/reviews/models/review_request_draft.py

Branch:: master
feature/review-request-ownership

reviewboard/notifications/email.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should just go at the top of the file.
```
reviewboard/notifications/email.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we rename the parameter from_user?
```

Branch:

feature/review-request-ownership

master

Diff:

Revision 2 (+82 -15)

Show changes

	reviewboard/extensions/tests.py
	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py
	reviewboard/reviews/models/review_request_draft.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py
    reviewboard/extensions/tests.py
    reviewboard/reviews/models/review_request_draft.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py
    reviewboard/extensions/tests.py
    reviewboard/reviews/models/review_request_draft.py

reviewboard/notifications/email.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'user'
```
reviewboard/notifications/email.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 local variable 'user' is assigned to but never used
```

Diff:

Revision 3 (+82 -15)

Show changes

	reviewboard/extensions/tests.py
	reviewboard/notifications/email.py
	reviewboard/notifications/tests.py
	reviewboard/reviews/models/review_request_draft.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py
    reviewboard/extensions/tests.py
    reviewboard/reviews/models/review_request_draft.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/notifications/tests.py
    reviewboard/extensions/tests.py
    reviewboard/reviews/models/review_request_draft.py

Ship it!

reviewboard/notifications/email.py (Diff revision 3)
The issue has been resolved. Show all issues
```
There's an extra blank line here.
```

Status:: Completed
Change Summary:: Pushed to feature/review-request-ownership (98f17e5)