Summary

Add new unit tests for RBTools's Git support

Review Request #8099 — Created April 4, 2016 and submitted July 20, 2016, 1:38 p.m.

Information

Owner

ssengar

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Add new unit tests for RBTools's Git support (this review request covers most of the tests in the project description at https://student-sonar.herokuapp.com/projects)

Testing Done

Wrote the following test cases for the following methods of the the GitClient class -
Method name - push_upstream() -

1) Tested push_upstream() with an invalid target branch. The 'git_pull' must raise a PushError exception.

2) Tested push_upstream() with the push_url set to be an invalid one. Neither the 'pull' or the 'push' must raise an exception because it gets it's origin_url from the Git config which still has a valid fetch_url
Method name - merge()

1) Tested merge() with invalid target and destination branches. Both of these must raise a MergeError exception

2) Tested merge() with squash set to True and False. Used a KGB spy to check if execute was called with the right arguments.
Method name - create_commit()

1) Tested create_commit() with run_editor set to True and False. Used a KGB spy to check if edit_text was called or not.

2) Tested create_commit() with all_files set to True and False. Used a KGB spy to check if execute was called with the right arguments.
Method name - delete_branch()

1) Tested delete_branch() with merged_only set to True and False. Used a KGB spy to check if execute was called with the right arguments.

Issues

Description	From	Last Updated
Col: 59 W291 trailing whitespace	reviewbot	April 10, 2016, 2:51 p.m.
Col: 45 W291 trailing whitespace	reviewbot	April 10, 2016, 2:51 p.m.
Col: 60 W291 trailing whitespace	reviewbot	April 10, 2016, 2:51 p.m.
local variable 'e' is assigned to but never used	reviewbot	April 10, 2016, 2:51 p.m.
Col: 45 W291 trailing whitespace	reviewbot	April 10, 2016, 2:51 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	April 10, 2016, 2:52 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	April 10, 2016, 2:52 p.m.
Col: 63 W291 trailing whitespace	reviewbot	April 10, 2016, 2:52 p.m.
Col: 63 W291 trailing whitespace	reviewbot	April 10, 2016, 2:52 p.m.
Col: 45 W291 trailing whitespace	reviewbot	April 10, 2016, 2:52 p.m.
Col: 58 W291 trailing whitespace	reviewbot	April 10, 2016, 2:52 p.m.
Col: 63 W291 trailing whitespace	reviewbot	April 10, 2016, 2:52 p.m.
Col: 77 W291 trailing whitespace	reviewbot	April 10, 2016, 2:52 p.m.
Col: 45 W291 trailing whitespace	reviewbot	April 10, 2016, 2:52 p.m.
Col: 64 W291 trailing whitespace	reviewbot	April 10, 2016, 2:52 p.m.
Col: 76 W291 trailing whitespace	reviewbot	April 10, 2016, 2:52 p.m.
Col: 32 E711 comparison to None should be 'if cond is not None:'	reviewbot	April 10, 2016, 2:52 p.m.
Col: 65 W291 trailing whitespace	reviewbot	April 10, 2016, 2:52 p.m.
Col: 75 W291 trailing whitespace	reviewbot	April 10, 2016, 2:52 p.m.
Col: 68 W291 trailing whitespace	reviewbot	April 10, 2016, 2:52 p.m.
Col: 32 E711 comparison to None should be 'if cond is not None:'	reviewbot	April 10, 2016, 2:53 p.m.
Col: 45 W291 trailing whitespace	reviewbot	April 10, 2016, 10:49 p.m.
Col: 60 E231 missing whitespace after ':'	reviewbot	April 10, 2016, 2:58 p.m.
Col: 68 W291 trailing whitespace	reviewbot	April 10, 2016, 2:58 p.m.
Col: 57 E231 missing whitespace after ':'	reviewbot	April 10, 2016, 2:58 p.m.
Col: 60 E231 missing whitespace after ':'	reviewbot	April 10, 2016, 2:58 p.m.
Col: 68 W291 trailing whitespace	reviewbot	April 10, 2016, 2:59 p.m.
Col: 57 E231 missing whitespace after ':'	reviewbot	April 10, 2016, 2:59 p.m.
Col: 60 E231 missing whitespace after ':'	reviewbot	April 10, 2016, 2:59 p.m.
Col: 68 W291 trailing whitespace	reviewbot	April 10, 2016, 2:59 p.m.
Col: 57 E231 missing whitespace after ':'	reviewbot	April 10, 2016, 2:59 p.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	April 10, 2016, 2:59 p.m.
Col: 60 E231 missing whitespace after ':'	reviewbot	April 10, 2016, 2:59 p.m.
Col: 68 W291 trailing whitespace	reviewbot	April 10, 2016, 2:59 p.m.
Col: 57 E231 missing whitespace after ':'	reviewbot	April 10, 2016, 2:59 p.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	April 10, 2016, 2:59 p.m.
You could put this after the push_upstream call on line 538 - that way, you wouldn't need the early return …	mike_conley	April 10, 2016, 10:47 p.m.
Don't forget to test the success case too.	mike_conley	April 18, 2016, 5:04 p.m.
assertTrue(False) after line 551? Same goes for other tests like this.	mike_conley	April 10, 2016, 10:47 p.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	April 10, 2016, 2:59 p.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	April 10, 2016, 2:59 p.m.
I'm guessing this is just placeholder?	mike_conley	April 10, 2016, 10:50 p.m.
Col: 50 E127 continuation line over-indented for visual indent	reviewbot	April 10, 2016, 10:49 p.m.
Col: 50 E127 continuation line over-indented for visual indent	reviewbot	April 10, 2016, 10:49 p.m.
Col: 50 E127 continuation line over-indented for visual indent	reviewbot	April 10, 2016, 10:49 p.m.
Col: 50 E127 continuation line over-indented for visual indent	reviewbot	April 10, 2016, 10:49 p.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	April 10, 2016, 10:49 p.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	April 10, 2016, 10:50 p.m.
Col: 76 W291 trailing whitespace	reviewbot	April 10, 2016, 10:47 p.m.
""" on the next line.	david	April 24, 2016, 9:33 p.m.
This could all be done at once using six.assertRaisesRegexp.	david	April 24, 2016, 9:36 p.m.
Instead of catching the exception and doing assertTrue(False), just get rid of the try/except. An uncaught exception will cause the …	david	April 24, 2016, 9:33 p.m.
""" on the next line.	david	April 24, 2016, 9:33 p.m.
This can use six.assertRaisesRegexp	david	April 24, 2016, 9:33 p.m.
""" on the next line.	david	April 24, 2016, 9:33 p.m.
Can we reformat/change this to: author = type( b'Author', (object,), { 'fullname': 'name', 'email': 'email', })	david	April 24, 2016, 9:33 p.m.
six.assertRaisesMessage	david	April 24, 2016, 9:33 p.m.
""" on the next line.	david	April 24, 2016, 9:33 p.m.
If you add SpyAgency as a parent class, you can use self.spy_on(execute). This has several advantages: you don't have to …	david	April 24, 2016, 9:33 p.m.
Same formatting here as I mentioned above.	david	April 24, 2016, 9:34 p.m.
Col: 50 E127 continuation line over-indented for visual indent	reviewbot	April 18, 2016, 5:07 p.m.
Col: 50 E127 continuation line over-indented for visual indent	reviewbot	April 18, 2016, 5:06 p.m.
""" on the next line.	david	April 24, 2016, 9:34 p.m.
Col: 50 E127 continuation line over-indented for visual indent	reviewbot	April 18, 2016, 5:07 p.m.
Col: 50 E127 continuation line over-indented for visual indent	reviewbot	April 18, 2016, 5:07 p.m.
""" on the next line.	david	April 24, 2016, 9:34 p.m.
Same formatting here as above.	david	April 24, 2016, 9:34 p.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	April 18, 2016, 5:07 p.m.
""" on the next line.	david	April 24, 2016, 9:34 p.m.
And here.	david	April 24, 2016, 9:34 p.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	April 18, 2016, 5:07 p.m.
""" on the next line.	david	April 24, 2016, 9:34 p.m.
And here. Since we're using this in lots of places, perhaps we should define this once?	david	April 24, 2016, 9:34 p.m.
""" on the next line.	david	April 24, 2016, 9:34 p.m.
""" on the next line.	david	April 24, 2016, 9:34 p.m.
""" on the next line.	david	April 24, 2016, 9:34 p.m.
Col: 50 E127 continuation line over-indented for visual indent	reviewbot	April 24, 2016, 9:48 p.m.
Col: 50 E127 continuation line over-indented for visual indent	reviewbot	April 24, 2016, 9:47 p.m.
Col: 50 E127 continuation line over-indented for visual indent	reviewbot	April 24, 2016, 9:48 p.m.
Col: 50 E127 continuation line over-indented for visual indent	reviewbot	April 24, 2016, 9:48 p.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	April 24, 2016, 9:48 p.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	April 24, 2016, 9:48 p.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	April 24, 2016, 9:48 p.m.
Col: 33 E128 continuation line under-indented for visual indent	reviewbot	April 24, 2016, 9:48 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/clients/tests.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tests.py

rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 59
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 45
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 60
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'e' is assigned to but never used
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 45
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 63
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 63
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 45
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 58
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 63
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 77
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 45
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 64
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 76
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 32
 E711 comparison to None should be 'if cond is not None:'
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 65
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 75
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 68
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 32
 E711 comparison to None should be 'if cond is not None:'
```

Change Summary:

Fixed some stylistic issues, Added tests for create_commit and delete_branch which use kgb spies.

Diff:

Revision 2 (+164)

Show changes

rbtools/clients/tests.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/tests.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tests.py

rbtools/clients/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 45
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 60
 E231 missing whitespace after ':'
```
rbtools/clients/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 68
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 57
 E231 missing whitespace after ':'
```
rbtools/clients/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 60
 E231 missing whitespace after ':'
```
rbtools/clients/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 68
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 57
 E231 missing whitespace after ':'
```
rbtools/clients/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 60
 E231 missing whitespace after ':'
```
rbtools/clients/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 68
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 57
 E231 missing whitespace after ':'
```
rbtools/clients/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 60
 E231 missing whitespace after ':'
```
rbtools/clients/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 68
 W291 trailing whitespace
```
rbtools/clients/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 57
 E231 missing whitespace after ':'
```
rbtools/clients/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```

Change Summary:

Fixed stylistic issues brought up by ReviewBot

Diff:

Revision 3 (+164)

Show changes

rbtools/clients/tests.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/tests.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tests.py

rbtools/clients/tests.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```

Change Summary:

Edited the Testing Done field

Testing Done:

~		Wrote some test cases for the merge, push_upstream and create_commit methods (some of these test cases are still incomplete because I'm still learning how to use kgb spies).
	~	Wrote some test cases for the merge, push_upstream, delete_branch and create_commit methods.

Hey - I think these are on the right track. Great job!

Don't forget to test the success cases too.

rbtools/clients/tests.py (Diff revision 3)

The issue has been resolved. Show all issues

You could put this after the push_upstream call on line 538 - that way, you wouldn't need the early return in 541.

rbtools/clients/tests.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Don't forget to test the success case too.
```
rbtools/clients/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
assertTrue(False) after line 551? Same goes for other tests like this.
```

rbtools/clients/tests.py (Diff revision 3)

The issue has been resolved. Show all issues

I'm guessing this is just placeholder?

ssengar April 10, 2016, 4:28 p.m.

Umm no it's not really a placeholder. For my create_commit() tests, I needed to call a fake method instead of edit_text() when it was called. So this is that fake method which is called instead of edit_text() (which is needed because edit_text opens up a Vim window and waits for user input). Hence, you'll see the corresponding line agency.spy_on(edit_text, call_fake=self.return_new_message) in my code. Is there a better way of doing this without having to define a new method (maybe using Lambda functions)?

Change Summary:

Added merge tests (squash - true/false) and create_commit tests (all_files - true/false). Also fixed issues opened by Mike

Diff:

Revision 4 (+278)

Show changes

rbtools/clients/tests.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/tests.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tests.py

rbtools/clients/tests.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 50
 E127 continuation line over-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 50
 E127 continuation line over-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 50
 E127 continuation line over-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 50
 E127 continuation line over-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 76
 W291 trailing whitespace
```

Change Summary:

Add a new test case for push_upstream, removed an old one, and finalized these set of tests to be non-WIP

Summary:

-	[WIP] Add new unit tests for RBTools's Git support
+	Add new unit tests for RBTools's Git support

Description:

~		[WIP] Add new unit tests for RBTools's Git support
	~	Add new unit tests for RBTools's Git support (this review request covers most of the tests in the project description at https://student-sonar.herokuapp.com/projects)

Testing Done:

~		Wrote some test cases for the merge, push_upstream, delete_branch and create_commit methods.
	~	Wrote the following test cases for the following methods of the the GitClient class -
	+
	+	Method name - push_upstream() -
	+	1) Tested push_upstream() with an invalid target branch. The 'git_pull' must raise a PushError exception.
	+	2) Tested push_upstream() with the push_url set to be an invalid one. Neither the 'pull' or the 'push' must raise an exception because it gets it's origin_url from the Git config which still has a valid fetch_url
	+
	+	Method name - merge()
	+	1) Tested merge() with invalid target and destination branches. Both of these must raise a MergeError exception
	+	2) Tested merge() with squash set to True and False. Used a KGB spy to check if execute was called with the right arguments.
	+
	+	Method name - create_commit()
	+	1) Tested create_commit() with run_editor set to True and False. Used a KGB spy to check if edit_text was called or not.
	+	2) Tested create_commit() with all_files set to True and False. Used a KGB spy to check if execute was called with the right arguments.
	+
	+	Method name - delete_branch()
	+	1) Tested delete_branch() with merged_only set to True and False. Used a KGB spy to check if execute was called with the right arguments.

Diff:

Revision 5 (+281)

Show changes

rbtools/clients/tests.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/tests.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tests.py

rbtools/clients/tests.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 50
 E127 continuation line over-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 50
 E127 continuation line over-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 50
 E127 continuation line over-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 50
 E127 continuation line over-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```

rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
""" on the next line.
```

rbtools/clients/tests.py (Diff revision 5)

The issue has been resolved. Show all issues

This could all be done at once using six.assertRaisesRegexp.

rbtools/clients/tests.py (Diff revision 5)

The issue has been resolved. Show all issues

Instead of catching the exception and doing assertTrue(False), just get rid of the try/except. An uncaught exception will cause the test case to fail.

rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
""" on the next line.
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
This can use six.assertRaisesRegexp
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
""" on the next line.
```

rbtools/clients/tests.py (Diff revision 5)

The issue has been resolved. Show all issues

Can we reformat/change this to:

author = type(
    b'Author',
    (object,),
    {
        'fullname': 'name',
        'email': 'email',
    })

rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
six.assertRaisesMessage
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
""" on the next line.
```

rbtools/clients/tests.py (Diff revision 5)

The issue has been resolved. Show all issues

If you add SpyAgency as a parent class, you can use self.spy_on(execute). This has several advantages: you don't have to create a new SpyAgency for each test, and it will automatically unspy after each test case (which is both less code and more robust if there are unexpected exceptions).

rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Same formatting here as I mentioned above.
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
""" on the next line.
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
""" on the next line.
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Same formatting here as above.
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
""" on the next line.
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
And here.
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
""" on the next line.
```

rbtools/clients/tests.py (Diff revision 5)

The issue has been resolved. Show all issues

And here. Since we're using this in lots of places, perhaps we should define this once?

rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
""" on the next line.
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
""" on the next line.
```
rbtools/clients/tests.py (Diff revision 5)
The issue has been resolved. Show all issues
```
""" on the next line.
```

Change Summary:

Fixed all issues outlined in David's review

Diff:

Revision 6 (+238 -1)

Show changes

rbtools/clients/tests.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/tests.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tests.py

rbtools/clients/tests.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 50
 E127 continuation line over-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 50
 E127 continuation line over-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 50
 E127 continuation line over-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 50
 E127 continuation line over-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```

Change Summary:

Fixed some stylistic issues

Diff:

Revision 7 (+238 -1)

Show changes

rbtools/clients/tests.py

Tool: Pyflakes
Processed Files:
    rbtools/clients/tests.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/tests.py

rbtools/clients/tests.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```
rbtools/clients/tests.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 33
 E128 continuation line under-indented for visual indent
```

Ship it!

Going to make some small changes and push this.

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (d8a346f)