Added post-commit hook scripts to automatically set a review request as submitted. (hg and svn)
Review Request #8097 — Created April 3, 2016 and discarded
Added `incoming` for hg repositories to automatically set a review request as submitted.
Description | From | Last Updated |
---|---|---|
'get_review_request_id' imported but unused |
reviewbot | |
Col: 39 W292 no newline at end of file |
reviewbot | |
Needs to import unicode_literals from __future__. |
brennie | |
Please format this as: from rbtools.hooks.common import (close_review_request, initialize_logging, get_review_request_id) |
brennie | |
Missing docstring |
brennie | |
%-formatting is more efficient than string concatentation. Also, please format as: print('No matching review request ID found for changeset %s' … |
brennie | |
This needs to import unicode_literals from __future__ |
brennie | |
Needs args and returns. |
brennie | |
Col: 5 E101 indentation contains mixed spaces and tabs |
reviewbot | |
Col: 5 W191 indentation contains tabs |
reviewbot | |
Col: 5 E101 indentation contains mixed spaces and tabs |
reviewbot | |
Col: 5 W191 indentation contains tabs |
reviewbot | |
Col: 5 E101 indentation contains mixed spaces and tabs |
reviewbot | |
Col: 5 W191 indentation contains tabs |
reviewbot | |
Col: 5 E101 indentation contains mixed spaces and tabs |
reviewbot | |
Col: 5 W191 indentation contains tabs |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 1 W391 blank line at end of file |
reviewbot | |
Docstrings should be of the format: """Single line summary. Optional multi-line description. """ |
brennie | |
Docstrings should be of the format: """Single line summary. Optional multi-line description. """ |
brennie |
Change Summary:
Added new line at EOF, removed unused import, and changed comment.
Diff: |
Revision 2 (+64) |
---|
-
Tool: PEP8 Style Checker Processed Files: rbtools/hooks/mercurial.py Ignored Files: contrib/tools/hg-hook-set-submitted Tool: Pyflakes Processed Files: rbtools/hooks/mercurial.py Ignored Files: contrib/tools/hg-hook-set-submitted
-
-
contrib/tools/hg-hook-set-submitted (Diff revision 2) Needs to import
unicode_literals
from__future__
. -
contrib/tools/hg-hook-set-submitted (Diff revision 2) Please format this as:
from rbtools.hooks.common import (close_review_request, initialize_logging, get_review_request_id)
-
-
contrib/tools/hg-hook-set-submitted (Diff revision 2) %-formatting is more efficient than string concatentation.
Also, please format as:
print('No matching review request ID found for changeset %s' % changeset_id)
-
-
Change Summary:
Modified docstrings, imported unicode_literals, and changed string concatenation to %-formatting.
Diff: |
Revision 3 (+79) |
---|
-
Tool: Pyflakes Processed Files: rbtools/hooks/mercurial.py Ignored Files: contrib/tools/hg-hook-set-submitted Tool: PEP8 Style Checker Processed Files: rbtools/hooks/mercurial.py Ignored Files: contrib/tools/hg-hook-set-submitted
-
-
-
-
-
-
-
-
-
Tool: PEP8 Style Checker Processed Files: rbtools/hooks/mercurial.py Ignored Files: contrib/tools/hg-hook-set-submitted Tool: Pyflakes Processed Files: rbtools/hooks/mercurial.py Ignored Files: contrib/tools/hg-hook-set-submitted
Change Summary:
Added post-commit hook for Subversion
Summary: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+178) |
-
Tool: PEP8 Style Checker Processed Files: rbtools/hooks/svn.py rbtools/hooks/mercurial.py Ignored Files: contrib/tools/hg-hook-set-submitted contrib/tools/svn-hook-set-submitted Tool: Pyflakes Processed Files: rbtools/hooks/svn.py rbtools/hooks/mercurial.py Ignored Files: contrib/tools/hg-hook-set-submitted contrib/tools/svn-hook-set-submitted
-
-
-
Tool: Pyflakes Processed Files: rbtools/hooks/svn.py rbtools/hooks/mercurial.py Ignored Files: contrib/tools/hg-hook-set-submitted contrib/tools/svn-hook-set-submitted Tool: PEP8 Style Checker Processed Files: rbtools/hooks/svn.py rbtools/hooks/mercurial.py Ignored Files: contrib/tools/hg-hook-set-submitted contrib/tools/svn-hook-set-submitted
-
-
rbtools/hooks/svn.py (Diff revision 6) I'm wondering how others feel about this solution, I wasn't able to find a command that could extract just the commit message, and
svn log
includes a bunch of information I didn't want to try to parse through. So I found out there's a way to extract the log as a string of xml, and then I made a regex expression to help extract the commit message from that string.
-
You'll want to update your description to indicate this is for both hg and svn. Also, could you include how you tested this?
-
contrib/tools/hg-hook-set-submitted (Diff revision 6) Docstrings should be of the format:
"""Single line summary. Optional multi-line description. """
-
contrib/tools/svn-hook-set-submitted (Diff revision 6) Docstrings should be of the format:
"""Single line summary. Optional multi-line description. """