This change has been discarded.

Describe the reason it's discarded (optional):

Summary

Added post-commit hook scripts to automatically set a review request as submitted. (hg and svn)

Review Request #8097 — Created April 3, 2016 and discarded 4 years, 2 months ago

Information

Owner

evanhunzinger*

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description*

Added `incoming` for hg repositories to automatically set a review request as submitted.

Testing Done

Issues

Description	From	Last Updated
'get_review_request_id' imported but unused	reviewbot	9 years ago
Col: 39 W292 no newline at end of file	reviewbot	9 years ago
Needs to import unicode_literals from __future__.	brennie	9 years ago
Please format this as: from rbtools.hooks.common import (close_review_request, initialize_logging, get_review_request_id)	brennie	9 years ago
Missing docstring	brennie	9 years ago
%-formatting is more efficient than string concatentation. Also, please format as: print('No matching review request ID found for changeset %s' …	brennie	9 years ago
This needs to import unicode_literals from __future__	brennie	9 years ago
Needs args and returns.	brennie	9 years ago
Col: 5 E101 indentation contains mixed spaces and tabs	reviewbot	9 years ago
Col: 5 W191 indentation contains tabs	reviewbot	9 years ago
Col: 5 E101 indentation contains mixed spaces and tabs	reviewbot	9 years ago
Col: 5 W191 indentation contains tabs	reviewbot	9 years ago
Col: 5 E101 indentation contains mixed spaces and tabs	reviewbot	9 years ago
Col: 5 W191 indentation contains tabs	reviewbot	9 years ago
Col: 5 E101 indentation contains mixed spaces and tabs	reviewbot	9 years ago
Col: 5 W191 indentation contains tabs	reviewbot	9 years ago
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	9 years ago
Col: 1 W391 blank line at end of file	reviewbot	9 years ago
Docstrings should be of the format: """Single line summary. Optional multi-line description. """	brennie	9 years ago
Docstrings should be of the format: """Single line summary. Optional multi-line description. """	brennie	9 years ago

Tool: PEP8 Style Checker
Processed Files:
    rbtools/hooks/mercurial.py

Ignored Files:
    contrib/tools/hg-hook-set-submitted



Tool: Pyflakes
Processed Files:
    rbtools/hooks/mercurial.py

Ignored Files:
    contrib/tools/hg-hook-set-submitted

rbtools/hooks/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'get_review_request_id' imported but unused
```
rbtools/hooks/mercurial.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 39
 W292 no newline at end of file
```

Change Summary:

Added new line at EOF, removed unused import, and changed comment.

Diff:

Revision 2 (+64)

Show changes

	contrib/tools/hg-hook-set-submitted
	rbtools/hooks/mercurial.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/hooks/mercurial.py

Ignored Files:
    contrib/tools/hg-hook-set-submitted



Tool: Pyflakes
Processed Files:
    rbtools/hooks/mercurial.py

Ignored Files:
    contrib/tools/hg-hook-set-submitted

contrib/tools/hg-hook-set-submitted (Diff revision 2)
The issue has been resolved. Show all issues
```
Needs to import unicode_literals from __future__.
```

contrib/tools/hg-hook-set-submitted (Diff revision 2)

The issue has been resolved. Show all issues

Please format this as:

from rbtools.hooks.common import (close_review_request, initialize_logging,
                                  get_review_request_id)

contrib/tools/hg-hook-set-submitted (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing docstring
```

contrib/tools/hg-hook-set-submitted (Diff revision 2)

The issue has been resolved. Show all issues

%-formatting is more efficient than string concatentation.

Also, please format as:

print('No matching review request ID found for changeset %s'
      % changeset_id)

rbtools/hooks/mercurial.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This needs to import unicode_literals from __future__
```
rbtools/hooks/mercurial.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Needs args and returns.
```

Change Summary:

Modified docstrings, imported unicode_literals, and changed string concatenation to %-formatting.

Diff:

Revision 3 (+79)

Show changes

	contrib/tools/hg-hook-set-submitted
	rbtools/hooks/mercurial.py

Tool: Pyflakes
Processed Files:
    rbtools/hooks/mercurial.py

Ignored Files:
    contrib/tools/hg-hook-set-submitted



Tool: PEP8 Style Checker
Processed Files:
    rbtools/hooks/mercurial.py

Ignored Files:
    contrib/tools/hg-hook-set-submitted

rbtools/hooks/mercurial.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 5
 E101 indentation contains mixed spaces and tabs
```
rbtools/hooks/mercurial.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 5
 W191 indentation contains tabs
```
rbtools/hooks/mercurial.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 5
 E101 indentation contains mixed spaces and tabs
```
rbtools/hooks/mercurial.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 5
 W191 indentation contains tabs
```
rbtools/hooks/mercurial.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 5
 E101 indentation contains mixed spaces and tabs
```
rbtools/hooks/mercurial.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 5
 W191 indentation contains tabs
```
rbtools/hooks/mercurial.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 5
 E101 indentation contains mixed spaces and tabs
```
rbtools/hooks/mercurial.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 5
 W191 indentation contains tabs
```

Change Summary:

Changed tabs to spaces.

Diff:

Revision 4 (+79)

Show changes

	contrib/tools/hg-hook-set-submitted
	rbtools/hooks/mercurial.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/hooks/mercurial.py

Ignored Files:
    contrib/tools/hg-hook-set-submitted



Tool: Pyflakes
Processed Files:
    rbtools/hooks/mercurial.py

Ignored Files:
    contrib/tools/hg-hook-set-submitted

Change Summary:

Added post-commit hook for Subversion

Summary:

Added `incoming` for hg repositories to automatically set a review request as submitted.

Added post-commit hook scripts to automatically set a review request as submitted. (hg and svn)

Diff:

Revision 5 (+178)

Show changes

	contrib/tools/hg-hook-set-submitted
	contrib/tools/svn-hook-set-submitted
	rbtools/hooks/mercurial.py
	rbtools/hooks/svn.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/hooks/svn.py
    rbtools/hooks/mercurial.py

Ignored Files:
    contrib/tools/hg-hook-set-submitted
    contrib/tools/svn-hook-set-submitted



Tool: Pyflakes
Processed Files:
    rbtools/hooks/svn.py
    rbtools/hooks/mercurial.py

Ignored Files:
    contrib/tools/hg-hook-set-submitted
    contrib/tools/svn-hook-set-submitted

rbtools/hooks/svn.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
rbtools/hooks/svn.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```

Change Summary:

Cleaned up formatting.

Diff:

Revision 6 (+178)

Show changes

	contrib/tools/hg-hook-set-submitted
	contrib/tools/svn-hook-set-submitted
	rbtools/hooks/mercurial.py
	rbtools/hooks/svn.py

Tool: Pyflakes
Processed Files:
    rbtools/hooks/svn.py
    rbtools/hooks/mercurial.py

Ignored Files:
    contrib/tools/hg-hook-set-submitted
    contrib/tools/svn-hook-set-submitted



Tool: PEP8 Style Checker
Processed Files:
    rbtools/hooks/svn.py
    rbtools/hooks/mercurial.py

Ignored Files:
    contrib/tools/hg-hook-set-submitted
    contrib/tools/svn-hook-set-submitted

rbtools/hooks/svn.py (Diff revision 6)

I'm wondering how others feel about this solution, I wasn't able to find a command that could extract just the commit message, and svn log includes a bunch of information I didn't want to try to parse through. So I found out there's a way to extract the log as a string of xml, and then I made a regex expression to help extract the commit message from that string.

brennie 9 years ago

The best way to do this would be to use xml.etree.ElementTree to parse the result of svn log --xml for the commit and parse the message out of that. It will be much more robust. The svn client has some examples of using ElementTree, but the Python docs have even more.

Fix it!

You'll want to update your description to indicate this is for both hg and svn. Also, could you include how you tested this?

contrib/tools/hg-hook-set-submitted (Diff revision 6)

An issue was opened. Show all issues

Docstrings should be of the format:

"""Single line summary.

Optional multi-line description.
"""

contrib/tools/svn-hook-set-submitted (Diff revision 6)

An issue was opened. Show all issues

Docstrings should be of the format:

"""Single line summary.

Optional multi-line description.
"""

How to User this?

chipx86 7 years, 2 months ago

This isn't a discussion forum, and not a good place to ask for help, as it complicates our development. Please use https://groups.google.com/group/reviewboard/ instead.

Status:: Discarded