Improve description guessing when --summary is used.

Review Request #8092 — Created March 31, 2016 and submitted

Information

RBTools
release-0.7.x
48627dc...

Reviewers

If the summary is passed on the command line but the description is guessed
from the commit message, the first line of the commit message would be lost.
This change improves that by concatenating the summary and description back
together if the summary line isn't being used for the review request.

Based on work by Alexander Goncahrov at https://reviews.reviewboard.org/r/7806/

Ran unit tests.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
chipx86
  1. So just to check (can we add this to the description for when we do release notes?), If I run:

    rbt post --summary="My Summary" --guess-description=yes --guess-summary=no
    

    And the commit message is:

    A different summary.
    
    This is the description.
    

    The review request summary will be "My Summary" and the description will be the full commit message?

  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.7.x (65b06f3)
Loading...