Clean up the API extra data access hooks

Review Request #8084 — Created March 30, 2016 and submitted

brennie
Review Board
release-3.0.x
7674
reviewboard

The APIExtraDataAccessHook has been rewritten to utilize registries
for registration and unregistration of callbacks. Tests have been
updated for these changes.

The documetnation has also been updated and reformatted for clarity.

Ran unit tests.

Description From Last Updated

The apostrophe in "field_set's" is incorrect.

daviddavid

Same here.

daviddavid

Col: 80 E501 line too long (86 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (98 > 79 characters)

reviewbotreviewbot

Description should be on the next line.

daviddavid

Can we say "GET" and "PUT" here and below?

daviddavid

Put this line back.

daviddavid

"extra_data key"

daviddavid

"extra_data key"

daviddavid

"extra_data key"

daviddavid

Can you indent this line one more level?

daviddavid

Description should be on the next line.

daviddavid

Can you indent this line one more level?

daviddavid

When it's just a single import, we do tend to use the continuation character rather than parens.

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/base.py
        reviewboard/webapi/tests/mixins_extra_data.py
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    Ignored Files:
        docs/manual/extending/extensions/hooks/index.rst
        docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/base.py
        reviewboard/webapi/tests/mixins_extra_data.py
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    Ignored Files:
        docs/manual/extending/extensions/hooks/index.rst
        docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst
    
    
  2. reviewboard/extensions/hooks.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (86 > 79 characters)
    
  3. reviewboard/extensions/hooks.py (Diff revision 1)
     
     
    Col: 80
     E501 line too long (98 > 79 characters)
    
  4. 
      
david
  1. 
      
  2. reviewboard/extensions/hooks.py (Diff revision 1)
     
     

    The apostrophe in "field_set's" is incorrect.

  3. reviewboard/extensions/hooks.py (Diff revision 1)
     
     

    Same here.

  4. reviewboard/extensions/hooks.py (Diff revision 1)
     
     

    Description should be on the next line.

  5. reviewboard/extensions/tests.py (Diff revision 1)
     
     

    Can we say "GET" and "PUT" here and below?

  6. reviewboard/webapi/base.py (Diff revision 1)
     
     

    Put this line back.

  7. reviewboard/webapi/base.py (Diff revision 1)
     
     

    "extra_data key"

  8. reviewboard/webapi/base.py (Diff revision 1)
     
     

    "extra_data key"

  9. reviewboard/webapi/base.py (Diff revision 1)
     
     

    "extra_data key"

  10. reviewboard/webapi/base.py (Diff revision 1)
     
     

    Can you indent this line one more level?

  11. reviewboard/webapi/base.py (Diff revision 1)
     
     

    Description should be on the next line.

  12. reviewboard/webapi/base.py (Diff revision 1)
     
     

    Can you indent this line one more level?

    1. This violates PEP8.

  13. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/base.py
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    Ignored Files:
        docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/base.py
        reviewboard/extensions/hooks.py
        reviewboard/extensions/tests.py
    
    Ignored Files:
        docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst
    
    
  2. 
      
david
  1. 
      
  2. When it's just a single import, we do tend to use the continuation character rather than parens.

  3. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to feature/private-extra-data (f3af594)
Loading...