Clean up the API extra data access hooks
Review Request #8084 — Created March 30, 2016 and submitted
The
APIExtraDataAccessHookhas been rewritten to utilize registries
for registration and unregistration of callbacks. Tests have been
updated for these changes.The documetnation has also been updated and reformatted for clarity.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
The apostrophe in "field_set's" is incorrect. |
david
|
|
|
Same here. |
david
|
|
|
Col: 80 E501 line too long (86 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (98 > 79 characters) |
reviewbot
|
|
|
Description should be on the next line. |
david
|
|
|
Can we say "GET" and "PUT" here and below? |
david
|
|
|
Put this line back. |
david
|
|
|
"extra_data key" |
david
|
|
|
"extra_data key" |
david
|
|
|
"extra_data key" |
david
|
|
|
Can you indent this line one more level? |
david
|
|
|
Description should be on the next line. |
david
|
|
|
Can you indent this line one more level? |
david
|
|
|
When it's just a single import, we do tend to use the continuation character rather than parens. |
david
|
-
Tool: Pyflakes Processed Files: reviewboard/webapi/base.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/base.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst
Tool: Pyflakes Processed Files: reviewboard/webapi/base.py reviewboard/webapi/tests/mixins_extra_data.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: docs/manual/extending/extensions/hooks/index.rst docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/base.py reviewboard/webapi/tests/mixins_extra_data.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: docs/manual/extending/extensions/hooks/index.rst docs/manual/extending/extensions/hooks/api-extra-data-access-hook.rst