• 
      

    Fix a couple bugs when updating Review Requests for Perforce.

    Review Request #8076 — Created March 26, 2016 and submitted — Latest diff uploaded

    Information

    RBTools
    release-0.7.x
    8f99388...

    Reviewers

    There were a couple bugs that were causing problems with Perforce and updating
    review requests for changelists. When -u was passed, there was a unicode
    mismatch bug that was causing the difflib comparison to always fail, resulting
    in no matches.

    The second problem was when -u was not passed, there was a bad "update" call
    being made (which doesn't actually need to be made). This caused an
    AttributeError which had no detail to it, resulting in one of our fantastic
    "CRITICAL:" error messages.

    Posted a review request with Perforce. Made some changes to the code and
    changeset description, and then updated it using both -u (where I was prompted
    to choose which review request) and without.