Fix a couple bugs when updating Review Requests for Perforce.
Review Request #8076 — Created March 26, 2016 and submitted
There were a couple bugs that were causing problems with Perforce and updating
review requests for changelists. When -u was passed, there was a unicode
mismatch bug that was causing the difflib comparison to always fail, resulting
in no matches.The second problem was when -u was not passed, there was a bad "update" call
being made (which doesn't actually need to be made). This caused an
AttributeError which had no detail to it, resulting in one of our fantastic
"CRITICAL:" error messages.
Posted a review request with Perforce. Made some changes to the code and
changeset description, and then updated it using both -u (where I was prompted
to choose which review request) and without.
| Description | From | Last Updated |
|---|---|---|
|
local variable 'whitespace' (defined in enclosing scope on line 13) referenced before assignment |
reviewbot
|
Tool: Pyflakes Processed Files: rbtools/commands/post.py rbtools/clients/perforce.py Tool: PEP8 Style Checker Processed Files: rbtools/commands/post.py rbtools/clients/perforce.py