Fix/Workaround for ticket 4369 (Unicode error with six.text_type)

Review Request #8071 — Created March 22, 2016 and submitted

Information

Review Board

Reviewers

Do not cast 'password' with six.text_type as it fails on non ASCII characters. This will be a common problem for sites that use LDAP authentication where the password is an automatically generated default. In addition this default password is not really used in many cases anyway.

https://hellosplat.com/s/beanbag/tickets/4369/

Manual validation on our instance of reviewboard.

Description From Last Updated

Col: 1 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 1 W191 indentation contains tabs

reviewbotreviewbot

Col: 2 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

Col: 1 E101 indentation contains mixed spaces and tabs

reviewbotreviewbot

This comment isn't necessary.

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/svn/pysvn.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/svn/pysvn.py
    
    
  2. reviewboard/scmtools/svn/pysvn.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E101 indentation contains mixed spaces and tabs
    
  3. reviewboard/scmtools/svn/pysvn.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     W191 indentation contains tabs
    
  4. reviewboard/scmtools/svn/pysvn.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     W191 indentation contains tabs
    
  5. reviewboard/scmtools/svn/pysvn.py (Diff revision 1)
     
     
    Show all issues
    Col: 2
     E101 indentation contains mixed spaces and tabs
    
  6. reviewboard/scmtools/svn/pysvn.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E101 indentation contains mixed spaces and tabs
    
  7. 
      
JH
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/svn/pysvn.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/svn/pysvn.py
    
    
  2. 
      
JH
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/svn/pysvn.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/svn/pysvn.py
    
    
  2. 
      
david
  1. 
      
  2. reviewboard/scmtools/svn/pysvn.py (Diff revision 3)
     
     
     
    Show all issues

    This comment isn't necessary.

  3. 
      
JH
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/svn/pysvn.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/svn/pysvn.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
JH
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (fcac5e4)
Loading...