Fix fetching Subversion file contents from Beanstalk.

Review Request #8060 — Created March 16, 2016 and submitted

Information

Review Board
release-2.0.x
1deb09c...

Reviewers

Beanstalk made an undocumented change to how they handled boolean
values. They no longer accept "1" for "true", but actually require
"true". This broke our ability to fetch file contents from Subversion
repositories.

This is a simple change that just switches the boolean value used.

Tested this against a Beanstalk repository, and saw the file contents.

Unit tests pass.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/beanstalk.py
        reviewboard/hostingsvcs/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/beanstalk.py
        reviewboard/hostingsvcs/tests.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (267bf17)
Loading...