Convert js/accountPrefsPage to ES6.

 






 

 


  Review Request #8054
  —
  Created March 11, 2016 and submitted 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-2.6.x
 









 
 

  
 









 
 

  
 









 
 

  41bea50...
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This converts the two views in js/accountPrefsPage to ES6. The transforms

herein are relatively simple--primarily just making use of syntactic sugar.

This also fixes up all the doc comments.

 








  


 
 

  
Ran js-tests.

 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Can we use super() directly now?

      		
      
       brenniebrennie
      
      
       
      
     




     

      
       
       
Why was accountPagePrefsPageView.js removed?

      		
      
       brenniebrennie
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js
    reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.es6.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js
    reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.es6.js


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




brennie




   

   







  

 



 

  


   

   

    
 
brennie


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Can we use super() directly now?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Apparently only if I convert these to use class (otherwise the prototype chain isn't set up quite right).
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Yeah, that's going to be a much more involved conversion.
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      I've been using it in other changes and it seems to be working fine. That may just because the super() polyfill is equivalent to our _super and isn't 100% correct. Oh well.
      
 
      

      4. 



    4. 
 
 
      
 
      
  
 
      
 
      
  
      Are you using super() as a method or like a variable? If it's like a method, then you're actually calling the superclass constructor again.
      
 
      

      5. 



    5. 
 
 
      
 
      
  
 
      
 
      
  
      as a variable, e.g. super.initialize(...args)
      
 
      

      6. 



    6. 
 
 
      
 
      
  
 
      
 
      
  
      Hmm. I was having issues with it. I'll try again.
      
 
      

      7. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




brennie




   

   







  

 



 

  


   

   

    
 
brennie


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/staticbundles.py
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

    
     
    

    
     
    

       
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Why was accountPagePrefsPageView.js removed?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Because that file doesn't exist.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      That is a good reason!
      
 
      

      3. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




brennie




   

   







  

 



 

  


   

   

    
 
brennie


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-2.6.x (3b9c477)





 


 










  

 









     

    

   

  

  

   
   Loading...