Summary

Convert js/accountPrefsPage to ES6.

Review Request #8054 — Created March 11, 2016 and submitted March 16, 2016, 10:09 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.6.x

Bugs

Depends On

Commit

41bea50...

Reviewers

Groups

reviewboard

People

Description

This converts the two views in js/accountPrefsPage to ES6. The transforms
herein are relatively simple--primarily just making use of syntactic sugar.
This also fixes up all the doc comments.

Testing Done

Ran js-tests.

Issues

Description	From	Last Updated
Can we use super() directly now?	brennie	March 11, 2016, 2:41 p.m.
Why was accountPagePrefsPageView.js removed?	brennie	March 15, 2016, 11:16 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js
    reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.es6.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js
    reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.es6.js

reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js (Diff revision 1)

The issue has been dropped. Show all issues

Can we use super() directly now?

david March 11, 2016, 1:51 p.m.

Apparently only if I convert these to use class (otherwise the prototype chain isn't set up quite right).

david March 11, 2016, 2:41 p.m.

Yeah, that's going to be a much more involved conversion.

brennie March 14, 2016, 10 p.m.

I've been using it in other changes and it seems to be working fine. That may just because the super() polyfill is equivalent to our _super and isn't 100% correct. Oh well.

david March 15, 2016, 11:18 a.m.

Are you using super() as a method or like a variable? If it's like a method, then you're actually calling the superclass constructor again.

brennie March 15, 2016, 7:20 p.m.

as a variable, e.g. super.initialize(...args)

david March 16, 2016, 9:58 a.m.

Hmm. I was having issues with it. I'll try again.

reviewboard/staticbundles.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Why was accountPagePrefsPageView.js removed?
```
1. david March 14, 2016, 10:30 p.m.
  Because that file doesn't exist.
2. brennie March 15, 2016, 7:21 p.m.
  That is a good reason!

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.6.x (3b9c477)