Summary

Fix JS-based file uploads to not use XMLHttpRequest.sendAsBinary.

Review Request #8044 — Created March 9, 2016 and submitted March 9, 2016, 3:47 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.6.x

Bugs

Depends On

Commit

8e24587...

Reviewers

Groups

reviewboard

People

Description

The sendAsBinary method is non-standard and deprecated. It was only ever
shipped in Firefox, and we used a polyfill on the rest of our platforms.

The correct way of doing this is the Blob version of XMLHttpRequest.send().
This is supported on all the browsers that support Uint8Array (which was used
in the polyfill).

Testing Done


Uploaded a file via drag-and-drop.
Ran js-tests.

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    reviewboard/static/rb/js/utils/apiUtils.js
    reviewboard/static/rb/js/resources/models/baseResourceModel.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    reviewboard/static/rb/js/utils/apiUtils.js
    reviewboard/static/rb/js/resources/models/baseResourceModel.js

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.6.x (f9c27aa)