Summary

Allow webhooks with multiple or no events

Review Request #8042 — Created March 9, 2016 and submitted March 9, 2016, 3:37 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The event parsing code for webhook events incorrectly assumed there would

be spaces when there weren't. The parsing code has been updated to fix

this issue. Also, it will no return an empty list instead of a list

containing an empty string when no events are specified.
Additionally, the WebHookTarget model has been updated to allow for no

events to be specified.
Unit tests have been added to cover the new behaviour and ensure it does

not regress.

Testing Done

Ran unit tests.

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/models.py
    reviewboard/webapi/tests/test_webhook.py
    reviewboard/webapi/resources/webhook.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/models.py
    reviewboard/webapi/tests/test_webhook.py
    reviewboard/webapi/resources/webhook.py

Description:: ~
The event parsing code for webhooks incorrectly assumed there would be
~ spaces when there weren't. The parsing code has been updated to fix this
~ issue. Also, it will no return an empty list instead of a list
~
The event parsing code for webhook events incorrectly assumed there would
~ be spaces when there weren't. The parsing code has been updated to fix
~ this issue. Also, it will no return an empty list instead of a list
containing an empty string when no events are specified.

Additionally, the WebHookTarget model has been updated to allow for no
events to be specified.

Unit tests have been added to cover the new behaviour and ensure it does
not regress.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (797e24a)

~		The event parsing code for webhooks incorrectly assumed there would be
~		spaces when there weren't. The parsing code has been updated to fix this
~		issue. Also, it will no return an empty list instead of a list
	~	The event parsing code for webhook events incorrectly assumed there would
	~	be spaces when there weren't. The parsing code has been updated to fix
	~	this issue. Also, it will no return an empty list instead of a list
		containing an empty string when no events are specified.

		Additionally, the `WebHookTarget` model has been updated to allow for no
		events to be specified.

		Unit tests have been added to cover the new behaviour and ensure it does
		not regress.