Fixed missing commit_id for non-perforce clients when posting a new review

Review Request #8006 — Created Feb. 26, 2016 and submitted

Information

RBTools
master

Reviewers

After 2cf7aaf, posting a review would only have a commit_id for scm clients that supported changesets. After the breaking commit, commit_id would always be set to changenum when posting a review, regardless of whether or not a changenum was found (impossible for git clients, for example).

Tested posting a review with a git client

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
    
    
  2. 
      
BE
BE
david
  1. Ship It!
  2. 
      
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.6.x (02f796e)
Loading...