[WIP] Templating and CSS changes preparing to include a new subview in the draft review banner.

Review Request #8002 — Created Feb. 26, 2016 and discarded

smith
Review Board
master
reviewboard
Templating and CSS changes preparing to include a new subview in the draft review banner.


Description From Last Updated

Mixed tabs and spaces.

brenniebrennie

Mixed tabs and spaces.

brenniebrennie

This file is indendted with tabs and spaces.

brenniebrennie

Trailing whitespace

brenniebrennie

Mixed tabs and spaces.

brenniebrennie

This should be indented two spaces, not two tabs.

brenniebrennie

Can you fix the alignment here? This line should be on the same level as the one above it. The ...

imaduemeimadueme

Can you fix the alignment here too? (Maybe the mixed tabs and spaces issue came back?)

imaduemeimadueme

Same thing. (Maybe the mixed tabs and spaces issue came back?)

imaduemeimadueme

Trailing whitespace (came back?)

imaduemeimadueme

Indent template items 4 spaces and have closing ] be on same level as line 5. This is how all ...

imaduemeimadueme

Same thing as the template above. Also there should be a blank line between these two templates (b/n line 11 ...

imaduemeimadueme

Space before {. (Super nitpicky I know, but, this is the issue I always get on my stuff :P).

imaduemeimadueme

Indent 4 spaces in.

imaduemeimadueme

Space before {

imaduemeimadueme

Fix indentation. Spaces before {. Use single-quotes instad of double-quotes for strings in js. Space after comma before 2nd 'this'. ...

imaduemeimadueme

Space before {

imaduemeimadueme

Do or do not. There is no try. (Remove the comment)

imaduemeimadueme

Remove space before the 2nd 'this'.

imaduemeimadueme

This is indented too much.

imaduemeimadueme

Space before {. (Find all the others and fix them).

imaduemeimadueme

Are you checking for exactly null? If so use !==. Otherwise an undefined might fail this (which is probably not ...

imaduemeimadueme

Fix indentations and use single quotes.

imaduemeimadueme

Fix indentations and use single quotes.

imaduemeimadueme

Reviewboard style is that variables should be defined with 1 var. For example: var furthest, curr, scroll;

imaduemeimadueme

Mix tabs and spaces again?

imaduemeimadueme

Fix indentations. Space before {. Last } should be on it's own line.

imaduemeimadueme

All of this should be indented 1 more space in since you added a new div. You indented the closing ...

imaduemeimadueme
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
SM
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/BannerDiffListView.js
        reviewboard/static/rb/js/views/draftReviewBannerView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/BannerDiffListView.js
        reviewboard/static/rb/js/views/draftReviewBannerView.js
    
    
  2. 
      
SM
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/js/views/draftReviewBannerView.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/js/views/draftReviewBannerView.js
    
    
  2. 
      
SM
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
    
    
  2. 
      
SM
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
brennie
  1. 
      
  2. Mixed tabs and spaces.

  3. Mixed tabs and spaces.

  4. This file is indendted with tabs and spaces.

  5. Trailing whitespace

  6. Mixed tabs and spaces.

  7. This should be indented two spaces, not two tabs.

  8. 
      
SM
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
SM
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
SM
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
SM
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
imadueme
  1. 
      
  2. Can you fix the alignment here? This line should be on the same level as the one above it. The body of this block should only be indented 2 spaces in.

  3. Can you fix the alignment here too? (Maybe the mixed tabs and spaces issue came back?)

  4. Same thing. (Maybe the mixed tabs and spaces issue came back?)

  5. Trailing whitespace (came back?)

  6. reviewboard/static/rb/js/views/bannerDiffListView.js (Diff revision 9)
     
     
     
     
     
     
     
     

    Indent template items 4 spaces and have closing ] be on same level as line 5. This is how all templates in the codebase look. It should look like:

    difflist_template: _.template([
        '<div class=\"banner\">',
        '    Banner is over: <span id=\"bancontent\"></span>',
        '    <ul id=\"fileList">',
        '    </ul>',
        '</div>'
    ].join('')),'
    
  7. reviewboard/static/rb/js/views/bannerDiffListView.js (Diff revision 9)
     
     
     
     
     
     

    Same thing as the template above. Also there should be a blank line between these two templates (b/n line 11 and 12).

  8. Space before {. (Super nitpicky I know, but, this is the issue I always get on my stuff :P).

  9. Indent 4 spaces in.

  10. reviewboard/static/rb/js/views/bannerDiffListView.js (Diff revision 9)
     
     
     
     
     
     

    Fix indentation. Spaces before {. Use single-quotes instad of double-quotes for strings in js. Space after comma before 2nd 'this'. Should look like:

    setCollection: function(collection) {
        collection.each(function (file) {
            $('ul#fileList').append(this._item_template(file.attributes));
        }, this);
    },
    
  11. Do or do not. There is no try. (Remove the comment)

    1. Though, is the use of a context variable there insane and unecessary? I think I'm using it to get it into the scope of the document ready function, but...

  12. Remove space before the 2nd 'this'.

  13. This is indented too much.

  14. Space before {. (Find all the others and fix them).

  15. Are you checking for exactly null? If so use !==. Otherwise an undefined might fail this (which is probably not a big deal I guess). Better yet use underscore: !(_.isNull(event.data.topmost()))

  16. reviewboard/static/rb/js/views/bannerDiffListView.js (Diff revision 9)
     
     
     
     
     
     
     
     
     
     
     
     

    Fix indentations and use single quotes.

  17. reviewboard/static/rb/js/views/bannerDiffListView.js (Diff revision 9)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     

    Fix indentations and use single quotes.

  18. Reviewboard style is that variables should be defined with 1 var. For example:

    var furthest,
        curr,
        scroll;
    
  19. Mix tabs and spaces again?

  20. Fix indentations. Space before {. Last } should be on it's own line.

  21. reviewboard/templates/reviews/reviewable_base.html (Diff revision 9)
     
     
     
     
     
     

    All of this should be indented 1 more space in since you added a new div. You indented the closing tag for that div correctly as reference. (Since this stuff is nested under the 'banner' div)

  22. 
      
SM
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/views/bannerDraftNotice.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/views/bannerDraftNotice.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
SM
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/views/bannerDraftNotice.js
        reviewboard/static/rb/js/pages/views/reviewablePageView.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
        reviewboard/static/rb/js/views/bannerDiffListView.js
        reviewboard/static/rb/css/pages/reviews.less
        reviewboard/templates/reviews/reviewable_base.html
        reviewboard/static/rb/js/views/reviewBoxView.js
        reviewboard/static/rb/js/views/bannerDraftNotice.js
        reviewboard/static/rb/js/pages/views/reviewablePageView.js
        reviewboard/static/rb/js/pages/views/diffViewerPageView.js
    
    
  2. 
      
SM
Review request changed

Status: Discarded

Loading...