ExtensionInfo can not parse PKG-INFO with multiline description
Review Request #8001 — Created Feb. 26, 2016 and submitted
ExtensionInfo can not parse PKG-INFO with multiline description
Testing done also with ReviewBoard
Description | From | Last Updated |
---|---|---|
Col: 11 E111 indentation is not a multiple of four |
reviewbot | |
Col: 11 E111 indentation is not a multiple of four |
reviewbot | |
Col: 11 E111 indentation is not a multiple of four |
reviewbot | |
Alphabetize |
brennie | |
Single quotes on 'PKG-INFO' |
brennie | |
blank line between these. |
brennie | |
Blank line between these. |
brennie | |
This does not handle the case where we cannot decode using any of the encodings. |
brennie | |
Blank line between these. |
brennie | |
If data is empty, we don't really need to go through the above, do we? |
brennie | |
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot | |
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot | |
This really should be a constant on the class. |
brennie | |
Can you reflow this? Each sentence needn't take up a whole line. |
brennie | |
Blank line between these. |
brennie | |
Single quotes. Can you move the % to the next line? |
brennie | |
Single quotes. Can you move the % to the next line? |
brennie | |
Please add a period at the end. |
david | |
It would be a little nicer to write this using for..else (avoiding the "decoded" variable): for enc in self.encodings: try: … |
david |
Status: Re-opened
Testing Done: |
|
|||
---|---|---|---|---|
Bugs: |
|
|||
Diff: |
Revision 1 (+15 -7) |
-
-
djblets/extensions/extension.py (Diff revision 1) Col: 11 E111 indentation is not a multiple of four
-
djblets/extensions/extension.py (Diff revision 1) Col: 11 E111 indentation is not a multiple of four
-
djblets/extensions/extension.py (Diff revision 1) Col: 11 E111 indentation is not a multiple of four
-
Tool: Pyflakes Processed Files: djblets/extensions/extension.py Tool: PEP8 Style Checker Processed Files: djblets/extensions/extension.py
-
-
-
-
-
-
djblets/extensions/extension.py (Diff revision 2) This does not handle the case where we cannot decode using any of the encodings.
-
-
djblets/extensions/extension.py (Diff revision 2) If data is empty, we don't really need to go through the above, do we?
Change Summary:
Introduced fixes for comments and some feedback for still open points
Diff: |
Revision 3 (+15 -5) |
---|
-
Tool: PEP8 Style Checker Processed Files: djblets/extensions/extension.py Tool: Pyflakes Processed Files: djblets/extensions/extension.py
-
Tool: Pyflakes Processed Files: djblets/extensions/extension.py Tool: PEP8 Style Checker Processed Files: djblets/extensions/extension.py
-
-
-
Tool: Pyflakes Processed Files: djblets/extensions/extension.py Tool: PEP8 Style Checker Processed Files: djblets/extensions/extension.py
-
-
-
djblets/extensions/extension.py (Diff revision 5) Can you reflow this? Each sentence needn't take up a
whole line. -
-
djblets/extensions/extension.py (Diff revision 5) Single quotes. Can you move the
%
to the next line? -
djblets/extensions/extension.py (Diff revision 5) Single quotes. Can you move the
%
to the next line?
Change Summary:
Made encodings as ExtensionInfo class constant
Small style fixes
Diff: |
Revision 6 (+31 -5) |
---|
-
Tool: Pyflakes Processed Files: djblets/extensions/extension.py Tool: PEP8 Style Checker Processed Files: djblets/extensions/extension.py
-
-
-
djblets/extensions/extension.py (Diff revision 6) It would be a little nicer to write this using
for..else
(avoiding the "decoded" variable):for enc in self.encodings: try: data = data.decode(enc) break except UnicodeDecodeError: continue else: logging.warning( 'Failed to decode PKG-INFO content for extension %s', entrypoint.name)
We also don't need to log in the success case.