Update LESS_BINARY and add BABEL_BINARY to cope with no symlinks.

 






 

 


  Review Request #7994
  —
  Created Feb. 24, 2016 and submitted 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-2.6.x
 









 
 

  
 









 
 

  
 









 
 

  2aefe17...
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Vagrant on windows has issues creating symlinks, especially from within

npm install. It's possible to use npm install --no-bin-links, but then

things are not included in node_modules/.bin.


This change explicitly references the right scripts inside the less and

babel-cli modules.

 








  


 
 

  
Verified that compilation still worked.

 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
'django_reset' imported but unused

      		
      
       reviewbotreviewbot
      
      
       
      
     




     

      
       
       
'from settings_local import *' used; unable to detect undefined names

      		
      
       reviewbotreviewbot
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




reviewbot




   

   







  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Tool: Pyflakes
Processed Files:
    reviewboard/settings.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/settings.py
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
     'django_reset' imported but unused

    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      reviewboard/settings.py
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
     'from settings_local import *' used; unable to detect undefined names

    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 





 

  

   





 SM





   

   





  

 



 

  


   

   

    
 
smith


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Well, I went and double-checked what NODE_PATH will resolve to against the directory structure on my RB install, and it's setting these variables to the proper location. Looks okay on that front!
    

    But if we no longer need symlinks in /.bin, and some installations won't be able to create symlinks in /.bin, does that mean that we should deprecate the /.bin directory entirely? There's a lot more scripts in there than the two that we're pointing to by hand, I think. (babel-doctor, babel-external-helpers, and babel-node. - other babel stuff.) Will we see problems with those?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I'm not sure what you mean by "deprecate the /.bin directory". This is a directory which is created by npm, and whether it's there or not, we will no longer need to care.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I meant "stop making it, if we're in charge of making it." But since it was created by npm, ceasing to care about it is enough.
      
 
      

      3. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




brennie




   

   







  

 



 

  


   

   

    
 
brennie


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-2.6.x (003d442)





 


 










  

 









     

    

   

  

  

   
   Loading...