Fix display of codehilite sections which have been iterated.
Review Request #7983 — Created Feb. 19, 2016 and submitted
When using
iter_markdown_lineson something that contains a codehilite block,
the resulting output would display in a very ugly way (and a way that was not
valid HTML). I've improved the iteration and the style for these so they show
correctly.
- Looked at a change description in Review Board that added some code blocks.
Before, they looked very ugly, now they look pretty. - Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Col: 67 E703 statement ends with a semicolon |
 reviewbot
|
|
|
undefined name 'line' |
reviewbot
|
|
|
Col: 80 E501 line too long (99 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (104 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (97 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (91 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (92 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (94 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (90 > 79 characters) |
reviewbot
|
|
|
Any chance they don't? Can we assert on this, or conditionally apply the logic, in case things change down the … |
 chipx86
|
|
|
Col: 80 E501 line too long (91 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (92 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (94 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (90 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (91 > 79 characters) |
reviewbot
|
|
|
Let's wrap these so that we don't get Review Bot yelling at us for the rest of time. Annoying as … |
chipx86
|
|
|
Col: 80 E501 line too long (92 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (94 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (90 > 79 characters) |
reviewbot
|
|
|
Col: 17 E131 continuation line unaligned for hanging indent |
reviewbot
|
-
Tool: Pyflakes Processed Files: djblets/markdown/__init__.py djblets/markdown/tests.py Ignored Files: djblets/static/djblets/css/mixins/markdown.less Tool: PEP8 Style Checker Processed Files: djblets/markdown/__init__.py djblets/markdown/tests.py Ignored Files: djblets/static/djblets/css/mixins/markdown.less -
-
-
-
-
-
djblets/markdown/__init__.py (Diff revision 2) Any chance they don't? Can we assert on this, or conditionally apply the logic, in case things change down the road?
-
Tool: Pyflakes Processed Files: djblets/markdown/__init__.py djblets/markdown/tests.py Ignored Files: djblets/static/djblets/css/mixins/markdown.less Tool: PEP8 Style Checker Processed Files: djblets/markdown/__init__.py djblets/markdown/tests.py Ignored Files: djblets/static/djblets/css/mixins/markdown.less -
-
-
-
-
-
djblets/markdown/tests.py (Diff revision 3) Let's wrap these so that we don't get Review Bot yelling at us for the rest of time. Annoying as that formatting may be.
-
Tool: Pyflakes Processed Files: djblets/markdown/__init__.py djblets/markdown/tests.py Ignored Files: djblets/static/djblets/css/mixins/markdown.less Tool: PEP8 Style Checker Processed Files: djblets/markdown/__init__.py djblets/markdown/tests.py Ignored Files: djblets/static/djblets/css/mixins/markdown.less -
djblets/markdown/tests.py (Diff revision 4) Col: 17 E131 continuation line unaligned for hanging indent
-
Tool: Pyflakes Processed Files: djblets/markdown/__init__.py djblets/markdown/tests.py Ignored Files: djblets/static/djblets/css/mixins/markdown.less Tool: PEP8 Style Checker Processed Files: djblets/markdown/__init__.py djblets/markdown/tests.py Ignored Files: djblets/static/djblets/css/mixins/markdown.less
Tool: Pyflakes Processed Files: djblets/markdown/__init__.py djblets/markdown/tests.py Ignored Files: djblets/static/djblets/css/mixins/markdown.less Tool: PEP8 Style Checker Processed Files: djblets/markdown/__init__.py djblets/markdown/tests.py Ignored Files: djblets/static/djblets/css/mixins/markdown.less