Summary

Fix display of codehilite sections which have been iterated.

Review Request #7983 — Created Feb. 19, 2016 and submitted Feb. 21, 2016, 12:05 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

When using iter_markdown_lines on something that contains a codehilite block,
the resulting output would display in a very ugly way (and a way that was not
valid HTML). I've improved the iteration and the style for these so they show
correctly.

Testing Done


Looked at a change description in Review Board that added some code blocks.

  Before, they looked very ugly, now they look pretty.
Ran unit tests.

Files

Issues

Description	From	Last Updated
Col: 67 E703 statement ends with a semicolon	reviewbot	Feb. 19, 2016, 10:38 a.m.
undefined name 'line'	reviewbot	Feb. 19, 2016, 10:38 a.m.
Col: 80 E501 line too long (99 > 79 characters)	reviewbot	Feb. 19, 2016, 10:41 a.m.
Col: 80 E501 line too long (104 > 79 characters)	reviewbot	Feb. 19, 2016, 10:41 a.m.
Col: 80 E501 line too long (97 > 79 characters)	reviewbot	Feb. 19, 2016, 10:41 a.m.
Col: 80 E501 line too long (91 > 79 characters)	reviewbot	Feb. 19, 2016, 10:41 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Feb. 19, 2016, 10:41 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Feb. 19, 2016, 10:41 a.m.
Col: 80 E501 line too long (90 > 79 characters)	reviewbot	Feb. 19, 2016, 10:41 a.m.
Any chance they don't? Can we assert on this, or conditionally apply the logic, in case things change down the …	chipx86	Feb. 20, 2016, 11:17 p.m.
Col: 80 E501 line too long (91 > 79 characters)	reviewbot	Feb. 19, 2016, 10:43 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Feb. 19, 2016, 10:43 a.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Feb. 19, 2016, 10:43 a.m.
Col: 80 E501 line too long (90 > 79 characters)	reviewbot	Feb. 19, 2016, 10:43 a.m.
Col: 80 E501 line too long (91 > 79 characters)	reviewbot	Feb. 20, 2016, 11:22 p.m.
Let's wrap these so that we don't get Review Bot yelling at us for the rest of time. Annoying as …	chipx86	Feb. 20, 2016, 11:59 p.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	Feb. 20, 2016, 11:22 p.m.
Col: 80 E501 line too long (94 > 79 characters)	reviewbot	Feb. 20, 2016, 11:22 p.m.
Col: 80 E501 line too long (90 > 79 characters)	reviewbot	Feb. 20, 2016, 11:22 p.m.
Col: 17 E131 continuation line unaligned for hanging indent	reviewbot	Feb. 21, 2016, 12:03 a.m.

Tool: Pyflakes
Processed Files:
    djblets/markdown/__init__.py
    djblets/markdown/tests.py

Ignored Files:
    djblets/static/djblets/css/mixins/markdown.less



Tool: PEP8 Style Checker
Processed Files:
    djblets/markdown/__init__.py
    djblets/markdown/tests.py

Ignored Files:
    djblets/static/djblets/css/mixins/markdown.less

djblets/markdown/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 67
 E703 statement ends with a semicolon
```
djblets/markdown/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name 'line'
```
djblets/markdown/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (99 > 79 characters)
```
djblets/markdown/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (104 > 79 characters)
```
djblets/markdown/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (97 > 79 characters)
```
djblets/markdown/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (91 > 79 characters)
```
djblets/markdown/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
djblets/markdown/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
djblets/markdown/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (90 > 79 characters)
```

Diff:

Revision 2 (+59 -4)

Show changes

	djblets/markdown/__init__.py
	djblets/markdown/tests.py
	djblets/static/djblets/css/mixins/markdown.less

Tool: Pyflakes
Processed Files:
    djblets/markdown/__init__.py
    djblets/markdown/tests.py

Ignored Files:
    djblets/static/djblets/css/mixins/markdown.less



Tool: PEP8 Style Checker
Processed Files:
    djblets/markdown/__init__.py
    djblets/markdown/tests.py

Ignored Files:
    djblets/static/djblets/css/mixins/markdown.less

djblets/markdown/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (91 > 79 characters)
```
djblets/markdown/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
djblets/markdown/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
djblets/markdown/tests.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (90 > 79 characters)
```

djblets/markdown/__init__.py (Diff revision 2)

The issue has been resolved. Show all issues

Any chance they don't? Can we assert on this, or conditionally apply the logic, in case things change down the road?

Diff:

Revision 3 (+61 -4)

Show changes

	djblets/markdown/__init__.py
	djblets/markdown/tests.py
	djblets/static/djblets/css/mixins/markdown.less

Tool: Pyflakes
Processed Files:
    djblets/markdown/__init__.py
    djblets/markdown/tests.py

Ignored Files:
    djblets/static/djblets/css/mixins/markdown.less



Tool: PEP8 Style Checker
Processed Files:
    djblets/markdown/__init__.py
    djblets/markdown/tests.py

Ignored Files:
    djblets/static/djblets/css/mixins/markdown.less

djblets/markdown/tests.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (91 > 79 characters)
```
djblets/markdown/tests.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
djblets/markdown/tests.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (94 > 79 characters)
```
djblets/markdown/tests.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (90 > 79 characters)
```

djblets/markdown/tests.py (Diff revision 3)

The issue has been resolved. Show all issues

Let's wrap these so that we don't get Review Bot yelling at us for the rest of time. Annoying as that formatting may be.

Diff:

Revision 4 (+65 -4)

Show changes

	djblets/markdown/__init__.py
	djblets/markdown/tests.py
	djblets/static/djblets/css/mixins/markdown.less

Tool: Pyflakes
Processed Files:
    djblets/markdown/__init__.py
    djblets/markdown/tests.py

Ignored Files:
    djblets/static/djblets/css/mixins/markdown.less



Tool: PEP8 Style Checker
Processed Files:
    djblets/markdown/__init__.py
    djblets/markdown/tests.py

Ignored Files:
    djblets/static/djblets/css/mixins/markdown.less

djblets/markdown/tests.py (Diff revision 4)

The issue has been resolved. Show all issues

Col: 17
 E131 continuation line unaligned for hanging indent

david Feb. 21, 2016, 12:03 a.m.
```
Arrrrr.
```

chipx86 Feb. 21, 2016, 12:04 a.m.

Sometimes I think I like the idea of Slack reaction emojis, for this very reason.

Diff:

Revision 5 (+65 -4)

Show changes

	djblets/markdown/__init__.py
	djblets/markdown/tests.py
	djblets/static/djblets/css/mixins/markdown.less

Tool: Pyflakes
Processed Files:
    djblets/markdown/__init__.py
    djblets/markdown/tests.py

Ignored Files:
    djblets/static/djblets/css/mixins/markdown.less



Tool: PEP8 Style Checker
Processed Files:
    djblets/markdown/__init__.py
    djblets/markdown/tests.py

Ignored Files:
    djblets/static/djblets/css/mixins/markdown.less

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.10.x (27deb62)