Summary

Add a site setting for the static URL

Review Request #7979 — Created Feb. 19, 2016 and submitted March 3, 2016, 11:57 a.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This patch adds a field to the general site settings form for

configuring the URL of served static media.

Testing Done

Updated the field and verified requests were made to the new URL.

Issues

Description	From	Last Updated
Can you include instructions about leaving this blank similar to site_media_url?	david	Feb. 26, 2016, 4:16 p.m.
Let's clarify just a bit more, saying: "to the static files, such as the JavaScript, CSS, and image files bundled …	chipx86	March 3, 2016, 11:56 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/admin/forms.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/forms.py

What's the use case here?

chipx86 Feb. 26, 2016, 3:24 p.m.

Configuring usage of a CDN without having to go through management commands. We already have this for uploaded media. I've hit a need for this so many times with RBCommons (when CloudFront fell over once, and often during deployments when the CDN hasn't yet updated and we need to temporarily revert back to /static/).

```
typo in description: ot -> to
```

reviewboard/admin/forms.py (Diff revision 1)

The issue has been resolved. Show all issues

Can you include instructions about leaving this blank similar to site_media_url?

Change Summary:

Address David's issues.

Description:

~		This patch adds a field ot the general site settings form for
	~	This patch adds a field to the general site settings form for
		configuring the URL of served static media.

Diff:

Revision 2 (+9 -2)

Show changes

reviewboard/admin/forms.py

Tool: Pyflakes
Processed Files:
    reviewboard/admin/forms.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/forms.py

Ship it!

```
Ship It!
```

reviewboard/admin/forms.py (Diff revision 2)

The issue has been resolved. Show all issues

Let's clarify just a bit more, saying: "to the static files, such as the JavaScript, CSS, and image files bundled with Review Board or third-party extensions." That way it's slightly more clear what people will be dealing with here.

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (b3dfbed)