Add a site setting for the static URL

Review Request #7979 — Created Feb. 19, 2016 and submitted

brennie
Review Board
release-2.0.x
reviewboard

This patch adds a field to the general site settings form for
configuring the URL of served static media.

Updated the field and verified requests were made to the new URL.

Description From Last Updated

Can you include instructions about leaving this blank similar to site_media_url?

daviddavid

Let's clarify just a bit more, saying: "to the static files, such as the JavaScript, CSS, and image files bundled ...

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/admin/forms.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/admin/forms.py
    
    
  2. 
      
david
  1. What's the use case here?

    1. Configuring usage of a CDN without having to go through management commands. We already have this for uploaded media. I've hit a need for this so many times with RBCommons (when CloudFront fell over once, and often during deployments when the CDN hasn't yet updated and we need to temporarily revert back to /static/).

  2. 
      
david
  1. typo in description: ot -> to

  2. reviewboard/admin/forms.py (Diff revision 1)
     
     

    Can you include instructions about leaving this blank similar to site_media_url?

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/admin/forms.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/admin/forms.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. reviewboard/admin/forms.py (Diff revision 2)
     
     

    Let's clarify just a bit more, saying: "to the static files, such as the JavaScript, CSS, and image files bundled with Review Board or third-party extensions." That way it's slightly more clear what people will be dealing with here.

  3. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (b3dfbed)
Loading...