Summary

Add a get_settings method for JS Extensions

Review Request #7968 — Created Feb. 17, 2016 and submitted Feb. 21, 2016, 7:37 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.8.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The JSExtension class now has a get_settings method that returns, by

default, the associated extension's settings. This method can be

overrided by subclasses to provide different settings at initialization

time.

Testing Done

Issues

Description	From	Last Updated
This isn't accessing the correct function.	chipx86	Feb. 17, 2016, 4:15 p.m.

Tool: PEP8 Style Checker
Processed Files:
    djblets/extensions/extension.py

Ignored Files:
    djblets/extensions/templates/extensions/init_js_extensions.html



Tool: Pyflakes
Processed Files:
    djblets/extensions/extension.py

Ignored Files:
    djblets/extensions/templates/extensions/init_js_extensions.html

Can you add a blurb about this in the class docstring?

djblets/extensions/templates/extensions/init_js_extensions.html (Diff revision 1)
The issue has been resolved. Show all issues
```
This isn't accessing the correct function.
```

Diff:

Revision 2 (+20 -2)

Show changes

	djblets/extensions/extension.py
	djblets/extensions/templates/extensions/init_js_extensions.html

Tool: Pyflakes
Processed Files:
    djblets/extensions/extension.py

Ignored Files:
    djblets/extensions/templates/extensions/init_js_extensions.html



Tool: PEP8 Style Checker
Processed Files:
    djblets/extensions/extension.py

Ignored Files:
    djblets/extensions/templates/extensions/init_js_extensions.html

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.8.x (64e7747)