Add a get_settings method for JS Extensions

Review Request #7968 — Created Feb. 17, 2016 and submitted

Information

Djblets
release-0.8.x

Reviewers

The JSExtension class now has a get_settings method that returns, by
default, the associated extension's settings. This method can be
overrided by subclasses to provide different settings at initialization
time.


 
Description From Last Updated

This isn't accessing the correct function.

chipx86chipx86
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        djblets/extensions/extension.py
    
    Ignored Files:
        djblets/extensions/templates/extensions/init_js_extensions.html
    
    
    
    Tool: Pyflakes
    Processed Files:
        djblets/extensions/extension.py
    
    Ignored Files:
        djblets/extensions/templates/extensions/init_js_extensions.html
    
    
  2. 
      
chipx86
  1. Can you add a blurb about this in the class docstring?

  2. This isn't accessing the correct function.

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/extensions/extension.py
    
    Ignored Files:
        djblets/extensions/templates/extensions/init_js_extensions.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/extensions/extension.py
    
    Ignored Files:
        djblets/extensions/templates/extensions/init_js_extensions.html
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.8.x (64e7747)
Loading...