Summary

[OAuth2Provider] Add webAPI end point for user to remove OAuth2 token from My Account page

Review Request #7964 — Created Feb. 15, 2016 and discarded Sept. 7, 2017, 9 p.m.

Information

Owner

lehoangm

Repository

Review Board

Branch

master

Bugs

Depends On

~~7941~~

Reviewers

Groups

reviewboard

People

brennie, chipx86

Description

A new webAPI end point is added for user to GET and DELETE a OAuth2 token given
OAuth2 token ID. The webAPI is meant to be called from My Account for user to
remove a OAuth2 token.

Testing Done

Command run: python ./tests/runtests.py reviewboard.webapi.tests.test_oauth2_token

Test GET for list of OAuth2 token
Test GET and DELETE for OAuth2 token

This a copy from test_api_token

Issues

Description	From	Last Updated
'json' imported but unused	reviewbot	Feb. 16, 2016, 1:17 p.m.
'ValidationError' imported but unused	reviewbot	Feb. 16, 2016, 1:17 p.m.
'ObjectDoesNotExist' imported but unused	reviewbot	Feb. 16, 2016, 1:17 p.m.
'_' imported but unused	reviewbot	Feb. 16, 2016, 1:17 p.m.
'webapi_response_errors' imported but unused	reviewbot	Feb. 16, 2016, 1:17 p.m.
'webapi_request_fields' imported but unused	reviewbot	Feb. 16, 2016, 1:17 p.m.
'webapi_login_required' imported but unused	reviewbot	Feb. 16, 2016, 1:17 p.m.
'NOT_LOGGED_IN' imported but unused	reviewbot	Feb. 16, 2016, 1:17 p.m.
'DOES_NOT_EXIST' imported but unused	reviewbot	Feb. 16, 2016, 1:17 p.m.
'PERMISSION_DENIED' imported but unused	reviewbot	Feb. 16, 2016, 1:17 p.m.
'INVALID_FORM_DATA' imported but unused	reviewbot	Feb. 16, 2016, 1:17 p.m.
'resources' imported but unused	reviewbot	Feb. 16, 2016, 1:17 p.m.
'Application' imported but unused	reviewbot	Feb. 16, 2016, 1:30 p.m.
'oauth2_token_item_mimetype' imported but unused	reviewbot	Feb. 16, 2016, 1:30 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Feb. 16, 2016, 1:31 p.m.
oauth2_provider is an outside module, so should belong in the same import group, in alphabetical order.	chipx86	March 5, 2016, 9:16 p.m.
Same import group.	chipx86	March 5, 2016, 9:16 p.m.
This seems to be missing a _get_queryset. It'd need one in order to limit results to the user, and to …	chipx86	March 5, 2016, 9:47 p.m.
Blank line between these.	chipx86	March 5, 2016, 9:18 p.m.
This is an outside module, so it should be part of the next import group.	chipx86	March 5, 2016, 9:18 p.m.
Make sure things are in alphabetical order.	chipx86	March 5, 2016, 9:25 p.m.
No need for parens.	chipx86	March 6, 2016, 12:36 a.m.
Indented too far.	chipx86	March 5, 2016, 9:31 p.m.
We don't put one argument per line. Ends up being pretty long this way. Same below.	chipx86	March 6, 2016, 12:49 a.m.
Same line, no trailing comma, since this is a function call.	chipx86	March 5, 2016, 9:37 p.m.
Blank line between these.	chipx86	March 5, 2016, 9:37 p.m.
Same line, no comma.	chipx86	March 5, 2016, 9:37 p.m.
Blank line between these. Same below.	chipx86	March 5, 2016, 9:37 p.m.
Col: 18 E711 comparison to None should be 'if cond is None:'	reviewbot	March 10, 2016, 9:25 a.m.
Col: 20 E711 comparison to None should be 'if cond is None:'	reviewbot	March 10, 2016, 9:25 a.m.
Col: 24 E711 comparison to None should be 'if cond is None:'	reviewbot	March 10, 2016, 9:25 a.m.
Col: 49 E128 continuation line under-indented for visual indent	reviewbot	March 10, 2016, 9:25 a.m.
Col: 18 E711 comparison to None should be 'if cond is None:'	reviewbot	March 10, 2016, 9:28 a.m.
Col: 20 E711 comparison to None should be 'if cond is None:'	reviewbot	March 10, 2016, 9:28 a.m.
Col: 24 E711 comparison to None should be 'if cond is None:'	reviewbot	March 10, 2016, 9:28 a.m.
Col: 49 E128 continuation line under-indented for visual indent	reviewbot	March 10, 2016, 9:28 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/oauth2_token.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/__init__.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/oauth2TokenModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/oauth2_token.py
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/__init__.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/oauth2TokenModel.js

reviewboard/webapi/resources/oauth2_token.py (Diff revision 1)
Show all issues
```
 'json' imported but unused
```
reviewboard/webapi/resources/oauth2_token.py (Diff revision 1)
Show all issues
```
 'ValidationError' imported but unused
```
reviewboard/webapi/resources/oauth2_token.py (Diff revision 1)
Show all issues
```
 'ObjectDoesNotExist' imported but unused
```
reviewboard/webapi/resources/oauth2_token.py (Diff revision 1)
Show all issues
```
 '_' imported but unused
```
reviewboard/webapi/resources/oauth2_token.py (Diff revision 1)
Show all issues
```
 'webapi_response_errors' imported but unused
```
reviewboard/webapi/resources/oauth2_token.py (Diff revision 1)
Show all issues
```
 'webapi_request_fields' imported but unused
```
reviewboard/webapi/resources/oauth2_token.py (Diff revision 1)
Show all issues
```
 'webapi_login_required' imported but unused
```
reviewboard/webapi/resources/oauth2_token.py (Diff revision 1)
Show all issues
```
 'NOT_LOGGED_IN' imported but unused
```
reviewboard/webapi/resources/oauth2_token.py (Diff revision 1)
Show all issues
```
 'DOES_NOT_EXIST' imported but unused
```
reviewboard/webapi/resources/oauth2_token.py (Diff revision 1)
Show all issues
```
 'PERMISSION_DENIED' imported but unused
```
reviewboard/webapi/resources/oauth2_token.py (Diff revision 1)
Show all issues
```
 'INVALID_FORM_DATA' imported but unused
```
reviewboard/webapi/resources/oauth2_token.py (Diff revision 1)
Show all issues
```
 'resources' imported but unused
```

Change Summary:

Add UnitTest

Testing Done:

~		I am still figuring out how to test an webAPI endpoint
	~	Command run: python ./tests/runtests.py reviewboard.webapi.tests.test_oauth2_token
	+
	+	Test GET for list of OAuth2 token
	+	Test GET and DELETE for OAuth2 token
	+
	+	This a copy from test_api_token

Diff:

Revision 2 (+229 -23)

Show changes

	reviewboard/static/rb/js/accountPrefsPage/views/oauth2TokensView.js
	reviewboard/static/rb/js/resources/models/oauth2TokenModel.js
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/oauth2_token.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_oauth2_token.py
	reviewboard/webapi/tests/urls.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/tests/test_oauth2_token.py
    reviewboard/webapi/resources/oauth2_token.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py

Ignored Files:
    reviewboard/static/rb/js/accountPrefsPage/views/oauth2TokensView.js
    reviewboard/static/rb/js/resources/models/oauth2TokenModel.js



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/tests/test_oauth2_token.py
    reviewboard/webapi/resources/oauth2_token.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py

Ignored Files:
    reviewboard/static/rb/js/accountPrefsPage/views/oauth2TokensView.js
    reviewboard/static/rb/js/resources/models/oauth2TokenModel.js

reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 2)
Show all issues
```
 'Application' imported but unused
```
reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 2)
Show all issues
```
 'oauth2_token_item_mimetype' imported but unused
```
reviewboard/webapi/tests/urls.py (Diff revision 2)
Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Change Summary:

Update reviewbot

Diff:

Revision 3 (+231 -23)

Show changes

	reviewboard/static/rb/js/accountPrefsPage/views/oauth2TokensView.js
	reviewboard/static/rb/js/resources/models/oauth2TokenModel.js
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/oauth2_token.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_oauth2_token.py
	reviewboard/webapi/tests/urls.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/tests/test_oauth2_token.py
    reviewboard/webapi/resources/oauth2_token.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py

Ignored Files:
    reviewboard/static/rb/js/accountPrefsPage/views/oauth2TokensView.js
    reviewboard/static/rb/js/resources/models/oauth2TokenModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/tests/test_oauth2_token.py
    reviewboard/webapi/resources/oauth2_token.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py

Ignored Files:
    reviewboard/static/rb/js/accountPrefsPage/views/oauth2TokensView.js
    reviewboard/static/rb/js/resources/models/oauth2TokenModel.js

The first couple of files just remove stuff from prior changes. Instead, you should update the prior changes to remove the code there, so that each change is a cohesive unit.

reviewboard/webapi/resources/__init__.py (Diff revision 3)

Show all issues

oauth2_provider is an outside module, so should belong in the same import group, in alphabetical order.

reviewboard/webapi/resources/oauth2_token.py (Diff revision 3)
Show all issues
```
Same import group.
```

reviewboard/webapi/resources/oauth2_token.py (Diff revision 3)

Show all issues

This seems to be missing a _get_queryset. It'd need one in order to limit results to the user, and to do permission checking, like other resources that are children of the user resource.

lehoangm March 10, 2016, 9:26 a.m.

Do we have a test for this? I dont it see anywhere.

reviewboard/webapi/resources/oauth2_token.py (Diff revision 3)
Show all issues
```
Blank line between these.
```

reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 3)

Show all issues

This is an outside module, so it should be part of the next import group.

reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 3)

Show all issues

Make sure things are in alphabetical order.

reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 3)
Show all issues
```
No need for parens.
```
1. LE
  
  lehoangm March 10, 2016, 9:26 a.m.
  parens as () not a typo for parents
reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 3)
Show all issues
```
Indented too far.
```

reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 3)

Show all issues

We don't put one argument per line. Ends up being pretty long this way.

Same below.

lehoangm March 10, 2016, 9:26 a.m.

Discussed on Slack.

token=random().__str__(), expires=timezone.now(), will be change to None and push to the body. 

Since we have the docstring we will try as many on a line as possible

reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 3)
Show all issues
```
Same line, no trailing comma, since this is a function call.
```
reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 3)
Show all issues
```
Blank line between these.
```
reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 3)
Show all issues
```
Same line, no comma.
```
reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 3)
Show all issues
```
Blank line between these.
Same below.
```

Change Summary:

Update CR

Diff:

Revision 4 (+284)

Show changes

	reviewboard/static/rb/js/resources/models/oauth2TokenModel.js
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/oauth2_token.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_oauth2_token.py
	reviewboard/webapi/tests/urls.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/tests/test_oauth2_token.py
    reviewboard/webapi/resources/oauth2_token.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/oauth2TokenModel.js



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/tests/test_oauth2_token.py
    reviewboard/webapi/resources/oauth2_token.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/oauth2TokenModel.js

reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 4)
Show all issues
```
Col: 18
 E711 comparison to None should be 'if cond is None:'
```
reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 4)
Show all issues
```
Col: 20
 E711 comparison to None should be 'if cond is None:'
```
reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 4)
Show all issues
```
Col: 24
 E711 comparison to None should be 'if cond is None:'
```
reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 4)
Show all issues
```
Col: 49
 E128 continuation line under-indented for visual indent
```

Change Summary:

Update pep8; Remove wip status

Summary:

-	[OAuth2Provider] [WIP] Add webAPI end point for user to remove OAuth2 token from My Account page
+	[OAuth2Provider] Add webAPI end point for user to remove OAuth2 token from My Account page

Diff:

Revision 5 (+284)

Show changes

	reviewboard/static/rb/js/resources/models/oauth2TokenModel.js
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/oauth2_token.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_oauth2_token.py
	reviewboard/webapi/tests/urls.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/tests/test_oauth2_token.py
    reviewboard/webapi/resources/oauth2_token.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/oauth2TokenModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/tests/test_oauth2_token.py
    reviewboard/webapi/resources/oauth2_token.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/oauth2TokenModel.js

reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 5)
Show all issues
```
Col: 18
 E711 comparison to None should be 'if cond is None:'
```
reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 5)
Show all issues
```
Col: 20
 E711 comparison to None should be 'if cond is None:'
```
reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 5)
Show all issues
```
Col: 24
 E711 comparison to None should be 'if cond is None:'
```
reviewboard/webapi/tests/test_oauth2_token.py (Diff revision 5)
Show all issues
```
Col: 49
 E128 continuation line under-indented for visual indent
```

Change Summary:

Update pep8; Not sure why the previous never commited

Diff:

Revision 6 (+284)

Show changes

	reviewboard/static/rb/js/resources/models/oauth2TokenModel.js
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/oauth2_token.py
	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_oauth2_token.py
	reviewboard/webapi/tests/urls.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/tests/test_oauth2_token.py
    reviewboard/webapi/resources/oauth2_token.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/oauth2TokenModel.js



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/tests/test_oauth2_token.py
    reviewboard/webapi/resources/oauth2_token.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/user.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/oauth2TokenModel.js

Review Board 6.0.3 alpha 0 (dev)

[OAuth2Provider] Add webAPI end point for user to remove OAuth2 token from My Account page

Information

Reviewers

Change Summary:

Testing Done:

Diff:

Change Summary:

Diff:

Change Summary:

Diff:

Change Summary:

Summary:

Diff:

Change Summary:

Diff:

Status: Discarded