Summary

Add an ES6Compiler which renames .es6.js to .js.

Review Request #7955 — Created Feb. 10, 2016 and submitted Feb. 23, 2016, 8:49 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Commit

bad917a...

Reviewers

Groups

djblets

People

Description

Pipeline's built-in ES6Compiler forces one to use the annoying .es6
extension, which breaks a lot of other built-in tooling. This compiler uses the
somewhat more sane .es6.js.

Testing Done

Used this with Review Board.

Issues

Description	From	Last Updated
Only one blank line here.	chipx86	Feb. 19, 2016, 9:51 a.m.
Can you go into more detail on how this is used in here? Like, how a project consumes it?	chipx86	Feb. 19, 2016, 9:51 a.m.
Blank line after the docstring.	chipx86	Feb. 19, 2016, 9:51 a.m.
"bool"	chipx86	Feb. 19, 2016, 9:51 a.m.
We should probably assert that the file ends with self.input_extension.	chipx86	Feb. 19, 2016, 9:52 a.m.

Tool: Pyflakes
Processed Files:
    djblets/pipeline/compilers/es6.py

Ignored Files:
    djblets/pipeline/compilers/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/pipeline/compilers/es6.py

Ignored Files:
    djblets/pipeline/compilers/__init__.py

Ship it!

```
Ship It!
```

djblets/pipeline/compilers/es6.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Only one blank line here.
```

djblets/pipeline/compilers/es6.py (Diff revision 1)

The issue has been resolved. Show all issues

Can you go into more detail on how this is used in here? Like, how a project consumes it?

djblets/pipeline/compilers/es6.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line after the docstring.
```
djblets/pipeline/compilers/es6.py (Diff revision 1)
The issue has been resolved. Show all issues
```
"bool"
```
djblets/pipeline/compilers/es6.py (Diff revision 1)
The issue has been resolved. Show all issues
```
We should probably assert that the file ends with self.input_extension.
```

Diff:

Revision 2 (+45)

Show changes

	djblets/pipeline/compilers/__init__.py
	djblets/pipeline/compilers/es6.py

Tool: Pyflakes
Processed Files:
    djblets/pipeline/compilers/es6.py

Ignored Files:
    djblets/pipeline/compilers/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/pipeline/compilers/es6.py

Ignored Files:
    djblets/pipeline/compilers/__init__.py

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (2380005)