-
-
-
reviewboard/settings.py (Diff revision 1) 'from settings_local import *' used; unable to detect undefined names
-
Update to django-pipeline 1.6
Review Request #7953 — Created Feb. 9, 2016 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-2.6.x | |
| 372193b... | |
| Reviewers | |
| reviewboard | |
This change makes the changes necessary in Review Board to use django-pipeline
1.6.0. In particular, we need to switch to the newExtensionFinderStorage,
update the settings for the newPIPELINEattribute, and modify our templates
to use the new templatetags.
- Went through the UI and verified CSS, JS, and images.
- Checked to see that an extension still worked in dev-mode.
- Ran unit tests.
- Built a package and saw media collect correctly.
- Built an extension package and saw that everything built correctly.
| Description | From | Last Updated |
|---|---|---|
|
'django_reset' imported but unused |
 reviewbot
|
|
|
'from settings_local import *' used; unable to detect undefined names |
reviewbot
|
|
|
Col: 1 E402 module level import not at top of file |
reviewbot
|
|
|
So this will be used during runtime only? Or am I misunderstanding? If so, we need STATIC_ROOT to consider subdir … |
 chipx86
|
|
|
'django_reset' imported but unused |
reviewbot
|
|
|
'from settings_local import *' used; unable to detect undefined names |
reviewbot
|
|
|
Col: 1 E402 module level import not at top of file |
reviewbot
|
-
-
reviewboard/settings.py (Diff revision 1) So this will be used during runtime only? Or am I misunderstanding?
If so, we need
STATIC_ROOTto consider subdir installs.Also, we're duplicating a lot here from
contrib/internal/conf/settings_local.py, and also the Djblets packaging stuff. Wonder if we can centralize more of it.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+80 -56) |
-
Tool: Pyflakes Processed Files: reviewboard/settings.py reviewboard/attachments/mimetypes.py reviewboard/staticbundles.py Ignored Files: reviewboard/templates/js/tests.html reviewboard/templates/admin/login.html reviewboard/templates/base.html reviewboard/templates/admin/notifications/webhooktarget/change_form.html reviewboard/templates/admin/scmtools/repository/change_form.html reviewboard/templates/reviews/ui/default.html reviewboard/templates/admin/dashboard.html reviewboard/templates/admin/base_site.html reviewboard/templates/admin/security.html reviewboard/templates/reviews/new_review_request.html reviewboard/templates/datagrids/datagrid.html reviewboard/templates/reviews/reviewable_base.html reviewboard/templates/admin/diffviewer/filediff/change_form.html Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py reviewboard/attachments/mimetypes.py reviewboard/staticbundles.py Ignored Files: reviewboard/templates/js/tests.html reviewboard/templates/admin/login.html reviewboard/templates/base.html reviewboard/templates/admin/notifications/webhooktarget/change_form.html reviewboard/templates/admin/scmtools/repository/change_form.html reviewboard/templates/reviews/ui/default.html reviewboard/templates/admin/dashboard.html reviewboard/templates/admin/base_site.html reviewboard/templates/admin/security.html reviewboard/templates/reviews/new_review_request.html reviewboard/templates/datagrids/datagrid.html reviewboard/templates/reviews/reviewable_base.html reviewboard/templates/admin/diffviewer/filediff/change_form.html -
-
reviewboard/settings.py (Diff revision 2) 'from settings_local import *' used; unable to detect undefined names
-
Tool: Pyflakes Processed Files: reviewboard/settings.py reviewboard/attachments/mimetypes.py reviewboard/staticbundles.py Ignored Files: reviewboard/templates/js/tests.html reviewboard/templates/admin/login.html reviewboard/templates/base.html reviewboard/templates/admin/notifications/webhooktarget/change_form.html reviewboard/templates/admin/scmtools/repository/change_form.html reviewboard/templates/reviews/ui/default.html reviewboard/templates/admin/dashboard.html reviewboard/templates/admin/base_site.html reviewboard/templates/admin/security.html reviewboard/templates/reviews/new_review_request.html reviewboard/templates/datagrids/datagrid.html reviewboard/templates/reviews/reviewable_base.html reviewboard/templates/admin/diffviewer/filediff/change_form.html Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py reviewboard/attachments/mimetypes.py reviewboard/staticbundles.py Ignored Files: reviewboard/templates/js/tests.html reviewboard/templates/admin/login.html reviewboard/templates/base.html reviewboard/templates/admin/notifications/webhooktarget/change_form.html reviewboard/templates/admin/scmtools/repository/change_form.html reviewboard/templates/reviews/ui/default.html reviewboard/templates/admin/dashboard.html reviewboard/templates/admin/base_site.html reviewboard/templates/admin/security.html reviewboard/templates/reviews/new_review_request.html reviewboard/templates/datagrids/datagrid.html reviewboard/templates/reviews/reviewable_base.html reviewboard/templates/admin/diffviewer/filediff/change_form.html