Summary

Update to django-pipeline 1.6

Review Request #7953 — Created Feb. 9, 2016 and submitted Feb. 23, 2016, 8:49 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.6.x

Bugs

Depends On

Commit

372193b...

Reviewers

Groups

reviewboard

People

Description

This change makes the changes necessary in Review Board to use django-pipeline
1.6.0. In particular, we need to switch to the new ExtensionFinderStorage,
update the settings for the new PIPELINE attribute, and modify our templates
to use the new templatetags.

Testing Done


Went through the UI and verified CSS, JS, and images.
Checked to see that an extension still worked in dev-mode.
Ran unit tests.
Built a package and saw media collect correctly.
Built an extension package and saw that everything built correctly.

Issues

Description	From	Last Updated
'django_reset' imported but unused	reviewbot	Feb. 9, 2016, 11:05 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 9, 2016, 11:05 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 9, 2016, 11:05 p.m.
So this will be used during runtime only? Or am I misunderstanding? If so, we need STATIC_ROOT to consider subdir …	chipx86	Feb. 17, 2016, 9:49 a.m.
'django_reset' imported but unused	reviewbot	Feb. 17, 2016, 10 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 17, 2016, 10 a.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 17, 2016, 10 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/settings.py
    reviewboard/attachments/mimetypes.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/templates/js/tests.html
    reviewboard/templates/admin/login.html
    reviewboard/templates/base.html
    reviewboard/templates/admin/notifications/webhooktarget/change_form.html
    reviewboard/templates/admin/scmtools/repository/change_form.html
    reviewboard/templates/reviews/ui/default.html
    reviewboard/templates/admin/dashboard.html
    reviewboard/templates/admin/base_site.html
    reviewboard/templates/admin/security.html
    reviewboard/templates/reviews/new_review_request.html
    reviewboard/templates/datagrids/datagrid.html
    reviewboard/templates/reviews/reviewable_base.html
    reviewboard/templates/admin/diffviewer/filediff/change_form.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py
    reviewboard/attachments/mimetypes.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/templates/js/tests.html
    reviewboard/templates/admin/login.html
    reviewboard/templates/base.html
    reviewboard/templates/admin/notifications/webhooktarget/change_form.html
    reviewboard/templates/admin/scmtools/repository/change_form.html
    reviewboard/templates/reviews/ui/default.html
    reviewboard/templates/admin/dashboard.html
    reviewboard/templates/admin/base_site.html
    reviewboard/templates/admin/security.html
    reviewboard/templates/reviews/new_review_request.html
    reviewboard/templates/datagrids/datagrid.html
    reviewboard/templates/reviews/reviewable_base.html
    reviewboard/templates/admin/diffviewer/filediff/change_form.html

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

Ship it!

```
Ship It!
```

reviewboard/settings.py (Diff revision 1)

The issue has been resolved. Show all issues

So this will be used during runtime only? Or am I misunderstanding?

If so, we need STATIC_ROOT to consider subdir installs.

Also, we're duplicating a lot here from contrib/internal/conf/settings_local.py, and also the Djblets packaging stuff. Wonder if we can centralize more of it.

david Feb. 17, 2016, 9:49 a.m.

Hmm, so yeah, that's an issue for this particular patch. However, with https://reviews.reviewboard.org/r/7954/ we'll be able to simplify all of this because compilation will happen on the backend.

Commit:

6f94c3dfde871b1addcacf59f33b65a3a7983e01

372193b67b3d52e44ab7675c06fd39f2852fe27a

Diff:

Revision 2 (+80 -56)

Show changes

	reviewboard/settings.py
	reviewboard/staticbundles.py
	reviewboard/attachments/mimetypes.py
	reviewboard/templates/base.html
	reviewboard/templates/admin/base_site.html
	reviewboard/templates/admin/dashboard.html
	reviewboard/templates/admin/login.html
	reviewboard/templates/admin/security.html
	8 more

Tool: Pyflakes
Processed Files:
    reviewboard/settings.py
    reviewboard/attachments/mimetypes.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/templates/js/tests.html
    reviewboard/templates/admin/login.html
    reviewboard/templates/base.html
    reviewboard/templates/admin/notifications/webhooktarget/change_form.html
    reviewboard/templates/admin/scmtools/repository/change_form.html
    reviewboard/templates/reviews/ui/default.html
    reviewboard/templates/admin/dashboard.html
    reviewboard/templates/admin/base_site.html
    reviewboard/templates/admin/security.html
    reviewboard/templates/reviews/new_review_request.html
    reviewboard/templates/datagrids/datagrid.html
    reviewboard/templates/reviews/reviewable_base.html
    reviewboard/templates/admin/diffviewer/filediff/change_form.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py
    reviewboard/attachments/mimetypes.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/templates/js/tests.html
    reviewboard/templates/admin/login.html
    reviewboard/templates/base.html
    reviewboard/templates/admin/notifications/webhooktarget/change_form.html
    reviewboard/templates/admin/scmtools/repository/change_form.html
    reviewboard/templates/reviews/ui/default.html
    reviewboard/templates/admin/dashboard.html
    reviewboard/templates/admin/base_site.html
    reviewboard/templates/admin/security.html
    reviewboard/templates/reviews/new_review_request.html
    reviewboard/templates/datagrids/datagrid.html
    reviewboard/templates/reviews/reviewable_base.html
    reviewboard/templates/admin/diffviewer/filediff/change_form.html

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

Status:: Completed
Change Summary:: Pushed to release-2.6.x (93a591f)