Summary

Add support in Review Board for service integrations.

Review Request #7949 — Created Feb. 7, 2016 and submitted April 1, 2016, 7:07 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This makes use of the new Djblets Integrations framework, allowing
extensions to register service integrations for Review Board. These
integrations work sort of like extensions, in that they can listen for
events and act upon them, but are primarily designed to interact with
third-party services.

Integrations can contain any number of admin-provided configurations.
This would allow, for example, a Slack integration to post notifications
about review requests to different Slack channels or even teams,
depending on the review groups or repositories.

Testing Done

Modified the Slack extension to use integrations, and configured it
for a couple different channels. Saw that it posted to both channels
when updating review requests.

Checked that the styles for the pages were correct.

Files

Issues

Description	From	Last Updated
'django_reset' imported but unused	reviewbot	Feb. 7, 2016, 1:40 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 7, 2016, 1:40 a.m.
'PIPELINE_CSS' imported but unused	reviewbot	Feb. 7, 2016, 1:40 a.m.
'PIPELINE_JS' imported but unused	reviewbot	Feb. 7, 2016, 1:40 a.m.
'django_reset' imported but unused	reviewbot	Feb. 7, 2016, 1:28 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 7, 2016, 1:28 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	Feb. 7, 2016, 1:28 p.m.
'PIPELINE_JS' imported but unused	reviewbot	Feb. 7, 2016, 1:28 p.m.
Given that this is in Review Board, can we make the language about "any supporting application" more specific?	david	March 5, 2016, 7:16 p.m.
Docstring?	david	March 5, 2016, 7:20 p.m.
'django_reset' imported but unused	reviewbot	Feb. 7, 2016, 1:36 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 7, 2016, 1:36 p.m.
'PIPELINE_JS' imported but unused	reviewbot	Feb. 7, 2016, 1:36 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	Feb. 7, 2016, 1:36 p.m.
'django_reset' imported but unused	reviewbot	March 5, 2016, 7:22 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 5, 2016, 7:22 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/integrations/base.py
    reviewboard/integrations/urls.py
    reviewboard/settings.py
    reviewboard/integrations/forms.py
    reviewboard/extensions/hooks.py
    reviewboard/staticbundles.py
    reviewboard/integrations/models.py
    reviewboard/integrations/__init__.py
    reviewboard/admin/urls.py
    reviewboard/integrations/views.py

Ignored Files:
    reviewboard/static/rb/css/pages/admin-integrations.less
    reviewboard/static/rb/css/pages/admin.less
    reviewboard/templates/admin/base_site.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/integrations/base.py
    reviewboard/integrations/urls.py
    reviewboard/settings.py
    reviewboard/integrations/forms.py
    reviewboard/extensions/hooks.py
    reviewboard/staticbundles.py
    reviewboard/integrations/models.py
    reviewboard/integrations/__init__.py
    reviewboard/admin/urls.py
    reviewboard/integrations/views.py

Ignored Files:
    reviewboard/static/rb/css/pages/admin-integrations.less
    reviewboard/static/rb/css/pages/admin.less
    reviewboard/templates/admin/base_site.html

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Change Summary:

Added missing codebase doc entries.

Diff:

Revision 2 (+284 -1)

Show changes

	docs/manual/conf.py
	docs/manual/extending/coderef/index.rst
	reviewboard/settings.py
	reviewboard/staticbundles.py
	reviewboard/admin/urls.py
	reviewboard/extensions/hooks.py
	reviewboard/integrations/__init__.py
	reviewboard/integrations/base.py
	7 more

Tool: Pyflakes
Processed Files:
    reviewboard/integrations/base.py
    reviewboard/integrations/urls.py
    reviewboard/settings.py
    reviewboard/integrations/forms.py
    reviewboard/integrations/models.py
    reviewboard/staticbundles.py
    reviewboard/extensions/hooks.py
    reviewboard/integrations/__init__.py
    reviewboard/admin/urls.py
    reviewboard/integrations/views.py
    docs/manual/conf.py

Ignored Files:
    reviewboard/static/rb/css/pages/admin.less
    docs/manual/extending/coderef/index.rst
    reviewboard/static/rb/css/pages/admin-integrations.less
    reviewboard/templates/admin/base_site.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/integrations/base.py
    reviewboard/integrations/urls.py
    reviewboard/settings.py
    reviewboard/integrations/forms.py
    reviewboard/integrations/models.py
    reviewboard/staticbundles.py
    reviewboard/extensions/hooks.py
    reviewboard/integrations/__init__.py
    reviewboard/admin/urls.py
    reviewboard/integrations/views.py
    docs/manual/conf.py

Ignored Files:
    reviewboard/static/rb/css/pages/admin.less
    docs/manual/extending/coderef/index.rst
    reviewboard/static/rb/css/pages/admin-integrations.less
    reviewboard/templates/admin/base_site.html

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Change Summary:


Fixed some typos in the docs for Integration.
Turned off function signatures in the autosummary.

Diff:

Revision 3 (+285 -1)

Show changes

	docs/manual/conf.py
	docs/manual/extending/coderef/index.rst
	reviewboard/settings.py
	reviewboard/staticbundles.py
	reviewboard/admin/urls.py
	reviewboard/extensions/hooks.py
	reviewboard/integrations/__init__.py
	reviewboard/integrations/base.py
	7 more

Tool: Pyflakes
Processed Files:
    reviewboard/integrations/base.py
    reviewboard/integrations/urls.py
    reviewboard/settings.py
    reviewboard/integrations/forms.py
    reviewboard/integrations/models.py
    reviewboard/staticbundles.py
    reviewboard/extensions/hooks.py
    reviewboard/integrations/__init__.py
    reviewboard/admin/urls.py
    reviewboard/integrations/views.py
    docs/manual/conf.py

Ignored Files:
    reviewboard/static/rb/css/pages/admin.less
    docs/manual/extending/coderef/index.rst
    reviewboard/static/rb/css/pages/admin-integrations.less
    reviewboard/templates/admin/base_site.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/integrations/base.py
    reviewboard/integrations/urls.py
    reviewboard/settings.py
    reviewboard/integrations/forms.py
    reviewboard/integrations/models.py
    reviewboard/staticbundles.py
    reviewboard/extensions/hooks.py
    reviewboard/integrations/__init__.py
    reviewboard/admin/urls.py
    reviewboard/integrations/views.py
    docs/manual/conf.py

Ignored Files:
    reviewboard/static/rb/css/pages/admin.less
    docs/manual/extending/coderef/index.rst
    reviewboard/static/rb/css/pages/admin-integrations.less
    reviewboard/templates/admin/base_site.html

reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```

reviewboard/extensions/hooks.py (Diff revision 3)

The issue has been resolved. Show all issues

Given that this is in Review Board, can we make the language about "any supporting application" more specific?

reviewboard/integrations/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Docstring?
```

Change Summary:


Fixed the IntegrationHook docstring to be more specific to Review Board.
Added a missing docstring.

Diff:

Revision 4 (+292 -1)

Show changes

	docs/manual/conf.py
	docs/manual/extending/coderef/index.rst
	reviewboard/settings.py
	reviewboard/staticbundles.py
	reviewboard/admin/urls.py
	reviewboard/extensions/hooks.py
	reviewboard/integrations/__init__.py
	reviewboard/integrations/base.py
	7 more

Tool: Pyflakes
Processed Files:
    reviewboard/integrations/base.py
    reviewboard/integrations/urls.py
    reviewboard/settings.py
    reviewboard/integrations/forms.py
    reviewboard/integrations/models.py
    reviewboard/staticbundles.py
    reviewboard/extensions/hooks.py
    reviewboard/integrations/__init__.py
    reviewboard/admin/urls.py
    reviewboard/integrations/views.py
    docs/manual/conf.py

Ignored Files:
    reviewboard/static/rb/css/pages/admin.less
    docs/manual/extending/coderef/index.rst
    reviewboard/static/rb/css/pages/admin-integrations.less
    reviewboard/templates/admin/base_site.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/integrations/base.py
    reviewboard/integrations/urls.py
    reviewboard/settings.py
    reviewboard/integrations/forms.py
    reviewboard/integrations/models.py
    reviewboard/staticbundles.py
    reviewboard/extensions/hooks.py
    reviewboard/integrations/__init__.py
    reviewboard/admin/urls.py
    reviewboard/integrations/views.py
    docs/manual/conf.py

Ignored Files:
    reviewboard/static/rb/css/pages/admin.less
    docs/manual/extending/coderef/index.rst
    reviewboard/static/rb/css/pages/admin-integrations.less
    reviewboard/templates/admin/base_site.html

reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (7deb822)