Update to django-pipeline 1.6.6
Review Request #7946 — Created Feb. 5, 2016 and submitted
| Information | |
|---|---|
| david | |
| Djblets | |
| release-0.10.x | |
| afbe322... | |
| Reviewers | |
| djblets | |
This change does the work necessary to move us to a modern django-pipeline.
This involves several independent but related pieces:
- Bump the dependency.
- Update existing templates to use the newpipelinetemplatetag library and
associatedstylesheetandjavascripttags.
- Add a compatibility library for third-party packages that still want to use
the oldcompressedtag library.
- Change settings.py to use the newPIPELINEstructure and split out static
media into astaticbundles.pyfile.
- Make changes to everything that manipulatessettings.PIPELINE*to use the
new settings mechanism.
- Make a few changes to the staticfiles finders and loaders to cope with
pipeline's "simplification".This requires django-pipeline 1.6.6, which contains several patches to fix bugs
and add features that we need for this.This also adds the very beginnings of 0.10 release notes to include
compatibility instructions when updating to use this.
- Ran unit tests
- Built a djblets package and verified that static media got compiled correctly.
- Explored through the Review Board UI and checked that both the basic UI and
extensions which shipped static media worked correctly. - Built an extension and saw that everything worked correctly.
| Description | From | Last Updated |
|---|---|---|
|
Are these settings a given now in Pipeline? Does it auto-create them? If not, we're going to need to deal … |
 chipx86
|
|
|
Alphabetical order. |
chipx86
|
|
|
Removing these variables breaks backwards-compatibility. We need to set up aliases. |
chipx86
|
|
|
Col: 1 E402 module level import not at top of file |
 reviewbot
|
|
|
Missing period at the end of the line. |
chipx86
|
|
|
Wonder if you could just do: register.tag('compressed_css', stylesheet) register.tag('compressed_js', javascript) |
chipx86
|
|
|
<style> needs to be in literal backticks. Same below. |
chipx86
|
|
|
Since I know there will be someone packaging this that wants a newer pipeline, let's have a comment saying why … |
chipx86
|
|
|
Col: 1 E402 module level import not at top of file |
reviewbot
|
|
|
'find' imported but unused |
reviewbot
|
|
|
redefinition of unused 'find' from line 5 |
reviewbot
|
|
|
'staticfiles_storage' imported but unused |
reviewbot
|
|
|
'render_to_string' imported but unused |
reviewbot
|
|
|
'mark_safe' imported but unused |
reviewbot
|
|
|
'pipeline_settings' imported but unused |
reviewbot
|
|
|
Col: 1 E402 module level import not at top of file |
reviewbot
|
|
|
Isnt this going to be SafeText? Same below. |
 brennie
|
|
|
Since we moved to pipeline always in RB, do we want to do the same here? |
brennie
|
|
|
'datetime' imported but unused |
reviewbot
|
|
|
'cache' imported but unused |
reviewbot
|
|
|
'make_cache_key' imported but unused |
reviewbot
|
|
|
'datetime' imported but unused |
reviewbot
|
|
|
'cache' imported but unused |
reviewbot
|
|
|
'make_cache_key' imported but unused |
reviewbot
|
-
-
djblets/extensions/manager.py (Diff revision 1) Are these settings a given now in Pipeline? Does it auto-create them? If not, we're going to need to deal with that situation, and also deal with a client defining the old names.
-
-
djblets/settings.py (Diff revision 1) Removing these variables breaks backwards-compatibility. We need to set up aliases.
-
-
djblets/util/templatetags/compressed.py (Diff revision 1) Wonder if you could just do:
register.tag('compressed_css', stylesheet) register.tag('compressed_js', javascript) -
djblets/util/templatetags/compressed.py (Diff revision 1) <style>needs to be in literal backticks.Same below.
-
setup.py (Diff revision 1) Since I know there will be someone packaging this that wants a newer pipeline, let's have a comment saying why we require exactly 1.6.0.
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+294 -160) |
-
Tool: Pyflakes Processed Files: djblets/util/templatetags/tests.py djblets/extensions/staticfiles.py djblets/staticbundles.py djblets/extensions/templatetags/djblets_extensions.py djblets/extensions/manager.py djblets/extensions/packaging.py djblets/extensions/tests.py setup.py djblets/util/templatetags/compressed.py djblets/settings.py tests/settings.py Ignored Files: djblets/datagrid/templates/datagrid/datagrid.html djblets/forms/templates/djblets_forms/admin/change_form_page.html docs/releasenotes/0.10.rst djblets/configforms/templates/configforms/config.html djblets/extensions/templates/extensions/extension_list.html Tool: PEP8 Style Checker Processed Files: djblets/util/templatetags/tests.py djblets/extensions/staticfiles.py djblets/staticbundles.py djblets/extensions/templatetags/djblets_extensions.py djblets/extensions/manager.py djblets/extensions/packaging.py djblets/extensions/tests.py setup.py djblets/util/templatetags/compressed.py djblets/settings.py tests/settings.py Ignored Files: djblets/datagrid/templates/datagrid/datagrid.html djblets/forms/templates/djblets_forms/admin/change_form_page.html docs/releasenotes/0.10.rst djblets/configforms/templates/configforms/config.html djblets/extensions/templates/extensions/extension_list.html -
Summary: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Testing Done: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Commit: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 3 (+351 -176) |
-
Tool: Pyflakes Processed Files: djblets/util/templatetags/tests.py djblets/extensions/staticfiles.py djblets/staticbundles.py djblets/extensions/templatetags/djblets_extensions.py djblets/extensions/manager.py djblets/extensions/packaging.py djblets/extensions/tests.py setup.py djblets/util/templatetags/compressed.py djblets/settings.py tests/settings.py Ignored Files: djblets/datagrid/templates/datagrid/datagrid.html djblets/forms/templates/djblets_forms/admin/change_form_page.html docs/releasenotes/0.10.rst djblets/configforms/templates/configforms/config.html djblets/extensions/templates/extensions/extension_list.html Tool: PEP8 Style Checker Processed Files: djblets/util/templatetags/tests.py djblets/extensions/staticfiles.py djblets/staticbundles.py djblets/extensions/templatetags/djblets_extensions.py djblets/extensions/manager.py djblets/extensions/packaging.py djblets/extensions/tests.py setup.py djblets/util/templatetags/compressed.py djblets/settings.py tests/settings.py Ignored Files: djblets/datagrid/templates/datagrid/datagrid.html djblets/forms/templates/djblets_forms/admin/change_form_page.html docs/releasenotes/0.10.rst djblets/configforms/templates/configforms/config.html djblets/extensions/templates/extensions/extension_list.html -
-
-
djblets/extensions/templatetags/djblets_extensions.py (Diff revision 3) 'staticfiles_storage' imported but unused
-
djblets/extensions/templatetags/djblets_extensions.py (Diff revision 3) 'render_to_string' imported but unused
-
djblets/extensions/templatetags/djblets_extensions.py (Diff revision 3) 'mark_safe' imported but unused
-
djblets/extensions/templatetags/djblets_extensions.py (Diff revision 3) 'pipeline_settings' imported but unused
-
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+347 -176) |
-
Tool: Pyflakes Processed Files: djblets/util/templatetags/tests.py djblets/extensions/staticfiles.py djblets/staticbundles.py djblets/extensions/templatetags/djblets_extensions.py djblets/extensions/manager.py djblets/extensions/packaging.py djblets/extensions/tests.py setup.py djblets/util/templatetags/compressed.py djblets/settings.py tests/settings.py Ignored Files: djblets/datagrid/templates/datagrid/datagrid.html djblets/forms/templates/djblets_forms/admin/change_form_page.html docs/releasenotes/0.10.rst djblets/configforms/templates/configforms/config.html djblets/extensions/templates/extensions/extension_list.html Tool: PEP8 Style Checker Processed Files: djblets/util/templatetags/tests.py djblets/extensions/staticfiles.py djblets/staticbundles.py djblets/extensions/templatetags/djblets_extensions.py djblets/extensions/manager.py djblets/extensions/packaging.py djblets/extensions/tests.py setup.py djblets/util/templatetags/compressed.py djblets/settings.py tests/settings.py Ignored Files: djblets/datagrid/templates/datagrid/datagrid.html djblets/forms/templates/djblets_forms/admin/change_form_page.html docs/releasenotes/0.10.rst djblets/configforms/templates/configforms/config.html djblets/extensions/templates/extensions/extension_list.html
-
-
djblets/extensions/templatetags/djblets_extensions.py (Diff revision 4) Isnt this going to be SafeText? Same below.
-
djblets/settings.py (Diff revision 4) Since we moved to pipeline always in RB, do we want to do the same here?
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+331 -176) |
-
Tool: Pyflakes Processed Files: djblets/util/templatetags/tests.py djblets/extensions/staticfiles.py djblets/staticbundles.py djblets/extensions/templatetags/djblets_extensions.py djblets/extensions/manager.py djblets/extensions/packaging.py djblets/extensions/tests.py setup.py djblets/util/templatetags/compressed.py djblets/settings.py tests/settings.py Ignored Files: djblets/datagrid/templates/datagrid/datagrid.html djblets/forms/templates/djblets_forms/admin/change_form_page.html docs/releasenotes/0.10.rst djblets/configforms/templates/configforms/config.html djblets/extensions/templates/extensions/extension_list.html Tool: PEP8 Style Checker Processed Files: djblets/util/templatetags/tests.py djblets/extensions/staticfiles.py djblets/staticbundles.py djblets/extensions/templatetags/djblets_extensions.py djblets/extensions/manager.py djblets/extensions/packaging.py djblets/extensions/tests.py setup.py djblets/util/templatetags/compressed.py djblets/settings.py tests/settings.py Ignored Files: djblets/datagrid/templates/datagrid/datagrid.html djblets/forms/templates/djblets_forms/admin/change_form_page.html docs/releasenotes/0.10.rst djblets/configforms/templates/configforms/config.html djblets/extensions/templates/extensions/extension_list.html -
-
-
Summary: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 6 (+331 -176) |
-
Tool: Pyflakes Processed Files: djblets/util/templatetags/tests.py djblets/extensions/staticfiles.py djblets/staticbundles.py djblets/extensions/templatetags/djblets_extensions.py djblets/extensions/manager.py djblets/extensions/packaging.py djblets/extensions/tests.py setup.py djblets/util/templatetags/compressed.py djblets/settings.py tests/settings.py Ignored Files: djblets/datagrid/templates/datagrid/datagrid.html djblets/forms/templates/djblets_forms/admin/change_form_page.html docs/releasenotes/0.10.rst djblets/configforms/templates/configforms/config.html djblets/extensions/templates/extensions/extension_list.html Tool: PEP8 Style Checker Processed Files: djblets/util/templatetags/tests.py djblets/extensions/staticfiles.py djblets/staticbundles.py djblets/extensions/templatetags/djblets_extensions.py djblets/extensions/manager.py djblets/extensions/packaging.py djblets/extensions/tests.py setup.py djblets/util/templatetags/compressed.py djblets/settings.py tests/settings.py Ignored Files: djblets/datagrid/templates/datagrid/datagrid.html djblets/forms/templates/djblets_forms/admin/change_form_page.html docs/releasenotes/0.10.rst djblets/configforms/templates/configforms/config.html djblets/extensions/templates/extensions/extension_list.html -
-
-
Tool: Pyflakes Processed Files: djblets/util/templatetags/tests.py djblets/extensions/staticfiles.py djblets/staticbundles.py djblets/extensions/templatetags/djblets_extensions.py djblets/extensions/manager.py djblets/extensions/packaging.py djblets/extensions/tests.py setup.py djblets/util/templatetags/compressed.py djblets/settings.py tests/settings.py Ignored Files: djblets/datagrid/templates/datagrid/datagrid.html djblets/forms/templates/djblets_forms/admin/change_form_page.html djblets/configforms/templates/configforms/config.html djblets/extensions/templates/extensions/extension_list.html Tool: PEP8 Style Checker Processed Files: djblets/util/templatetags/tests.py djblets/extensions/staticfiles.py djblets/staticbundles.py djblets/extensions/templatetags/djblets_extensions.py djblets/extensions/manager.py djblets/extensions/packaging.py djblets/extensions/tests.py setup.py djblets/util/templatetags/compressed.py djblets/settings.py tests/settings.py Ignored Files: djblets/datagrid/templates/datagrid/datagrid.html djblets/forms/templates/djblets_forms/admin/change_form_page.html djblets/configforms/templates/configforms/config.html djblets/extensions/templates/extensions/extension_list.html