Summary

Update to django-pipeline 1.6.6

Review Request #7946 — Created Feb. 5, 2016 and submitted Feb. 23, 2016, 8:49 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Commit

afbe322...

Reviewers

Groups

djblets

People

Description

This change does the work necessary to move us to a modern django-pipeline.
This involves several independent but related pieces:
- Bump the dependency.
- Update existing templates to use the new pipeline templatetag library and
associated stylesheet and javascript tags.
- Add a compatibility library for third-party packages that still want to use
the old compressed tag library.
- Change settings.py to use the new PIPELINE structure and split out static
media into a staticbundles.py file.
- Make changes to everything that manipulates settings.PIPELINE* to use the
new settings mechanism.
- Make a few changes to the staticfiles finders and loaders to cope with
pipeline's "simplification".

This requires django-pipeline 1.6.6, which contains several patches to fix bugs
and add features that we need for this.

This also adds the very beginnings of 0.10 release notes to include
compatibility instructions when updating to use this.

Testing Done


Ran unit tests
Built a djblets package and verified that static media got compiled correctly.
Explored through the Review Board UI and checked that both the basic UI and

  extensions which shipped static media worked correctly.
Built an extension and saw that everything worked correctly.

Issues

Description	From	Last Updated
Are these settings a given now in Pipeline? Does it auto-create them? If not, we're going to need to deal …	chipx86	Feb. 6, 2016, 3:51 p.m.
Alphabetical order.	chipx86	Feb. 6, 2016, 4:15 p.m.
Removing these variables breaks backwards-compatibility. We need to set up aliases.	chipx86	Feb. 6, 2016, 3:51 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 5, 2016, 11 p.m.
Missing period at the end of the line.	chipx86	Feb. 6, 2016, 4:14 p.m.
Wonder if you could just do: register.tag('compressed_css', stylesheet) register.tag('compressed_js', javascript)	chipx86	Feb. 6, 2016, 4:14 p.m.
<style> needs to be in literal backticks. Same below.	chipx86	Feb. 6, 2016, 4:14 p.m.
Since I know there will be someone packaging this that wants a newer pipeline, let's have a comment saying why …	chipx86	Feb. 6, 2016, 4:13 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 7, 2016, 11:58 a.m.
'find' imported but unused	reviewbot	Feb. 9, 2016, 5 p.m.
redefinition of unused 'find' from line 5	reviewbot	Feb. 9, 2016, 5 p.m.
'staticfiles_storage' imported but unused	reviewbot	Feb. 9, 2016, 5:01 p.m.
'render_to_string' imported but unused	reviewbot	Feb. 9, 2016, 5:01 p.m.
'mark_safe' imported but unused	reviewbot	Feb. 9, 2016, 5:01 p.m.
'pipeline_settings' imported but unused	reviewbot	Feb. 9, 2016, 5:01 p.m.
Col: 1 E402 module level import not at top of file	reviewbot	Feb. 9, 2016, 5:01 p.m.
Isnt this going to be SafeText? Same below.	brennie	Feb. 17, 2016, 9:19 a.m.
Since we moved to pipeline always in RB, do we want to do the same here?	brennie	Feb. 17, 2016, 9:20 a.m.
'datetime' imported but unused	reviewbot	Feb. 17, 2016, 10:21 a.m.
'cache' imported but unused	reviewbot	Feb. 17, 2016, 10:21 a.m.
'make_cache_key' imported but unused	reviewbot	Feb. 17, 2016, 10:21 a.m.
'datetime' imported but unused	reviewbot	Feb. 22, 2016, 6:37 p.m.
'cache' imported but unused	reviewbot	Feb. 22, 2016, 6:37 p.m.
'make_cache_key' imported but unused	reviewbot	Feb. 22, 2016, 6:37 p.m.

Tool: Pyflakes
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/staticfiles.py
    djblets/staticbundles.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/extensions/manager.py
    djblets/extensions/packaging.py
    djblets/extensions/tests.py
    setup.py
    djblets/util/templatetags/compressed.py
    djblets/settings.py
    tests/settings.py

Ignored Files:
    djblets/datagrid/templates/datagrid/datagrid.html
    djblets/forms/templates/djblets_forms/admin/change_form_page.html
    djblets/configforms/templates/configforms/config.html
    djblets/extensions/templates/extensions/extension_list.html



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/staticfiles.py
    djblets/staticbundles.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/extensions/manager.py
    djblets/extensions/packaging.py
    djblets/extensions/tests.py
    setup.py
    djblets/util/templatetags/compressed.py
    djblets/settings.py
    tests/settings.py

Ignored Files:
    djblets/datagrid/templates/datagrid/datagrid.html
    djblets/forms/templates/djblets_forms/admin/change_form_page.html
    djblets/configforms/templates/configforms/config.html
    djblets/extensions/templates/extensions/extension_list.html

djblets/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

djblets/extensions/manager.py (Diff revision 1)

The issue has been dropped. Show all issues

Are these settings a given now in Pipeline? Does it auto-create them? If not, we're going to need to deal with that situation, and also deal with a client defining the old names.

david Feb. 5, 2016, 11:46 p.m.

Yeah, there are default values for these.

I'm not sure what you mean by "a client defining the old names". Can you clarify?

chipx86 Feb. 5, 2016, 11:51 p.m.

Sorry, badly worded. I was thinking of the compatibility story of a consumer of Djblets not having updated these settings names, but this is covered by your response below.

djblets/extensions/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Alphabetical order.
```

djblets/settings.py (Diff revision 1)

The issue has been dropped. Show all issues

Removing these variables breaks backwards-compatibility. We need to set up aliases.

david Feb. 5, 2016, 11:46 p.m.

So I understand the compatibility issue with extensions that might not know what version they're getting, but if someone is consuming djblets as a dependency, I think we can and ought to say "this major version comes with an updated pipeline, here's how you update your settings". Just having aliases for these isn't going to be sufficient to have everything magically work without updates.

chipx86 Feb. 5, 2016, 11:51 p.m.

Okay. In that case, let's get a doc page together on upgrading to Djblets 0.10 where we touch upon this.

djblets/util/templatetags/compressed.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing period at the end of the line.
```

djblets/util/templatetags/compressed.py (Diff revision 1)

The issue has been resolved. Show all issues

Wonder if you could just do:

register.tag('compressed_css', stylesheet)
register.tag('compressed_js', javascript)

djblets/util/templatetags/compressed.py (Diff revision 1)
The issue has been dropped. Show all issues
```
<style> needs to be in literal backticks.
Same below.
```

setup.py (Diff revision 1)

The issue has been resolved. Show all issues

Since I know there will be someone packaging this that wants a newer pipeline, let's have a comment saying why we require exactly 1.6.0.

Description:

		This change does the work necessary to move us to a modern django-pipeline.
		This involves several independent but related pieces:
		- Bump the dependency.
		- Update existing templates to use the new `pipeline` templatetag library and
		associated `stylesheet` and `javascript` tags.
		- Add a compatibility library for third-party packages that still want to use
		the old `compressed` tag library.
		- Change settings.py to use the new `PIPELINE` structure and split out static
		media into a `staticbundles.py` file.
		- Make changes to everything that manipulates `settings.PIPELINE*` to use the
		new settings mechanism.
		- Make a few changes to the staticfiles finders and loaders to cope with
		pipeline's "simplification".
	+
	+	This also adds the very beginnings of 0.10 release notes to include
	+	compatibility instructions when updating to use this.

Commit:

-	13af21e2d7974f0db91f9556d876fd3c4f9b5b2d
+	35d3ecc747391670c90a147246d2e35895531e11

Diff:

Revision 2 (+294 -160)

Show changes

	setup.py
	djblets/settings.py
	djblets/staticbundles.py
	djblets/configforms/templates/configforms/config.html
	djblets/datagrid/templates/datagrid/datagrid.html
	djblets/extensions/manager.py
	djblets/extensions/packaging.py
	djblets/extensions/staticfiles.py
	8 more

Tool: Pyflakes
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/staticfiles.py
    djblets/staticbundles.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/extensions/manager.py
    djblets/extensions/packaging.py
    djblets/extensions/tests.py
    setup.py
    djblets/util/templatetags/compressed.py
    djblets/settings.py
    tests/settings.py

Ignored Files:
    djblets/datagrid/templates/datagrid/datagrid.html
    djblets/forms/templates/djblets_forms/admin/change_form_page.html
    docs/releasenotes/0.10.rst
    djblets/configforms/templates/configforms/config.html
    djblets/extensions/templates/extensions/extension_list.html



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/staticfiles.py
    djblets/staticbundles.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/extensions/manager.py
    djblets/extensions/packaging.py
    djblets/extensions/tests.py
    setup.py
    djblets/util/templatetags/compressed.py
    djblets/settings.py
    tests/settings.py

Ignored Files:
    djblets/datagrid/templates/datagrid/datagrid.html
    djblets/forms/templates/djblets_forms/admin/change_form_page.html
    docs/releasenotes/0.10.rst
    djblets/configforms/templates/configforms/config.html
    djblets/extensions/templates/extensions/extension_list.html

djblets/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

Summary:

-	Update to django-pipeline 1.6.0.
+	Update to django-pipeline 1.6.4 (will be 1.6.5).

Description:

		This change does the work necessary to move us to a modern django-pipeline.
		This involves several independent but related pieces:
		- Bump the dependency.
		- Update existing templates to use the new `pipeline` templatetag library and
		associated `stylesheet` and `javascript` tags.
		- Add a compatibility library for third-party packages that still want to use
		the old `compressed` tag library.
		- Change settings.py to use the new `PIPELINE` structure and split out static
		media into a `staticbundles.py` file.
		- Make changes to everything that manipulates `settings.PIPELINE*` to use the
		new settings mechanism.
		- Make a few changes to the staticfiles finders and loaders to cope with
		pipeline's "simplification".

	+	This requires what will be called django-pipeline 1.6.5 (hopefully). There's
	+	one PR that I've submitted that's already been accepted, and a second which is
	+	pending.
	+
		This also adds the very beginnings of 0.10 release notes to include
		compatibility instructions when updating to use this.

Testing Done:

		Ran unit tests
~		Built a package and verified that static media got compiled correctly.
	~	Built a djblets package and verified that static media got compiled correctly.
		Explored through the Review Board UI and checked that both the basic UI and extensions which shipped static media worked correctly.
	+	Built an extension and saw that everything worked correctly.

Commit:

-	35d3ecc747391670c90a147246d2e35895531e11
+	e74062763b73107c6860b17168e45e1c22918ecd

Diff:

Revision 3 (+351 -176)

Show changes

	setup.py
	djblets/settings.py
	djblets/staticbundles.py
	djblets/configforms/templates/configforms/config.html
	djblets/datagrid/templates/datagrid/datagrid.html
	djblets/extensions/manager.py
	djblets/extensions/packaging.py
	djblets/extensions/staticfiles.py
	8 more

Tool: Pyflakes
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/staticfiles.py
    djblets/staticbundles.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/extensions/manager.py
    djblets/extensions/packaging.py
    djblets/extensions/tests.py
    setup.py
    djblets/util/templatetags/compressed.py
    djblets/settings.py
    tests/settings.py

Ignored Files:
    djblets/datagrid/templates/datagrid/datagrid.html
    djblets/forms/templates/djblets_forms/admin/change_form_page.html
    docs/releasenotes/0.10.rst
    djblets/configforms/templates/configforms/config.html
    djblets/extensions/templates/extensions/extension_list.html



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/staticfiles.py
    djblets/staticbundles.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/extensions/manager.py
    djblets/extensions/packaging.py
    djblets/extensions/tests.py
    setup.py
    djblets/util/templatetags/compressed.py
    djblets/settings.py
    tests/settings.py

Ignored Files:
    djblets/datagrid/templates/datagrid/datagrid.html
    djblets/forms/templates/djblets_forms/admin/change_form_page.html
    docs/releasenotes/0.10.rst
    djblets/configforms/templates/configforms/config.html
    djblets/extensions/templates/extensions/extension_list.html

djblets/extensions/staticfiles.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 'find' imported but unused
```
djblets/extensions/staticfiles.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 redefinition of unused 'find' from line 5
```
djblets/extensions/templatetags/djblets_extensions.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 'staticfiles_storage' imported but unused
```
djblets/extensions/templatetags/djblets_extensions.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 'render_to_string' imported but unused
```
djblets/extensions/templatetags/djblets_extensions.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 'mark_safe' imported but unused
```
djblets/extensions/templatetags/djblets_extensions.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 'pipeline_settings' imported but unused
```
djblets/settings.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 E402 module level import not at top of file
```

Commit:

-	e74062763b73107c6860b17168e45e1c22918ecd
+	4ffea0497ce96c8c7ebcabb7f50ee3cd29011fe8

Diff:

Revision 4 (+347 -176)

Show changes

	setup.py
	djblets/settings.py
	djblets/staticbundles.py
	djblets/configforms/templates/configforms/config.html
	djblets/datagrid/templates/datagrid/datagrid.html
	djblets/extensions/manager.py
	djblets/extensions/packaging.py
	djblets/extensions/staticfiles.py
	8 more

Tool: Pyflakes
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/staticfiles.py
    djblets/staticbundles.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/extensions/manager.py
    djblets/extensions/packaging.py
    djblets/extensions/tests.py
    setup.py
    djblets/util/templatetags/compressed.py
    djblets/settings.py
    tests/settings.py

Ignored Files:
    djblets/datagrid/templates/datagrid/datagrid.html
    djblets/forms/templates/djblets_forms/admin/change_form_page.html
    docs/releasenotes/0.10.rst
    djblets/configforms/templates/configforms/config.html
    djblets/extensions/templates/extensions/extension_list.html



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/staticfiles.py
    djblets/staticbundles.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/extensions/manager.py
    djblets/extensions/packaging.py
    djblets/extensions/tests.py
    setup.py
    djblets/util/templatetags/compressed.py
    djblets/settings.py
    tests/settings.py

Ignored Files:
    djblets/datagrid/templates/datagrid/datagrid.html
    djblets/forms/templates/djblets_forms/admin/change_form_page.html
    docs/releasenotes/0.10.rst
    djblets/configforms/templates/configforms/config.html
    djblets/extensions/templates/extensions/extension_list.html

Ship it!

djblets/extensions/templatetags/djblets_extensions.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Isnt this going to be SafeText? Same below.
```

djblets/settings.py (Diff revision 4)

The issue has been resolved. Show all issues

Since we moved to pipeline always in RB, do we want to do the same here?

Commit:

-	4ffea0497ce96c8c7ebcabb7f50ee3cd29011fe8
+	afbe3220246509afc6c9ad630e5e954a8db70ef3

Diff:

Revision 5 (+331 -176)

Show changes

	setup.py
	djblets/settings.py
	djblets/staticbundles.py
	djblets/configforms/templates/configforms/config.html
	djblets/datagrid/templates/datagrid/datagrid.html
	djblets/extensions/manager.py
	djblets/extensions/packaging.py
	djblets/extensions/staticfiles.py
	8 more

Tool: Pyflakes
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/staticfiles.py
    djblets/staticbundles.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/extensions/manager.py
    djblets/extensions/packaging.py
    djblets/extensions/tests.py
    setup.py
    djblets/util/templatetags/compressed.py
    djblets/settings.py
    tests/settings.py

Ignored Files:
    djblets/datagrid/templates/datagrid/datagrid.html
    djblets/forms/templates/djblets_forms/admin/change_form_page.html
    docs/releasenotes/0.10.rst
    djblets/configforms/templates/configforms/config.html
    djblets/extensions/templates/extensions/extension_list.html



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/staticfiles.py
    djblets/staticbundles.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/extensions/manager.py
    djblets/extensions/packaging.py
    djblets/extensions/tests.py
    setup.py
    djblets/util/templatetags/compressed.py
    djblets/settings.py
    tests/settings.py

Ignored Files:
    djblets/datagrid/templates/datagrid/datagrid.html
    djblets/forms/templates/djblets_forms/admin/change_form_page.html
    docs/releasenotes/0.10.rst
    djblets/configforms/templates/configforms/config.html
    djblets/extensions/templates/extensions/extension_list.html

djblets/extensions/manager.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'datetime' imported but unused
```
djblets/extensions/manager.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'cache' imported but unused
```
djblets/extensions/manager.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'make_cache_key' imported but unused
```

Summary:

-	Update to django-pipeline 1.6.4 (will be 1.6.5).
+	Update to django-pipeline 1.6.6

Description:

		This change does the work necessary to move us to a modern django-pipeline.
		This involves several independent but related pieces:
		- Bump the dependency.
		- Update existing templates to use the new `pipeline` templatetag library and
		associated `stylesheet` and `javascript` tags.
		- Add a compatibility library for third-party packages that still want to use
		the old `compressed` tag library.
		- Change settings.py to use the new `PIPELINE` structure and split out static
		media into a `staticbundles.py` file.
		- Make changes to everything that manipulates `settings.PIPELINE*` to use the
		new settings mechanism.
		- Make a few changes to the staticfiles finders and loaders to cope with
		pipeline's "simplification".

~		This requires what will be called django-pipeline 1.6.5 (hopefully). There's
~		one PR that I've submitted that's already been accepted, and a second which is
	~	This requires django-pipeline 1.6.6, which contains several patches to fix bugs
	~	and add features that we need for this.
-		pending.

		This also adds the very beginnings of 0.10 release notes to include
		compatibility instructions when updating to use this.

Diff:

Revision 6 (+331 -176)

Show changes

	setup.py
	djblets/settings.py
	djblets/staticbundles.py
	djblets/configforms/templates/configforms/config.html
	djblets/datagrid/templates/datagrid/datagrid.html
	djblets/extensions/manager.py
	djblets/extensions/packaging.py
	djblets/extensions/staticfiles.py
	8 more

Tool: Pyflakes
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/staticfiles.py
    djblets/staticbundles.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/extensions/manager.py
    djblets/extensions/packaging.py
    djblets/extensions/tests.py
    setup.py
    djblets/util/templatetags/compressed.py
    djblets/settings.py
    tests/settings.py

Ignored Files:
    djblets/datagrid/templates/datagrid/datagrid.html
    djblets/forms/templates/djblets_forms/admin/change_form_page.html
    docs/releasenotes/0.10.rst
    djblets/configforms/templates/configforms/config.html
    djblets/extensions/templates/extensions/extension_list.html



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/staticfiles.py
    djblets/staticbundles.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/extensions/manager.py
    djblets/extensions/packaging.py
    djblets/extensions/tests.py
    setup.py
    djblets/util/templatetags/compressed.py
    djblets/settings.py
    tests/settings.py

Ignored Files:
    djblets/datagrid/templates/datagrid/datagrid.html
    djblets/forms/templates/djblets_forms/admin/change_form_page.html
    docs/releasenotes/0.10.rst
    djblets/configforms/templates/configforms/config.html
    djblets/extensions/templates/extensions/extension_list.html

djblets/extensions/manager.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'datetime' imported but unused
```
djblets/extensions/manager.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'cache' imported but unused
```
djblets/extensions/manager.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'make_cache_key' imported but unused
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (756cce7)