Defer hiding and reloading the draft banner

Review Request #7924 — Created Jan. 30, 2016 and submitted

mike_conley
Review Board
release-2.5.x
3727
13cf704...
reviewboard
We need to do this because hideAndReload might be called from
within a $.funcQueue, and on Firefox, a change to window.location
will result in later functions in the $.funcQueue not running.

Deferring until the next tick of the event loop allows the rest
of the $.funcQueue to run.

Fixes bug 3727.

Created a review request that I had edit rights on. After
publishing, I attempted to create a review on myself, and hit
"Publish" in the review dialog. Without this patch, I see the
"Are you sure you want to leave this page" popup. With this
patch, I don't see the popup, and the page reloads correctly.

Description From Last Updated

Can you change this to a /* */ comment?

daviddavid
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
    
    
  2. 
      
david
  1. Wooo!

  2. reviewboard/static/rb/js/views/draftReviewBannerView.js (Diff revision 1)
     
     
     
     
     
     
     

    Can you change this to a /* */ comment?

  3. 
      
chipx86
  1. I think there was a related fix about showing the confirmation prompt when you didn't have editing rights to the review request, for reviews/replies?

    1. Yes - I recall that too. I'll file that separately.

    2. Filed bug 4084.

  2. 
      
mike_conley
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/views/draftReviewBannerView.js
    
    
  2. 
      
mike_conley
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (a6501e7)
Loading...