[OAuth2Provider] Copy basic templates from OAuth2_provider to ReviewBoard to make it ReviewBoard

Review Request #7916 — Created Jan. 28, 2016 and discarded

Information

Review Board
master

Reviewers

Templates for confirm delete form, application detail form, registration form
from OAuth2_provider are copied to ReviewBoard with modifications to
have a ReviewBoard touch and feel. A new LESS is added for OAuth2 forms .

Manual test. Check screenshot


Description From Last Updated

Col: 13 E231 missing whitespace after ':'

reviewbotreviewbot

A few things here: We use 2 space indentation. Selectors should be in alphabetical order within their group (classes, IDs, …

chipx86chipx86

No blank line here. Put it before the {% block %} instead. Also, the {% load %} tags should be …

chipx86chipx86

We use 1 space indentation.

chipx86chipx86

The compressed_css should be indented. For template tags, we indent within the {% .. %}, like: {% block css %} …

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/templates/oauth2_provider/application_registration_form.html
        reviewboard/templates/oauth2_provider/base.html
        reviewboard/static/rb/css/pages/oauth2.less
        reviewboard/templates/oauth2_provider/application_confirm_delete.html
        reviewboard/templates/oauth2_provider/application_detail.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/templates/oauth2_provider/application_registration_form.html
        reviewboard/templates/oauth2_provider/base.html
        reviewboard/static/rb/css/pages/oauth2.less
        reviewboard/templates/oauth2_provider/application_confirm_delete.html
        reviewboard/templates/oauth2_provider/application_detail.html
    
    
  2. reviewboard/staticbundles.py (Diff revision 1)
     
     
    Show all issues
    Col: 13
     E231 missing whitespace after ':'
    
  3. 
      
LE
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/templates/oauth2_provider/application_registration_form.html
        reviewboard/templates/oauth2_provider/base.html
        reviewboard/static/rb/css/pages/oauth2.less
        reviewboard/templates/oauth2_provider/application_confirm_delete.html
        reviewboard/templates/oauth2_provider/application_detail.html
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/templates/oauth2_provider/application_registration_form.html
        reviewboard/templates/oauth2_provider/base.html
        reviewboard/static/rb/css/pages/oauth2.less
        reviewboard/templates/oauth2_provider/application_confirm_delete.html
        reviewboard/templates/oauth2_provider/application_detail.html
    
    
  2. 
      
LE
chipx86
  1. The comments regarding the HTML applies to each template.

    The biggest thing I want to go over though is the general look-and-feel. These are all showing as their own completely standalone pages, but really we want these to be more tied in with the My Account pages. Ideally, just like the auth tokens, we should have a section for registering and managing OAuth2 applications, with the form styling fitting into those pages well.

    For instance, see how GitHub does it: https://github.com/settings/applications/new

  2. reviewboard/static/rb/css/pages/oauth2.less (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    A few things here:

    • We use 2 space indentation.
    • Selectors should be in alphabetical order within their group (classes, IDs, elements, etc.)
    • These rules are a bit too generica nd are likely to conflict. We should have a parent class that's easily distinguishable for pages.
  3. Show all issues

    No blank line here. Put it before the {% block %} instead.

    Also, the {% load %} tags should be consolidated.

  4. reviewboard/templates/oauth2_provider/application_confirm_delete.html (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    We use 1 space indentation.

  5. reviewboard/templates/oauth2_provider/base.html (Diff revision 2)
     
     
     
     
    Show all issues

    The compressed_css should be indented. For template tags, we indent within the {% .. %}, like:

    {% block css %}
    {%  compressed_css "oauth2" %}
    {% endblock %}
    
  6. 
      
LE
Review request changed
Status:
Discarded
Change Summary:

Close to clear out CR queue for now