[OAuth2Provider] Copy basic templates from OAuth2_provider to ReviewBoard to make it ReviewBoard
Review Request #7916 — Created Jan. 28, 2016 and discarded
Templates for confirm delete form, application detail form, registration form from OAuth2_provider are copied to ReviewBoard with modifications to have a ReviewBoard touch and feel. A new LESS is added for OAuth2 forms .
Manual test. Check screenshot
| Description | From | Last Updated |
|---|---|---|
|
Col: 13 E231 missing whitespace after ':' |
 reviewbot
|
|
|
A few things here: We use 2 space indentation. Selectors should be in alphabetical order within their group (classes, IDs, … |
 chipx86
|
|
|
No blank line here. Put it before the {% block %} instead. Also, the {% load %} tags should be … |
chipx86
|
|
|
We use 1 space indentation. |
chipx86
|
|
|
The compressed_css should be indented. For template tags, we indent within the {% .. %}, like: {% block css %} … |
chipx86
|
LE
Change Summary:
Update reviewbot
-
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/templates/oauth2_provider/application_registration_form.html reviewboard/templates/oauth2_provider/base.html reviewboard/static/rb/css/pages/oauth2.less reviewboard/templates/oauth2_provider/application_confirm_delete.html reviewboard/templates/oauth2_provider/application_detail.html Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/templates/oauth2_provider/application_registration_form.html reviewboard/templates/oauth2_provider/base.html reviewboard/static/rb/css/pages/oauth2.less reviewboard/templates/oauth2_provider/application_confirm_delete.html reviewboard/templates/oauth2_provider/application_detail.html
-
The comments regarding the HTML applies to each template.
The biggest thing I want to go over though is the general look-and-feel. These are all showing as their own completely standalone pages, but really we want these to be more tied in with the My Account pages. Ideally, just like the auth tokens, we should have a section for registering and managing OAuth2 applications, with the form styling fitting into those pages well.
For instance, see how GitHub does it: https://github.com/settings/applications/new
-
reviewboard/static/rb/css/pages/oauth2.less (Diff revision 2) A few things here:
- We use 2 space indentation.
- Selectors should be in alphabetical order within their group (classes, IDs, elements, etc.)
- These rules are a bit too generica nd are likely to conflict. We should have a parent class that's easily distinguishable for pages.
-
reviewboard/templates/oauth2_provider/application_confirm_delete.html (Diff revision 2) No blank line here. Put it before the
{% block %}instead.Also, the
{% load %}tags should be consolidated. -
reviewboard/templates/oauth2_provider/application_confirm_delete.html (Diff revision 2) We use 1 space indentation.
-
reviewboard/templates/oauth2_provider/base.html (Diff revision 2) The
compressed_cssshould be indented. For template tags, we indent within the{% .. %}, like:{% block css %} {% compressed_css "oauth2" %} {% endblock %}
Tool: Pyflakes Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/templates/oauth2_provider/application_registration_form.html reviewboard/templates/oauth2_provider/base.html reviewboard/static/rb/css/pages/oauth2.less reviewboard/templates/oauth2_provider/application_confirm_delete.html reviewboard/templates/oauth2_provider/application_detail.html Tool: PEP8 Style Checker Processed Files: reviewboard/staticbundles.py Ignored Files: reviewboard/templates/oauth2_provider/application_registration_form.html reviewboard/templates/oauth2_provider/base.html reviewboard/static/rb/css/pages/oauth2.less reviewboard/templates/oauth2_provider/application_confirm_delete.html reviewboard/templates/oauth2_provider/application_detail.html