Summary

Migrate from basictag to simple_tag

Review Request #7910 — Created Jan. 25, 2016 and submitted Jan. 26, 2016, 2:16 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

~~7887~~, ~~7909~~

Reviewers

Groups

djblets

People

Description

Now that @basictag is becoming deprecated in Djblets 0.10, we are
migrating all usage of @basictag to Django's @Library.simple_tag
decorator. To ensure that everything works correcty, unit tests have
been added to test all tags that previously used @basictag to
ensure that they will continue to render correctly.

Several testing utilities have been added in this patch to facilitate
this migration. First off is the MemoryTemplateLoader, which loads
template sources from an in-memory string. This is to be used in
conjunction with the context managers provided by
djblets.template.loaders.util:

add_template_loader, which temporarily adds a template source
loader; and
replace_template_loaders, which temporarily replaces all the
template source loaders.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Col: 9 E303 too many blank lines (2)	reviewbot	Jan. 25, 2016, 7:34 p.m.
Col: 1 W391 blank line at end of file	reviewbot	Jan. 25, 2016, 7:34 p.m.
Col: 1 W391 blank line at end of file	reviewbot	Jan. 25, 2016, 7:35 p.m.
There's an extra line here.	david	Jan. 26, 2016, 1:25 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 26, 2016, 1:35 p.m.

Tool: PEP8 Style Checker
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/template/loaders/util.py
    djblets/gravatars/templatetags/tests.py
    djblets/extensions/templatetags/tests.py
    djblets/util/templatetags/djblets_utils.py
    djblets/template/loaders/memory.py
    djblets/util/templatetags/djblets_email.py
    djblets/gravatars/templatetags/gravatars.py



Tool: Pyflakes
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/template/loaders/util.py
    djblets/gravatars/templatetags/tests.py
    djblets/extensions/templatetags/tests.py
    djblets/util/templatetags/djblets_utils.py
    djblets/template/loaders/memory.py
    djblets/util/templatetags/djblets_email.py
    djblets/gravatars/templatetags/gravatars.py

djblets/extensions/templatetags/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 9
 E303 too many blank lines (2)
```
djblets/util/templatetags/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```

Change Summary:

PEP8

Diff:

Revision 2 (+404 -28)

Show changes

	djblets/extensions/templatetags/djblets_extensions.py
	djblets/extensions/templatetags/tests.py
	djblets/gravatars/templatetags/gravatars.py
	djblets/gravatars/templatetags/tests.py
	djblets/template/loaders/memory.py
	djblets/template/loaders/util.py
	djblets/util/templatetags/djblets_email.py
	djblets/util/templatetags/djblets_utils.py
	1 more

Tool: PEP8 Style Checker
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/template/loaders/util.py
    djblets/gravatars/templatetags/tests.py
    djblets/extensions/templatetags/tests.py
    djblets/util/templatetags/djblets_utils.py
    djblets/template/loaders/memory.py
    djblets/util/templatetags/djblets_email.py
    djblets/gravatars/templatetags/gravatars.py



Tool: Pyflakes
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/template/loaders/util.py
    djblets/gravatars/templatetags/tests.py
    djblets/extensions/templatetags/tests.py
    djblets/util/templatetags/djblets_utils.py
    djblets/template/loaders/memory.py
    djblets/util/templatetags/djblets_email.py
    djblets/gravatars/templatetags/gravatars.py

djblets/util/templatetags/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```

Change Summary:

PEP8

Diff:

Revision 3 (+403 -28)

Show changes

	djblets/extensions/templatetags/djblets_extensions.py
	djblets/extensions/templatetags/tests.py
	djblets/gravatars/templatetags/gravatars.py
	djblets/gravatars/templatetags/tests.py
	djblets/template/loaders/memory.py
	djblets/template/loaders/util.py
	djblets/util/templatetags/djblets_email.py
	djblets/util/templatetags/djblets_utils.py
	1 more

Tool: PEP8 Style Checker
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/template/loaders/util.py
    djblets/gravatars/templatetags/tests.py
    djblets/extensions/templatetags/tests.py
    djblets/util/templatetags/djblets_utils.py
    djblets/template/loaders/memory.py
    djblets/util/templatetags/djblets_email.py
    djblets/gravatars/templatetags/gravatars.py



Tool: Pyflakes
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/template/loaders/util.py
    djblets/gravatars/templatetags/tests.py
    djblets/extensions/templatetags/tests.py
    djblets/util/templatetags/djblets_utils.py
    djblets/template/loaders/memory.py
    djblets/util/templatetags/djblets_email.py
    djblets/gravatars/templatetags/gravatars.py

Just a question on use of Mock: didn't Christian want to get rid of these?

brennie Jan. 26, 2016, 1:28 p.m.

Indeed! I've found a way to not use mock here.

djblets/template/loaders/memory.py (Diff revision 3)
The issue has been resolved. Show all issues
```
There's an extra line here.
```

Change Summary:

Don't use Mock. Address David's issues.

Diff:

Revision 4 (+400 -28)

Show changes

	djblets/extensions/templatetags/djblets_extensions.py
	djblets/extensions/templatetags/tests.py
	djblets/gravatars/templatetags/gravatars.py
	djblets/gravatars/templatetags/tests.py
	djblets/template/loaders/memory.py
	djblets/template/loaders/util.py
	djblets/util/templatetags/djblets_email.py
	djblets/util/templatetags/djblets_utils.py
	1 more

Tool: Pyflakes
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/template/loaders/util.py
    djblets/gravatars/templatetags/tests.py
    djblets/extensions/templatetags/tests.py
    djblets/util/templatetags/djblets_utils.py
    djblets/template/loaders/memory.py
    djblets/util/templatetags/djblets_email.py
    djblets/gravatars/templatetags/gravatars.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/template/loaders/util.py
    djblets/gravatars/templatetags/tests.py
    djblets/extensions/templatetags/tests.py
    djblets/util/templatetags/djblets_utils.py
    djblets/template/loaders/memory.py
    djblets/util/templatetags/djblets_email.py
    djblets/gravatars/templatetags/gravatars.py

djblets/extensions/templatetags/tests.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Change Summary:

PEP8

Diff:

Revision 5 (+401 -28)

Show changes

	djblets/extensions/templatetags/djblets_extensions.py
	djblets/extensions/templatetags/tests.py
	djblets/gravatars/templatetags/gravatars.py
	djblets/gravatars/templatetags/tests.py
	djblets/template/loaders/memory.py
	djblets/template/loaders/util.py
	djblets/util/templatetags/djblets_email.py
	djblets/util/templatetags/djblets_utils.py
	1 more

Tool: PEP8 Style Checker
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/template/loaders/util.py
    djblets/gravatars/templatetags/tests.py
    djblets/extensions/templatetags/tests.py
    djblets/util/templatetags/djblets_utils.py
    djblets/template/loaders/memory.py
    djblets/util/templatetags/djblets_email.py
    djblets/gravatars/templatetags/gravatars.py



Tool: Pyflakes
Processed Files:
    djblets/util/templatetags/tests.py
    djblets/extensions/templatetags/djblets_extensions.py
    djblets/template/loaders/util.py
    djblets/gravatars/templatetags/tests.py
    djblets/extensions/templatetags/tests.py
    djblets/util/templatetags/djblets_utils.py
    djblets/template/loaders/memory.py
    djblets/util/templatetags/djblets_email.py
    djblets/gravatars/templatetags/gravatars.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.10.x (79d41e4)