Summary

Refactor extension tests to use less Mock()

Review Request #7909 — Created Jan. 25, 2016 and submitted Jan. 26, 2016, 1:46 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.8.x

Bugs

Depends On

Blocks

7910

Reviewers

Groups

djblets

People

Description

The extension tests now use a ExtensionManager subclass that provides
the entry points (which are faked via new utility classes,
FakeEntryPoint, which mocks the entry point, and FakeDistribution,
which mocks the distribution metadata) at initialization time. This
allows futher tests of extension managers to be more succinct and
robust.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Docstring?	david	Jan. 26, 2016, 1:24 p.m.

Tool: Pyflakes
Processed Files:
    djblets/extensions/tests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/extensions/tests.py

There's some formatting trouble in your description.

djblets/extensions/tests.py (Diff revision 1)
Show all issues
```
Docstring?
```
1. brennie Jan. 26, 2016, 1:24 p.m.
  There is one.
2. david Jan. 26, 2016, 1:36 p.m.
  I may be behind on my coffee intake for the day.

Description:

		The extension tests now use a `ExtensionManager` subclass that provides
		the entry points (which are faked via new utility classes,
~		`FakeEntryPoint`, which mocks the entry point`, and`FakeDistribution`,
	~	`FakeEntryPoint`, which mocks the entry point, and `FakeDistribution`,
		which mocks the distribution metadata) at initialization time. This
		allows futher tests of extension managers to be more succinct and
		robust.

Diff:

Revision 2 (+212 -165)

Show changes

djblets/extensions/tests.py

Tool: Pyflakes
Processed Files:
    djblets/extensions/tests.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/extensions/tests.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.8.x (08b30e6)

djblets/extensions/tests.py (Diff revision 1)